Linux-Fsdevel Archive on lore.kernel.org
 help / Atom feed
From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 16/22] coda: remove uapi/linux/coda_psdev.h
Date: Fri, 17 May 2019 19:51:40 -0400
Message-ID: <B41F3799-491C-48C6-8F9C-40EAF832CCD6@cs.cmu.edu> (raw)
In-Reply-To: <20190517162951.79c957039dd6cbb9b7d5b791@linux-foundation.org>

patch #15 moves include/linux/coda_psdev.h to fs/coda/coda_psdev.h and patch #16 removes include/uapi/linux/coda_psdev.h.

Maybe #15 wasn't applied yet?

Jan


On May 17, 2019 7:29:51 PM EDT, Andrew Morton <akpm@linux-foundation.org> wrote:
>On Fri, 17 May 2019 14:36:54 -0400 Jan Harkes <jaharkes@cs.cmu.edu>
>wrote:
>
>> Nothing is left in this header that is used by userspace.
>> 
>>  fs/coda/coda_psdev.h            |  5 ++++-
>>  include/uapi/linux/coda_psdev.h | 10 ----------
>
>Confused.  There is no fs/coda/coda_psdev.h.  I did this.  It compiles
>OK...
>
>
>From: Jan Harkes <jaharkes@cs.cmu.edu>
>Subject: coda: remove uapi/linux/coda_psdev.h
>
>Nothing is left in this header that is used by userspace.
>
>Link:
>http://lkml.kernel.org/r/bb11378cef94739f2cf89425dd6d302a52c64480.1558117389.git.jaharkes@cs.cmu.edu
>Signed-off-by: Jan Harkes <jaharkes@cs.cmu.edu>
>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>---
>
> include/linux/coda_psdev.h      |    5 ++++-
> include/uapi/linux/coda_psdev.h |   10 ----------
> 2 files changed, 4 insertions(+), 11 deletions(-)
>
>--- a/include/linux/coda_psdev.h~coda-remove-uapi-linux-coda_psdevh
>+++ a/include/linux/coda_psdev.h
>@@ -3,8 +3,11 @@
> #define __CODA_PSDEV_H
> 
> #include <linux/backing-dev.h>
>+#include <linux/magic.h>
> #include <linux/mutex.h>
>-#include <uapi/linux/coda_psdev.h>
>+
>+#define CODA_PSDEV_MAJOR 67
>+#define MAX_CODADEVS  5	   /* how many do we allow */
> 
> struct kstatfs;
> 
>--- a/include/uapi/linux/coda_psdev.h
>+++ /dev/null
>@@ -1,10 +0,0 @@
>-/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
>-#ifndef _UAPI__CODA_PSDEV_H
>-#define _UAPI__CODA_PSDEV_H
>-
>-#include <linux/magic.h>
>-
>-#define CODA_PSDEV_MAJOR 67
>-#define MAX_CODADEVS  5	   /* how many do we allow */
>-
>-#endif /* _UAPI__CODA_PSDEV_H */
>_

  parent reply index

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 18:36 [PATCH 00/22] Coda updates Jan Harkes
2019-05-17 18:36 ` [PATCH 01/22] coda: pass the host file in vma->vm_file on mmap Jan Harkes
     [not found]   ` <20190518122241.D867120B7C@mail.kernel.org>
2019-05-18 13:18     ` Jan Harkes
2019-05-17 18:36 ` [PATCH 02/22] uapi linux/coda.h: use __kernel_pid_t for userspace Jan Harkes
2019-05-17 18:36 ` [PATCH 03/22] uapi linux/coda_psdev.h: move upc_req definition from uapi to kernel side headers Jan Harkes
2019-05-17 18:36 ` [PATCH 04/22] coda: add error handling for fget Jan Harkes
2019-05-17 18:36 ` [PATCH 05/22] coda: potential buffer overflow in coda_psdev_write() Jan Harkes
2019-05-17 18:36 ` [PATCH 06/22] coda: Fix build using bare-metal toolchain Jan Harkes
2019-05-17 18:36 ` [PATCH 07/22] coda: don't try to print names that were considered too long Jan Harkes
2019-05-17 18:36 ` [PATCH 08/22] uapi linux/coda_psdev.h: Move CODA_REQ_ from uapi to kernel side headers Jan Harkes
2019-05-17 18:36 ` [PATCH 09/22] coda: clean up indentation, replace spaces with tab Jan Harkes
2019-05-17 18:36 ` [PATCH 10/22] coda: stop using 'struct timespec' in user API Jan Harkes
2019-05-17 18:36 ` [PATCH 11/22] coda: change Coda's user api to use 64-bit time_t in timespec Jan Harkes
2019-05-17 18:36 ` [PATCH 12/22] coda: get rid of CODA_ALLOC() Jan Harkes
2019-05-17 18:36 ` [PATCH 13/22] coda: get rid of CODA_FREE() Jan Harkes
2019-05-17 18:36 ` [PATCH 14/22] coda: bump module version Jan Harkes
2019-05-17 18:36 ` [PATCH 15/22] coda: Move internal defs out of include/linux/ [ver #2] Jan Harkes
2019-05-17 18:36 ` [PATCH 16/22] coda: remove uapi/linux/coda_psdev.h Jan Harkes
2019-05-17 23:29   ` Andrew Morton
2019-05-17 23:49     ` Andrew Morton
2019-05-17 23:51     ` Jan Harkes [this message]
2019-05-17 18:36 ` [PATCH 17/22] coda: destroy mutex in put_super() Jan Harkes
2019-05-17 18:36 ` [PATCH 18/22] coda: use SIZE() for stat Jan Harkes
2019-05-17 18:36 ` [PATCH 19/22] coda: add __init to init_coda_psdev() Jan Harkes
2019-05-17 18:36 ` [PATCH 20/22] coda: remove sysctl object from module when unused Jan Harkes
2019-05-17 18:36 ` [PATCH 21/22] coda: remove sb test in coda_fid_to_inode() Jan Harkes
2019-05-17 18:37 ` [PATCH 22/22] coda: ftoc validity check integration Jan Harkes
  -- strict thread matches above, loose matches on Subject: below --
2019-03-20 16:45 [PATCH 00/22] Coda updates for linux-5.1 Jan Harkes
2019-03-20 16:45 ` [PATCH 16/22] coda: remove uapi/linux/coda_psdev.h Jan Harkes

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B41F3799-491C-48C6-8F9C-40EAF832CCD6@cs.cmu.edu \
    --to=jaharkes@cs.cmu.edu \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org linux-fsdevel@archiver.kernel.org
	public-inbox-index linux-fsdevel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox