From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D579C43460 for ; Fri, 16 Apr 2021 07:32:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 774636117A for ; Fri, 16 Apr 2021 07:32:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239663AbhDPHdP (ORCPT ); Fri, 16 Apr 2021 03:33:15 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:40308 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239578AbhDPHdO (ORCPT ); Fri, 16 Apr 2021 03:33:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1618558371; x=1650094371; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=2j5kx44k7zzrm3cFdECiFFkl/VmM0iyiyaG5MGFQrW0=; b=fbyOeNNZxkZJqGUogF9+HiZuQD9au2TM8X1ULbNjn+U7a2+zH/9yuvtT HplmK9eWANj320ivbrGR1t4EsacZ66vk0alr6gWhNQ5AZxLhOFuuZwrY9 UDj+vhZdRls7XYWYKRHfePbsepr6005RBn+lp75mj1PrK//bFMUBaGUt2 tNGEJuf44ZJ2uo4VKsUNRu+ivzU8Yx6MUMgizSZXOGo6GGlBVnGQq7jQ1 dlvIJ8JXtz3ANucBFUT2XqV3DfypyrWh9HuqyBC8GFxMFqi7fpQHqRHFn LwPCyZf8YJEm57U1qTS5wxsYupySGMJXQs0fbaUnSM0MXu+qEfbaKmelM g==; IronPort-SDR: FAKrQDSf36ag+RfeQod415beWzFfpxvtEq63gc8V1iKXt4jRdA2mCyNfqEFH94Pc7c1qeC1oOO xN5/eObe+iErzWyGFdIxNX4DILqsW65iM8Td4N+ay4LBxLk4Q9WGUZVQql4QgZQfoIl3V8hzgL jSZ7Lx2pkxq+gZt4rj+bRTvxDS+tQ3YAHa+R/ee89vKYE6bOO+Vbvwo74KTL7pJc9IWVARnsQq XoAVWqMzFXpoSVv3ymxUTJ+t3V35MvK2Jycu0payzjEYExv4OCIqx6w5vbDRTvZZ1NQE+AToqU K88= X-IronPort-AV: E=Sophos;i="5.82,226,1613404800"; d="scan'208";a="165620708" Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hgst.iphmx.com with ESMTP; 16 Apr 2021 15:30:35 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/GAZX7rSSMr9aDaAMvd9MID851Uv8NaFAkvCb4SyZd/JltK0Tfo+rhwnzTT2IV5MbrEWqo0fTp1o0i0jvcS2MWF+Hf+mkOXeAX7uNaq+gEuqLmfzHfFfEymXHhApqNjYtvj6nHkOr9+k45ZMgm5pXJ1YXUUPnANUi39MxRuMT0UTLvuA3lHn7RH9PWTOlOuuzepDf2tKhgLgUh2wMLoXJJyps4P6KEBN5CCHte/WYodHyOGR9rtWnDXIVhSh/p+salWkORhv+xL0UQU+0t7BXQX75cwCAZwBSeQeAuh+XuFQ5N75Q1/8lVNBU5a5te+TRN3UoWhFscihYNQKe+sfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aP6sY37UXVp54JB+x2hefY4yK1N+D/HDKTk38sQRNvI=; b=Kp67K1P9rbROlkkqOcS1WQ2BYOo1GKYLWb1f4fbO7/fFPvHMIGPGpYlTd4PJMMjY6MXkBx4rHunSxpmRSFTpJVTcMErm58ew80rctdbDLGzGnUybvbhRXE8/3jLfHUs1MnkCPdlehF1Dp3EED1PmgdlqAaoW8xoLZQLRH7BPpajboTLOegUL2FxeRS4Kb/oAW7XrNfq2nYA0i9CPg1KK8y/Iox2XxG+FFJxFtTyweRdH5Baep7tM366WdmjR3bjZG57O8hfvO40mXc0QlwKO2mRqxvvFWURHW6lkqAeUBmN3K6mh+79FbQ2uC2OFaenrSE5GOd+JfOCIlY/afvQtrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aP6sY37UXVp54JB+x2hefY4yK1N+D/HDKTk38sQRNvI=; b=lLEsULuqsabq9eSFCxBf7PBwK/MtiuDO9zzrVgP4tlmulWam9j2veseaDrIt15lyfq01aZZuJdvDqvM6yLzr6nWiEtMYYpvPO9McfKnykLBUfSjT90F1tSnxFwiqpkEmJlLDudo37Tz+tyAOQvZLdkpAbI+W2fK4rf0zdGALQmY= Received: from BL0PR04MB6514.namprd04.prod.outlook.com (2603:10b6:208:1ca::23) by MN2PR04MB6415.namprd04.prod.outlook.com (2603:10b6:208:1a4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Fri, 16 Apr 2021 07:30:24 +0000 Received: from BL0PR04MB6514.namprd04.prod.outlook.com ([fe80::8557:ab07:8b6b:da78]) by BL0PR04MB6514.namprd04.prod.outlook.com ([fe80::8557:ab07:8b6b:da78%3]) with mapi id 15.20.4042.016; Fri, 16 Apr 2021 07:30:24 +0000 From: Damien Le Moal To: Johannes Thumshirn , "dm-devel@redhat.com" , Mike Snitzer , "linux-block@vger.kernel.org" , Jens Axboe , "linux-nvme@lists.infradead.org" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "linux-fsdevel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , David Sterba , Josef Bacik CC: Shinichiro Kawasaki , Naohiro Aota Subject: Re: [PATCH 2/4] dm crypt: Fix zoned block device support Thread-Topic: [PATCH 2/4] dm crypt: Fix zoned block device support Thread-Index: AQHXMm1hiOyme3G/H0G7ONrrey5MQg== Date: Fri, 16 Apr 2021 07:30:24 +0000 Message-ID: References: <20210416030528.757513-1-damien.lemoal@wdc.com> <20210416030528.757513-3-damien.lemoal@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; x-originating-ip: [2400:2411:43c0:6000:c420:851d:e64f:2199] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 42bbae3b-f10d-4685-2664-08d900a97fcd x-ms-traffictypediagnostic: MN2PR04MB6415: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: P18iKaewacv+Wa048lgjHjpiyEoKrS3dPIanCi20jjc4sv9RN2/XgIk535GD+lZdOdmcZBhwyyHvbtw8HFVc5dZP1OnOIYgHWf+bghw5ClrYGUaT0VBuwkis2UkeRZ5F4LN7BXmiq+Vt2bj15OWgYD+/I6ntz+akpF/Ui6cgDoYrT0EX6J9XUeZaL/UKPTTMRWm7fEFo1QAlxHdtxdXFDPec2A50pNthjHOWzidaIq2yAAfHyY8HsDX5sgMc2nCDi66nTbsTzSNard4F4fEioY3TFtTb53v/19VMce7o2feU0580R2CB5TjTLdP3xsgkp5m530lA8etvHjYGutrq4xr7pTRYR3C1yYLMJkvR8Vrzfm9qY4MlooQye3ryMynoZY8lYDmfJVW6M01JYeqnoKSzAKfqDhC0+mAQdHiqgn9cZNYxDYVcFVEy1TFz3Hij+0UaK1AN56WNLl4FKA+c0hBj/L9O0S9bHi9BsrBGJTUkHtSdn6E74PymzR7ujJIOv2qpqIUdwzpa5pAtAHi+EKN+SK/YnCgcZrXXv4X5HRCG0GOMGOPuyvi3L49DkUD4T8U5zGLsg5HGdQ/v+f2OcsBVmHXQHAbCRR079eU+z1PcuIGZ4jQsxmKzQQcm4No5NOT28TFwT6yc2DvwCAP3ew== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR04MB6514.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(396003)(136003)(39860400002)(7416002)(8676002)(478600001)(66946007)(55016002)(2906002)(122000001)(921005)(316002)(186003)(9686003)(110136005)(8936002)(54906003)(66556008)(86362001)(38100700002)(76116006)(66446008)(91956017)(33656002)(52536014)(4326008)(6506007)(7696005)(5660300002)(71200400001)(66476007)(64756008)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8L67xb8/47Ji1HC8CpbkiVcAmN9mGBIwwEkWDnVuRyIVf8io+YDRKNJrbpjI?= =?us-ascii?Q?ILqC5rNE9glZBV2tUnMDJupaSTdlJ+zywtnQrLhXQr9NwGG6X3B3jqfpV2N7?= =?us-ascii?Q?8BIvzT9zF7Td+s9rA1FLstFIUvpFV6kDiJ7wc6gWOBp/c8/g4TZnDGxjl6PZ?= =?us-ascii?Q?B9so6HyM0N6DDRDC0nFS3fcCcl2vf1gwbxlCp4SzDudJPh3GbQY1SAMYt1o6?= =?us-ascii?Q?dHas6AzSOvcG+AKfgHVX3CHCsjyLaBLQ32vxH6V8H3AlEB8HcXDyqll5OuZg?= =?us-ascii?Q?cCUOQuJYjskvkL41/foTEjh8lBC1dM581rsOKGFoKYYIsCu3y5D25xPJc5IS?= =?us-ascii?Q?m/holDsu07ZFRlGHHwWxFeNALm7xH+hvE6AfajkCi3Hdp98zUx5n/xYSN/0z?= =?us-ascii?Q?Cy+OAAXWXLpahmBoU01cR3eUqigzYqdGZMqEBUeRNfH4aVHdQ2kCybkxNUcG?= =?us-ascii?Q?hezu2XADOQKJ/MlslIBAf3uQXXg1j4zNMy/lmhqLuL9McH+ls6Ujnml/jUhw?= =?us-ascii?Q?ErOeb9iPiDowMa47inFb1mCFsf2W5lRsE1GHlUG3EjMiJ+ct/AnDtGPLoadS?= =?us-ascii?Q?OjXVMgse8q/iOzFCoo7lN5HLhjnmg41Lwx8Y+ArAotyvwpw+d2/YtyCu0wht?= =?us-ascii?Q?tWJSECJnb2Cs5TfYDdsPsewvjekwtljbCCqlMthZiFJuVOh6HBF+UVqDq+39?= =?us-ascii?Q?OBwBRhStQLHkEhwPl9FtUKNxnripgL4G7yJ20afOycgnMhMzVsK7dMft4CNZ?= =?us-ascii?Q?6qjahg7wWjdtCwYNu8H+mAWCY0gl9UUcLuw+dyWoXzCJwKGBCerFU12S52xz?= =?us-ascii?Q?slj9RhCR2QngN5ipnqV2pNkoN1tAhkmMAi4LS5v3jGC98cyhVCQF6SwZNjLe?= =?us-ascii?Q?kiHEtCDj1ZVp6BA0tq0j3jgOZ2wFLu4B+nX7fgKNM4NEvh2ZJ5OztoSlIHVM?= =?us-ascii?Q?0H+Jo+Aj9xpfYrDUeTB10Oli9b+drvfumBAG9e3y6Q2hVWTeK6b2oiIi8/X2?= =?us-ascii?Q?0HZqOWV8iZHP1MTVVDCwN/Zl/+kD2kiObILvqYZ7FR8MtY/KptgDyQ/ii6M4?= =?us-ascii?Q?Hq7zS1xMqiY0BPX48T4yGlEJL7mVwkW3K+cHCw2DPApUzI9DBSVdi2VtzuSX?= =?us-ascii?Q?xhfchVQKilReovZzv/Jy5ppUaw7C4VsjrzYPI+cLbQBT0+LBU2YtdJD8QXFg?= =?us-ascii?Q?u0AArXt8ykybRJlLoUr4+GSs3TMcVUG0LWRH+WS6pz6bEfrFfWGb7RXTleT/?= =?us-ascii?Q?sSO76qh07m5n6BNKS38+jwOkqBd6nzm+DvKKH1MPnlrEWm5pfrncQoavdUha?= =?us-ascii?Q?O0HS7jdsi5L4XRnoXNzDnXQhHd1AULIVbhvllGbJ+55mqaKVFLOG9eGqgBRo?= =?us-ascii?Q?HNYcBAU0cNKelmIUwiadFopj2wrw1QphCSSQB5FWNmB8vhSdng=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR04MB6514.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42bbae3b-f10d-4685-2664-08d900a97fcd X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2021 07:30:24.2025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eTPsBRoy3VXyjOKoQmWqeek45ohboElu8YdvmwxtejOsvB66/jyz2nZWeDcfdGUYJOvUlPCV34A7dWRPNk83Kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6415 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2021/04/16 16:13, Johannes Thumshirn wrote:=0A= > On 16/04/2021 05:05, Damien Le Moal wrote:=0A= > =0A= > [...]=0A= > =0A= >> + CRYPT_IV_NO_SECTORS, /* IV calculation does not use sectors */=0A= > =0A= > [...]=0A= > =0A= >> - if (ivmode =3D=3D NULL)=0A= >> + if (ivmode =3D=3D NULL) {=0A= >> cc->iv_gen_ops =3D NULL;=0A= >> - else if (strcmp(ivmode, "plain") =3D=3D 0)=0A= >> + set_bit(CRYPT_IV_NO_SECTORS, &cc->cipher_flags);=0A= >> + } else if (strcmp(ivmode, "plain") =3D=3D 0)=0A= > =0A= > [...]=0A= > =0A= >> + if (!test_bit(CRYPT_IV_NO_SECTORS, &cc->cipher_flags)) {=0A= >> + DMWARN("Zone append is not supported with sector-based IV cyphers");= =0A= >> + ti->zone_append_not_supported =3D true;=0A= >> + }=0A= > =0A= > I think this negation is hard to follow, at least I had a hard time=0A= > reviewing it.=0A= > =0A= > Wouldn't it make more sense to use CRYPT_IV_USE_SECTORS, set the bit=0A= > for algorithms that use sectors as IV (like plain64) and then do a =0A= > normal=0A= =0A= There are only 2 IV modes that do not use sectors. null and random. All oth= ers=0A= do. Hence the "NO_SECTORS" choice. That is the exception rather than the no= rm,=0A= the flag indicates that.=0A= =0A= > =0A= > if (test_bit(CRYPT_IV_USE_SECTORS, &cc->cipher_flags)) {=0A= > DMWARN("Zone append is not supported with sector-based IV cyphers");=0A= > ti->zone_append_not_supported =3D true;=0A= > }=0A= > =0A= > i.e. without the double negation?=0A= =0A= Yes. I agree, it is more readable. But adds more lines for the same result.= I=0A= could add a small boolean helper to make the "!test_bit(CRYPT_IV_NO_SECTORS= ,=0A= &cc->cipher_flags)" easier to understand.=0A= =0A= =0A= > =0A= > =0A= =0A= =0A= -- =0A= Damien Le Moal=0A= Western Digital Research=0A=