From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Tim Waugh <tim@cyberelk.net>, Borislav Petkov <bp@alien8.de>,
Jan Kara <jack@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/7] hfsplus: stop using ioctl_by_bdev
Date: Thu, 23 Apr 2020 07:42:26 +0000 [thread overview]
Message-ID: <BY5PR04MB690068E22B67AB977BDB8046E7D30@BY5PR04MB6900.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200423071224.500849-6-hch@lst.de
On 2020/04/23 16:16, Christoph Hellwig wrote:
> Instead just call the CD-ROM layer functionality directly.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/hfsplus/wrapper.c | 33 ++++++++++++++++++---------------
> 1 file changed, 18 insertions(+), 15 deletions(-)
>
> diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
> index 08c1580bdf7a..61eec628805d 100644
> --- a/fs/hfsplus/wrapper.c
> +++ b/fs/hfsplus/wrapper.c
> @@ -127,31 +127,34 @@ static int hfsplus_read_mdb(void *bufptr, struct hfsplus_wd *wd)
> static int hfsplus_get_last_session(struct super_block *sb,
> sector_t *start, sector_t *size)
> {
> - struct cdrom_multisession ms_info;
> - struct cdrom_tocentry te;
> - int res;
> + struct cdrom_device_info *cdi = disk_to_cdi(sb->s_bdev->bd_disk);
>
> /* default values */
> *start = 0;
> *size = i_size_read(sb->s_bdev->bd_inode) >> 9;
>
> if (HFSPLUS_SB(sb)->session >= 0) {
> + struct cdrom_tocentry te;
> +
> + if (!cdi)
> + return -EINVAL;
> +
> te.cdte_track = HFSPLUS_SB(sb)->session;
> te.cdte_format = CDROM_LBA;
> - res = ioctl_by_bdev(sb->s_bdev,
> - CDROMREADTOCENTRY, (unsigned long)&te);
> - if (!res && (te.cdte_ctrl & CDROM_DATA_TRACK) == 4) {
> - *start = (sector_t)te.cdte_addr.lba << 2;
> - return 0;
> + if (cdrom_read_tocentry(cdi, &te) ||
> + (te.cdte_ctrl & CDROM_DATA_TRACK) != 4) {
> + pr_err("invalid session number or type of track\n");
> + return -EINVAL;
> }
> - pr_err("invalid session number or type of track\n");
> - return -EINVAL;
> + *start = (sector_t)te.cdte_addr.lba << 2;
> + } else if (cdi) {
> + struct cdrom_multisession ms_info;
> +
> + ms_info.addr_format = CDROM_LBA;
> + if (cdrom_multisession(cdi, &ms_info) == 0 && ms_info.xa_flag)
> + *start = (sector_t)ms_info.addr.lba << 2;
> }
> - ms_info.addr_format = CDROM_LBA;
> - res = ioctl_by_bdev(sb->s_bdev, CDROMMULTISESSION,
> - (unsigned long)&ms_info);
> - if (!res && ms_info.xa_flag)
> - *start = (sector_t)ms_info.addr.lba << 2;
> +
White space change here, but I think it's ok. I do like a blank line before
return :)
> return 0;
> }
>
>
Looks OK to me.
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2020-04-23 7:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 7:12 stop using ioctl_by_bdev for file system access to CDROMs Christoph Hellwig
2020-04-23 7:12 ` [PATCH 1/7] block: add a cdrom_device_info pointer to struct gendisk Christoph Hellwig
2020-04-23 7:40 ` Damien Le Moal
2020-04-23 7:12 ` [PATCH 2/7] ide-cd: rename cdrom_read_tocentry Christoph Hellwig
2020-04-23 7:41 ` Damien Le Moal
2020-04-23 7:12 ` [PATCH 3/7] cdrom: factor out a cdrom_read_tocentry helper Christoph Hellwig
2020-04-23 7:41 ` Damien Le Moal
2020-04-23 7:12 ` [PATCH 4/7] cdrom: factor out a cdrom_multisession helper Christoph Hellwig
2020-04-23 7:41 ` Damien Le Moal
2020-04-23 7:12 ` [PATCH 5/7] hfsplus: stop using ioctl_by_bdev Christoph Hellwig
2020-04-23 7:42 ` Damien Le Moal [this message]
2020-04-23 7:12 ` [PATCH 6/7] isofs: " Christoph Hellwig
2020-04-23 7:42 ` Damien Le Moal
2020-04-23 11:03 ` Jan Kara
2020-04-24 6:52 ` Christoph Hellwig
2020-04-24 9:21 ` Jan Kara
2020-04-23 7:12 ` [PATCH 7/7] udf: " Christoph Hellwig
2020-04-23 7:43 ` Damien Le Moal
2020-04-23 11:05 ` Jan Kara
2020-04-25 7:56 stop using ioctl_by_bdev for file system access to CDROMs v2 Christoph Hellwig
2020-04-25 7:57 ` [PATCH 5/7] hfsplus: stop using ioctl_by_bdev Christoph Hellwig
2020-04-27 6:18 ` Hannes Reinecke
2020-05-04 16:16 ` Jens Axboe
2020-05-04 16:21 ` Christoph Hellwig
2020-05-04 16:41 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR04MB690068E22B67AB977BDB8046E7D30@BY5PR04MB6900.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).