From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [git pull] vfs fixes Date: Sat, 10 Mar 2012 13:49:21 -0800 Message-ID: References: <20120310213050.GD23916@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Al Viro Return-path: In-Reply-To: <20120310213050.GD23916@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Mar 10, 2012 at 1:30 PM, Al Viro wrot= e: > > Jan Kara (2): > =A0 =A0 =A0vfs: Fix missed wakeup in I_NEW handling Christ. This one is too ugly to live. I'm not pulling crap like this. It's f*^&ing stupid to take a lock, calculate a bitqueue, and just generally be an absolute ass-hat about things for waiting for a bit that is already set 99.999% of the time. May I suggest just reverting that commit 250df6ed instead. It added all these insane things for no good reason. The comment said they are going away, but if they are just multiplying in ways like this, I really think the damn thing needs to be reverted. Any change that causes code like this is by definition not a good change. Linus