From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-it0-f68.google.com ([209.85.214.68]:53755 "EHLO
        mail-it0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751420AbeE0XEs (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Sun, 27 May 2018 19:04:48 -0400
Received: by mail-it0-f68.google.com with SMTP id n64-v6so12864029itb.3
        for <linux-fsdevel@vger.kernel.org>; Sun, 27 May 2018 16:04:48 -0700 (PDT)
MIME-Version: 1.0
References: <20180527222029.GR30522@ZenIV.linux.org.uk>
In-Reply-To: <20180527222029.GR30522@ZenIV.linux.org.uk>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 27 May 2018 16:04:37 -0700
Message-ID: <CA+55aFwW5VtwanEVdUQH5MrE9iqP2LqvK6fPmHW1pRS+_T=RXA@mail.gmail.com>
Subject: Re: [RFC][PATCH] rmdir(),rename(): do shrink_dcache_parent() only on success
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sun, May 27, 2018 at 3:20 PM Al Viro <viro@zeniv.linux.org.uk> wrote:

> We should've done that call right *after* successful ->rmdir().  That
> reduces contention caused by tree-walking in shrink_dcache_parent()
> and, especially, contention caused by evictions in two nested subtrees
> going on in parallel.  The same goes for directory-overwriting rename() -
> the story there had been parallel to that of rmdir().

Looks eminently sane to me.

               Linus