From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-it0-f67.google.com ([209.85.214.67]:46612 "EHLO
        mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933942AbdJJUbp (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 10 Oct 2017 16:31:45 -0400
MIME-Version: 1.0
In-Reply-To: <20171010124421.c545e6308fed5a585acd43cd@linux-foundation.org>
References: <20171006211541.GA7409@bombadil.infradead.org> <20171010124421.c545e6308fed5a585acd43cd@linux-foundation.org>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 10 Oct 2017 13:31:44 -0700
Message-ID: <CA+55aFxcMhj1TfBbk3G4XKzu8fjQDYPiFNS0W8pFqMJ6bdA46Q@mail.gmail.com>
Subject: Re: [PATCH] Fix mpage_writepage() for pages with buffers
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
        OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        Ross Zwisler <ross.zwisler@linux.intel.com>,
        Toshi Kani <toshi.kani@hpe.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Oct 10, 2017 at 12:44 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> This is all pretty mature code (isn't it?).  Any idea why this bug
> popped up now?

Also, while the patch looks sane, the

        clean_buffers(page, PAGE_SIZE);

line really threw me. That's an insane value to pick, it looks like
"bytes in page", but it isn't. It's just a random value that is bigger
than "PAGE_SIZE >> SECTOR_SHIFT".

I'd prefer to see just ~0u if the intention is just "bigger than
anything possible".

            Linus