linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] Misc fs updates for 4.17-rc2
@ 2018-04-19  9:49 Jan Kara
  2018-04-20 16:05 ` Linus Torvalds
  0 siblings, 1 reply; 6+ messages in thread
From: Jan Kara @ 2018-04-19  9:49 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-fsdevel

  Hello Linus,

  could you please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_4.17-rc2

to get:
 * isofs memory leak fix
 * two fsnotify fixes of event mask handling
 * udf fix of UTF-16 handling
 * couple other smaller cleanups

Note that I've experimentally created this pull request with a signed tag.
Please speak up if I did anything wrong.

Top of the tree is 44f06ba8297c. The full shortlog is:

Amir Goldstein (4):
      fanotify: fix logic of events on child
      fsnotify: fix ignore mask logic in send_to_group()
      fsnotify: fix typo in a comment about mark->g_list
      MAINTAINERS: add an entry for FSNOTIFY infrastructure

Chengguang Xu (1):
      isofs: fix potential memory leak in mount option parsing

Jan Kara (1):
      udf: Fix leak of UTF-16 surrogates into encoded strings

Jia-Ju Bai (1):
      fs: quota: Replace GFP_ATOMIC with GFP_KERNEL in dquot_init

Kyle Spiers (1):
      isofs compress: Remove VLA usage

Souptick Joarder (1):
      fs: ext2: Adding new return type vm_fault_t

The diffstat is

 MAINTAINERS                      |  8 ++++++++
 fs/ext2/file.c                   |  4 ++--
 fs/isofs/compress.c              | 19 ++++++++++++++++---
 fs/isofs/inode.c                 |  3 +++
 fs/notify/fanotify/fanotify.c    | 34 +++++++++++++++-------------------
 fs/notify/fsnotify.c             | 25 +++++++++++--------------
 fs/quota/dquot.c                 |  2 +-
 fs/udf/unicode.c                 |  6 ++++++
 include/linux/fsnotify_backend.h |  2 +-
 9 files changed, 63 insertions(+), 40 deletions(-)

							Thanks
								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] Misc fs updates for 4.17-rc2
  2018-04-19  9:49 [GIT PULL] Misc fs updates for 4.17-rc2 Jan Kara
@ 2018-04-20 16:05 ` Linus Torvalds
  2018-04-22  0:03   ` Jan Kara
  0 siblings, 1 reply; 6+ messages in thread
From: Linus Torvalds @ 2018-04-20 16:05 UTC (permalink / raw)
  To: Jan Kara; +Cc: linux-fsdevel

On Thu, Apr 19, 2018 at 2:49 AM, Jan Kara <jack@suse.cz> wrote:
>
>   could you please pull from
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_4.17-rc2

Please use git request-pull, and actually verify the error messages.

There is no tag with the name "for_4.17-rc2".

There *is* a tag with the name "for_v4.17-rc2"

Of course, that tag then seems to have the contents "\n", which isn't
very useful, but I don't care - as long as there  is an explanation in
either the email _or_ the tag message, it's fine.

So the signed tag did work, you just didn't point to the right name.

                Linus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] Misc fs updates for 4.17-rc2
  2018-04-20 16:05 ` Linus Torvalds
@ 2018-04-22  0:03   ` Jan Kara
  2018-04-22  1:20     ` Linus Torvalds
  0 siblings, 1 reply; 6+ messages in thread
From: Jan Kara @ 2018-04-22  0:03 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Jan Kara, linux-fsdevel

On Fri 20-04-18 09:05:23, Linus Torvalds wrote:
> On Thu, Apr 19, 2018 at 2:49 AM, Jan Kara <jack@suse.cz> wrote:
> >
> >   could you please pull from
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_4.17-rc2
> 
> Please use git request-pull, and actually verify the error messages.
> 
> There is no tag with the name "for_4.17-rc2".
> 
> There *is* a tag with the name "for_v4.17-rc2"

Ah, sorry. I was manually hand-editing the pull request and probably
screwed up the tag. Normally the script uses the same string for generating
& pushing the tag and for constructing an email.

> Of course, that tag then seems to have the contents "\n", which isn't
> very useful, but I don't care - as long as there  is an explanation in
> either the email _or_ the tag message, it's fine.

Is one or the other prefered? I don't really care it just seemed stupid to
write the same thing in both places...

> So the signed tag did work, you just didn't point to the right name.

Thanks for checking!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] Misc fs updates for 4.17-rc2
  2018-04-22  0:03   ` Jan Kara
@ 2018-04-22  1:20     ` Linus Torvalds
  0 siblings, 0 replies; 6+ messages in thread
From: Linus Torvalds @ 2018-04-22  1:20 UTC (permalink / raw)
  To: Jan Kara; +Cc: linux-fsdevel

On Sat, Apr 21, 2018 at 5:03 PM, Jan Kara <jack@suse.cz> wrote:
> On Fri 20-04-18 09:05:23, Linus Torvalds wrote:
>
>> Of course, that tag then seems to have the contents "\n", which isn't
>> very useful, but I don't care - as long as there  is an explanation in
>> either the email _or_ the tag message, it's fine.
>
> Is one or the other prefered? I don't really care it just seemed stupid to
> write the same thing in both places...

It doesn't matter. I'll just cut-and-paste it from the email and
usually end up reformatting anyway since I'll quote it as the reason
for the pull (ie it normally gets indented etc).

I just reacted to the fact that yours was so odd. It was the two
characters "\n", so not even just a newline, but literally those two
characters.

That was a first to me. People often end up just putting a few filler
words (like "fs updates" or whatever) unless they then write the whole
message in there.

So it looked odd, but as long as the explanation is somewhere, it
doesn't really matter.

            Linus

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL] Misc fs updates for 4.17-rc2
  2018-04-19  9:42 Jan Kara
@ 2018-04-19  9:48 ` Jan Kara
  0 siblings, 0 replies; 6+ messages in thread
From: Jan Kara @ 2018-04-19  9:48 UTC (permalink / raw)
  To: linux-fsdevel

Bah, I've messed up Linus' address in my address book. I'll resend. Sorry
for the noise.
								Honza

On Thu 19-04-18 11:42:17, Jan Kara wrote:
>   Hello Linus,
> 
>   could you please pull from
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_4.17-rc2
> 
> to get:
>  * isofs memory leak fix
>  * two fsnotify fixes of event mask handling
>  * udf fix of UTF-16 handling
>  * couple other smaller cleanups
> 
> Note that I've experimentally created this pull request with a signed tag.
> Please speak up if I did anything wrong.
> 
> Top of the tree is 44f06ba8297c. The full shortlog is:
> 
> Amir Goldstein (4):
>       fanotify: fix logic of events on child
>       fsnotify: fix ignore mask logic in send_to_group()
>       fsnotify: fix typo in a comment about mark->g_list
>       MAINTAINERS: add an entry for FSNOTIFY infrastructure
> 
> Chengguang Xu (1):
>       isofs: fix potential memory leak in mount option parsing
> 
> Jan Kara (1):
>       udf: Fix leak of UTF-16 surrogates into encoded strings
> 
> Jia-Ju Bai (1):
>       fs: quota: Replace GFP_ATOMIC with GFP_KERNEL in dquot_init
> 
> Kyle Spiers (1):
>       isofs compress: Remove VLA usage
> 
> Souptick Joarder (1):
>       fs: ext2: Adding new return type vm_fault_t
> 
> The diffstat is
> 
>  MAINTAINERS                      |  8 ++++++++
>  fs/ext2/file.c                   |  4 ++--
>  fs/isofs/compress.c              | 19 ++++++++++++++++---
>  fs/isofs/inode.c                 |  3 +++
>  fs/notify/fanotify/fanotify.c    | 34 +++++++++++++++-------------------
>  fs/notify/fsnotify.c             | 25 +++++++++++--------------
>  fs/quota/dquot.c                 |  2 +-
>  fs/udf/unicode.c                 |  6 ++++++
>  include/linux/fsnotify_backend.h |  2 +-
>  9 files changed, 63 insertions(+), 40 deletions(-)
> 
> 							Thanks
> 								Honza
> 
> -- 
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [GIT PULL] Misc fs updates for 4.17-rc2
@ 2018-04-19  9:42 Jan Kara
  2018-04-19  9:48 ` Jan Kara
  0 siblings, 1 reply; 6+ messages in thread
From: Jan Kara @ 2018-04-19  9:42 UTC (permalink / raw)
  To: torvalds; +Cc: linux-fsdevel

  Hello Linus,

  could you please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_4.17-rc2

to get:
 * isofs memory leak fix
 * two fsnotify fixes of event mask handling
 * udf fix of UTF-16 handling
 * couple other smaller cleanups

Note that I've experimentally created this pull request with a signed tag.
Please speak up if I did anything wrong.

Top of the tree is 44f06ba8297c. The full shortlog is:

Amir Goldstein (4):
      fanotify: fix logic of events on child
      fsnotify: fix ignore mask logic in send_to_group()
      fsnotify: fix typo in a comment about mark->g_list
      MAINTAINERS: add an entry for FSNOTIFY infrastructure

Chengguang Xu (1):
      isofs: fix potential memory leak in mount option parsing

Jan Kara (1):
      udf: Fix leak of UTF-16 surrogates into encoded strings

Jia-Ju Bai (1):
      fs: quota: Replace GFP_ATOMIC with GFP_KERNEL in dquot_init

Kyle Spiers (1):
      isofs compress: Remove VLA usage

Souptick Joarder (1):
      fs: ext2: Adding new return type vm_fault_t

The diffstat is

 MAINTAINERS                      |  8 ++++++++
 fs/ext2/file.c                   |  4 ++--
 fs/isofs/compress.c              | 19 ++++++++++++++++---
 fs/isofs/inode.c                 |  3 +++
 fs/notify/fanotify/fanotify.c    | 34 +++++++++++++++-------------------
 fs/notify/fsnotify.c             | 25 +++++++++++--------------
 fs/quota/dquot.c                 |  2 +-
 fs/udf/unicode.c                 |  6 ++++++
 include/linux/fsnotify_backend.h |  2 +-
 9 files changed, 63 insertions(+), 40 deletions(-)

							Thanks
								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-04-22  1:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19  9:49 [GIT PULL] Misc fs updates for 4.17-rc2 Jan Kara
2018-04-20 16:05 ` Linus Torvalds
2018-04-22  0:03   ` Jan Kara
2018-04-22  1:20     ` Linus Torvalds
  -- strict thread matches above, loose matches on Subject: below --
2018-04-19  9:42 Jan Kara
2018-04-19  9:48 ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).