From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82416C433DF for ; Mon, 1 Jun 2020 14:43:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 638E7207BC for ; Mon, 1 Jun 2020 14:43:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HyzfO4Rv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbgFAOnw (ORCPT ); Mon, 1 Jun 2020 10:43:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbgFAOnv (ORCPT ); Mon, 1 Jun 2020 10:43:51 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9870C05BD43; Mon, 1 Jun 2020 07:43:51 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id r2so9593489ila.4; Mon, 01 Jun 2020 07:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=kBgtMY0HgyinnysFtA5HI/dl8N2Cpzdt5VnQpFLuv20=; b=HyzfO4Rv/W7njyJ4z+Y6de9I/D2D1nVYhZWjc8bjvVRcF7bG4gxT7XAKdkPa6HQcgw CMRQQ8N/ruA+Kh2cWm5FDb3olThcjueX69OQcm3FMHTc76B43K/29EgJs1FTdZS+fSaq JRpLWoEWW8kMOakhztLcyYBr75hIB4CGRpwXHfaOOj/lW08BB+devbAlYCAIpoOBFUti /DxQgNC2ZKmU49ZD+GcZAo7dNL0eq1e+8v8ra1DAyG6/fC2AWPwKt2liF8LV/5Fslsak saAPmR98AyydGpUi1GyqE+O7T4A195tbAnnFXFacQpI11J3/EuReTeBzxgjVm32uN1aj 4/Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=kBgtMY0HgyinnysFtA5HI/dl8N2Cpzdt5VnQpFLuv20=; b=piUuXkvKS1/ZJEA3x8Utk2Rb8e2D5rj/39Q1uIP+bC6Y5zRFuF0Mf04UJ8PLqR1zY/ 6MUQK/ojmDumGFPhBodEOdVacWTkKkAhE2k7GkwQmikOL+/64lk4Sh37O071Z7XaOutJ Hu3jAHxF3rhXXdPnbP44snsrXpHm+W2wRg2/PTHxHl5B5aDaU6UBb1v7nt+tnVPOczd9 hDkXbLjgRu5p2Nfhn8ytOECYJC9lqA1pBuS8Sv6WIzMatYV0Wh476PmbDOQWKwBPc06W Ft/trIGiSTjKKaW0x70EED6DT/VJvAvblHgodzMHJR716V2qWl9vP+eUmBgV7nG7TaW6 ecTw== X-Gm-Message-State: AOAM533H8CeugncSMD2hP5eAIPprSWVCPM9CId906C2NWJiSQ6OdBLut MqLnSxbexXrYpcHJaEYX9CrA84rl7ru2KsblmUs= X-Google-Smtp-Source: ABdhPJzgWgWhNAUFdZLEKjzgI3ummCaXp/ue0+PP92MpoGkOgQcaz5WyPOK4t9DI30GIdzop/eEAKFGo64aVLp5bmEE= X-Received: by 2002:a92:7311:: with SMTP id o17mr22956523ilc.176.1591022631101; Mon, 01 Jun 2020 07:43:51 -0700 (PDT) MIME-Version: 1.0 References: <20200526195123.29053-1-axboe@kernel.dk> <230d3380-0269-d113-2c32-6e4fb94b79b8@kernel.dk> <455dd2c1-7346-2d43-4266-1367c368cee1@kernel.dk> In-Reply-To: <455dd2c1-7346-2d43-4266-1367c368cee1@kernel.dk> Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Mon, 1 Jun 2020 16:43:40 +0200 Message-ID: Subject: Re: [PATCHSET v5 0/12] Add support for async buffered reads To: Jens Axboe Cc: io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jun 1, 2020 at 4:35 PM Jens Axboe wrote: > > On 6/1/20 8:14 AM, Jens Axboe wrote: > > On 6/1/20 8:13 AM, Sedat Dilek wrote: > >> On Mon, Jun 1, 2020 at 4:04 PM Jens Axboe wrote: > >>> > >>> On 6/1/20 7:35 AM, Sedat Dilek wrote: > >>>> Hi Jens, > >>>> > >>>> with Linux v5.7 final I switched to linux-block.git/for-next and reverted... > >>>> > >>>> "block: read-ahead submission should imply no-wait as well" > >>>> > >>>> ...and see no boot-slowdowns. > >>> > >>> Can you try with these patches applied instead? Or pull my async-readahead > >>> branch from the same location. > >>> > >> > >> Yes, I can do that. > >> I pulled from linux-block.git#async-readahead and will report later. > >> > >> Any specific testing desired by you? > > > > Just do your boot timing test and see if it works, thanks. > > Actually, can you just re-test with the current async-buffered.6 branch? > I think the major surgery should wait for 5.9, we can do this a bit > easier without having to touch everything around us. > With linux-block.git#async-readahead: mycompiler -Wp,-MD,kernel/.sys.o.d -nostdinc -isystem /home/dileks/src/llvm-toolchain/install/lib/clang/10.0.1rc1/include -I./arch/x86/include -I./arch/x86/include/generated -I./include -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/kconfig.h -include ./include/linux/compiler_types.h -D__KERNEL__ -Qunused-arguments -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Wno-format-security -std=gnu89 -no-integrated-as -Werror=unknown-warning-option -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -m64 -mno-80387 -mstack-alignment=8 -mtune=generic -mno-red-zone -mcmodel=kernel -Wno-sign-compare -fno-asynchronous-unwind-tables -mretpoline-external-thunk -fno-delete-null-pointer-checks -Wno-address-of-packed-member -O2 -Wframe-larger-than=2048 -fstack-protector-strong -Wno-format-invalid-specifier -Wno-gnu -mno-global-merge -Wno-unused-const-variable -g -gz=zlib -pg -mfentry -DCC_USING_FENTRY -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wno-array-bounds -fno-strict-overflow -fno-merge-all-constants -fno-stack-check -Werror=date-time -Werror=incompatible-pointer-types -fmacro-prefix-map=./= -fcf-protection=none -Wno-initializer-overrides -Wno-format -Wno-sign-compare -Wno-format-zero-length -Wno-tautological-constant-out-of-range-compare -DKBUILD_MODFILE='"kernel/sys"' -DKBUILD_BASENAME='"sys"' -DKBUILD_MODNAME='"sys"' -c -o kernel/sys.o kernel/sys.c fs/9p/vfs_addr.c:112:4: error: use of undeclared identifier 'filp' filp->private_data); ^ 1 error generated. make[5]: *** [scripts/Makefile.build:267: fs/9p/vfs_addr.o] Error 1 make[4]: *** [scripts/Makefile.build:488: fs/9p] Error 2 make[3]: *** [Makefile:1735: fs] Error 2 make[3]: *** Waiting for unfinished jobs.... I guess block.git#async-buffered.6 needs the same revert of "block: read-ahead submission should imply no-wait as well". - Sedat -