From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01417C43461 for ; Wed, 16 Sep 2020 07:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C25C5206D4 for ; Wed, 16 Sep 2020 07:20:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DaVPipPx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbgIPHUn (ORCPT ); Wed, 16 Sep 2020 03:20:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbgIPHUm (ORCPT ); Wed, 16 Sep 2020 03:20:42 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FCD2C06174A; Wed, 16 Sep 2020 00:20:41 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id c13so7020492oiy.6; Wed, 16 Sep 2020 00:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=gNDte3S/hSJSnDsiYxZw5wA137HY+z+jEHhh9TJtTao=; b=DaVPipPxKVC/gpTyN4KR0Ctl7CZDyBwQcM9Rmnm/4InSTijDwaWf0Vco2v6n4CSJ6Q KKKbvNNex3CJlWu1d1MM+S8MIlQb9bd/i6kojeZyuFiA+VHPdDjOErfrfji8bfzK2uJZ xQ8/sy4/AAS4ZiyIzQfndXkDYKw5JKJR20AHIMywGpmMqw4xu3A7EwCG7xiLp+v0tFS3 +aMHcdl2BWHd2RyIGv57lUVxYPKN1BthAxxnhQ8HB1J0GzoDcVkIm1UJwbPuthcIAxx0 NfPbeCdHjmkoMiSPfcTTHE36lA19nRO7WSvV2Um4rvXqJH8iPVX3nTNmjxHZORHwamQw piDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=gNDte3S/hSJSnDsiYxZw5wA137HY+z+jEHhh9TJtTao=; b=nwN9lyWYshjFviQkLSCG36XA8NFoQFhv4uxXM29r99t+HksZ0dpCbqY7HG8GV6P/6F yooutSGetvtcnncXUgQu82nqgnMcNbklQTRr339bRKptjBEoMyNGwpuBzWrkV+yVt9FC A6Mw1w0TZd0l2+uinSKN/CsvTyJT7TVGd+aUJzNOCuKXm9Sfif2FEdU7BzRVj6V/d5fI Y83+UDIxZ92B7eNASEQKVVMZJ4wzHq3gXhuLnI3ShdUsOAbPmlHIXn+1ppW03wRqXCKS died0GrmYuwekXwIHlyOTv8rOxjSwsOebJdYPlQwy6M8DWv+XqO/hyfW9POYt8qH1GQz 51VA== X-Gm-Message-State: AOAM530HR8/sAJ0CYUHsEGl9Fvf5tNMyRBBmSEUw/S69K1Oc1Fc0koVO ad0Qdw1csAQfcsO97m4s74D5hmcu2a57dLFOaws= X-Google-Smtp-Source: ABdhPJzCc4qEMzE7TrxvsA6at1VRtP+FuaH49XHiuaQTXtAbmKP+V/811S14rpYhTOZtkDssbc3AifK31Af+8j3a4uM= X-Received: by 2002:aca:d409:: with SMTP id l9mr2094286oig.70.1600240840763; Wed, 16 Sep 2020 00:20:40 -0700 (PDT) MIME-Version: 1.0 References: <20200915160336.36107-1-colin.king@canonical.com> <65fbb23b-a533-aedb-75eb-69e1c53eaae9@redhat.com> In-Reply-To: <65fbb23b-a533-aedb-75eb-69e1c53eaae9@redhat.com> Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Wed, 16 Sep 2020 09:20:29 +0200 Message-ID: Subject: Re: [PATCH] vboxsf: fix comparison of signed char constant with unsigned char array elements To: Hans de Goede Cc: Colin King , Christoph Hellwig , Al Viro , linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Sep 16, 2020 at 8:16 AM Hans de Goede wrote: > > Hi, > > On 9/15/20 6:03 PM, Colin King wrote: > > From: Colin Ian King > > > > The comparison of signed char constants with unsigned char array > > elements leads to checks that are always false. Fix this by declaring > > the VBSF_MOUNT_SIGNATURE_BYTE* macros as octal unsigned int constants > > rather than as signed char constants. (Argueably the U is not necessarily > > required, but add it to be really clear of intent). > > > > Addresses-Coverity: ("Operands don't affect result") > > Fixes: 0fd169576648 ("fs: Add VirtualBox guest shared folder (vboxsf) support") > > Signed-off-by: Colin Ian King > > A fix for this has already been queued up: > > https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/log/?h=fixes > > Explicit nack for this one, since it will still apply, but combined > with the other fix, it will re-break things. > Hans, your patch is from 2020-08-25 and in a "fixes" Git branch of vfs - why wasn't it applied to Linux 5.9? - Sedat - > Regards, > > Hans > > > > > --- > > fs/vboxsf/super.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c > > index 25aade344192..986efcb29cc2 100644 > > --- a/fs/vboxsf/super.c > > +++ b/fs/vboxsf/super.c > > @@ -21,10 +21,10 @@ > > > > #define VBOXSF_SUPER_MAGIC 0x786f4256 /* 'VBox' little endian */ > > > > -#define VBSF_MOUNT_SIGNATURE_BYTE_0 ('\000') > > -#define VBSF_MOUNT_SIGNATURE_BYTE_1 ('\377') > > -#define VBSF_MOUNT_SIGNATURE_BYTE_2 ('\376') > > -#define VBSF_MOUNT_SIGNATURE_BYTE_3 ('\375') > > +#define VBSF_MOUNT_SIGNATURE_BYTE_0 0000U > > +#define VBSF_MOUNT_SIGNATURE_BYTE_1 0377U > > +#define VBSF_MOUNT_SIGNATURE_BYTE_2 0376U > > +#define VBSF_MOUNT_SIGNATURE_BYTE_3 0375U > > > > static int follow_symlinks; > > module_param(follow_symlinks, int, 0444); > > >