From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-4-arnd@arndb.de> In-Reply-To: <20180912150142.157913-4-arnd@arndb.de> From: "Yan, Zheng" Date: Thu, 13 Sep 2018 08:48:33 +0800 Message-ID: Subject: Re: [PATCH v2 04/17] ceph: fix compat_ioctl for ceph_dir_operations To: Arnd Bergmann Cc: Al Viro , Linux FS-devel Mailing List , stable@vger.kernel.org, Zheng Yan , Sage Weil , Ilya Dryomov , Chengguang Xu , ceph-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org List-ID: On Wed, Sep 12, 2018 at 11:10 PM Arnd Bergmann wrote: > > The ceph_ioctl function is used both for files and directories, but only > the files support doing that in 32-bit compat mode. > > For consistency, add the same compat handler to the dir operations > as well. > > Cc: stable@vger.kernel.org > Signed-off-by: Arnd Bergmann > --- > fs/ceph/dir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c > index 82928cea0209..da73f29d7faa 100644 > --- a/fs/ceph/dir.c > +++ b/fs/ceph/dir.c > @@ -1489,6 +1489,7 @@ const struct file_operations ceph_dir_fops = { > .open = ceph_open, > .release = ceph_release, > .unlocked_ioctl = ceph_ioctl, > + .compat_ioctl = ceph_ioctl, > .fsync = ceph_fsync, > .lock = ceph_lock, > .flock = ceph_flock, > -- > 2.18.0 > Reviewed-by: "Yan, Zheng"