From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Antonov Subject: Re: [PATCH 2.6 to 4.0] hfsplus: fix B-tree corruption after insertion at position 0 Date: Thu, 19 Mar 2015 00:05:32 +0100 Message-ID: References: <1426692505.88311.YahooMailBasic@web172305.mail.ir2.yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "linux-fsdevel@vger.kernel.org" , stable@vger.kernel.org, Joe Perches , Andrew Morton , Vyacheslav Dubeyko , Anton Altaparmakov , Al Viro , Christoph Hellwig To: Hin-Tak Leung Return-path: In-Reply-To: <1426692505.88311.YahooMailBasic@web172305.mail.ir2.yahoo.com> Sender: stable-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 18 March 2015 at 16:28, Hin-Tak Leung wrote: > Can you describe a bit more about the symptom please? Some files and directories are gone. Depending on which of the catalog file's nodes reside in the unavailable extents, it may vary from "some data can be salvaged" to "screw it, reformat the volume". > I am > wondering whether it is related to an issue I have had which is quite reproducible: > If I merely run "du" repeatedly on a large directory on an HFS+ formatted > drive, on a somewhat resource-tight system (having firefox running with lots > windows seems to make it happens sooner, and it was on a system with only 2GB memory). Then what? > I was able to do with with two separate drives, one had user data > which I have edited by hand somewhat, > but the other was was a qcow2 image of an essentially newly installed and clean > Mac OS X system disk through qemu/kvm. > Also, the logic of hfs_brec_insert() in the plain hfs (without +) driver in > fs/hfs/brec.c is essentially the same, so I believe there is the need of another > similiar patch for that also. Can you provide that also? No. The original HFS is very old. The only reasonable purpose of its implementation in Linux IMO is to read data from old disks. Read-only mode that is.