linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Vyukov <dvyukov@google.com>
To: Jeff Layton <jlayton@poochiereds.net>,
	Bruce Fields <bfields@fieldses.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Cc: syzkaller <syzkaller@googlegroups.com>
Subject: fs: WARNING in locks_unlink_lock_ctx (not holding proper lock)
Date: Fri, 7 Oct 2016 22:03:15 +0200	[thread overview]
Message-ID: <CACT4Y+Yjb4hwtcP30uP0j3-3TGG21GPq7JO9ziucxq9VX8sugw@mail.gmail.com> (raw)

Hello,

I am hitting lots of the following warnings while running syzkaller
fuzzer. Seems that path does not hold proper lock.

WARNING: CPU: 1 PID: 12090 at fs/locks.c:610 locks_unlink_lock_ctx+0x2c7/0x370
CPU: 1 PID: 12090 Comm: syz-executor Not tainted 4.8.0+ #28
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
 ffff880038ba7728 ffffffff82d2b849 ffffffff00000016 fffffbfff10971e8
 ffffffff86e8c000 ffff880038ba7800 ffffffff86f42400 dffffc0000000000
 0000000000000009 ffff880038ba77f0 ffffffff816a229a 0000000041b58ab3
Call Trace:
 [<     inline     >] __dump_stack lib/dump_stack.c:15
 [<ffffffff82d2b849>] dump_stack+0x12e/0x185 lib/dump_stack.c:51
 [<ffffffff816a229a>] panic+0x1e9/0x3f4 kernel/panic.c:153
 [<ffffffff81354fb9>] __warn+0x1c9/0x1e0 kernel/panic.c:509
 [<ffffffff813551a1>] warn_slowpath_null+0x31/0x40 kernel/panic.c:552
 [<     inline     >] locks_delete_global_locks fs/locks.c:610
 [<ffffffff8193b247>] locks_unlink_lock_ctx+0x2c7/0x370 fs/locks.c:739
 [<ffffffff8193b30f>] locks_delete_lock_ctx+0x1f/0x80 fs/locks.c:751
 [<ffffffff8193d329>] lease_modify+0x229/0x2e0 fs/locks.c:1370
 [<     inline     >] locks_remove_lease fs/locks.c:2528
 [<ffffffff81947408>] locks_remove_file+0x2d8/0x380 fs/locks.c:2551
 [<ffffffff8182eea6>] __fput+0x1a6/0x780 fs/file_table.c:200
 [<ffffffff8182f50a>] ____fput+0x1a/0x20 fs/file_table.c:244
 [<ffffffff813bae68>] task_work_run+0xf8/0x170 kernel/task_work.c:116
 [<     inline     >] exit_task_work include/linux/task_work.h:21
 [<ffffffff81364de4>] do_exit+0x864/0x2ad0 kernel/exit.c:828
 [<ffffffff813671cd>] do_group_exit+0x10d/0x330 kernel/exit.c:931
 [<ffffffff8138a57f>] get_signal+0x62f/0x15e0 kernel/signal.c:2307
 [<ffffffff811cf344>] do_signal+0x84/0x18f0 arch/x86/kernel/signal.c:807
 [<ffffffff8100629b>] exit_to_usermode_loop+0x13b/0x200
arch/x86/entry/common.c:156
 [<     inline     >] prepare_exit_to_usermode arch/x86/entry/common.c:190
 [<     inline     >] syscall_return_slowpath arch/x86/entry/common.c:259
 [<ffffffff81008a4f>] do_syscall_64+0x49f/0x620 arch/x86/entry/common.c:285

On commit a6930aaee06755d1bdcfd943fbf614e4d92bb0c7 (Oct 5).

             reply	other threads:[~2016-10-07 20:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 20:03 Dmitry Vyukov [this message]
2016-10-07 23:26 ` fs: WARNING in locks_unlink_lock_ctx (not holding proper lock) Jeff Layton
2016-10-08  8:12   ` Peter Zijlstra
2016-10-08 10:47     ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACT4Y+Yjb4hwtcP30uP0j3-3TGG21GPq7JO9ziucxq9VX8sugw@mail.gmail.com \
    --to=dvyukov@google.com \
    --cc=bfields@fieldses.org \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller@googlegroups.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).