From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33B0C4CECE for ; Wed, 18 Sep 2019 20:22:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8852121925 for ; Wed, 18 Sep 2019 20:22:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sfvASRer" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730346AbfIRUWP (ORCPT ); Wed, 18 Sep 2019 16:22:15 -0400 Received: from mail-ua1-f68.google.com ([209.85.222.68]:42168 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728555AbfIRUWP (ORCPT ); Wed, 18 Sep 2019 16:22:15 -0400 Received: by mail-ua1-f68.google.com with SMTP id r19so306257uap.9; Wed, 18 Sep 2019 13:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lmhPAPvtiDqgJteyBaaRaA2HGyODpvnBTqjiHuYvfW8=; b=sfvASRerbcXbub55XOZDQa1Q6Pr15lLFNTI9N+KlluVI9AP7tro68HSKNCMWhGx5Js TvO7LdhJ5wIshdJ5o78Y2Pu/t7lIJlZLkBSLykowc/XPvCKnIO9gNLOvRJ+VMk1XoTaq gKE1JKCcDgwx3+i6oQva81SPRosIY1TJ/HS3mH59GFYcixNcq7jzcUdh0WbgY/wjRTvr 4ovllQQb9hO+6l0bS7tjwYhMIZM6vtnkFEmKxjO4eKS6CL3x1HmSbuKRHd+I1xfPE092 Q6pXD4tVJsf9j/Ifvia/iR253v0+OBvdM1/4Xndlrif7ZzmiQb894g4HLFM6A0y6+Ovk yF+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lmhPAPvtiDqgJteyBaaRaA2HGyODpvnBTqjiHuYvfW8=; b=ePGuSq1dBHvsYelOF7GSxaby5+udgf9pOskRiytvJyCtDS6LvbwDW9N/1AhQl1PM21 qDUDe2ARuSOkuT3PvYPiyoKUXGeNWBGwKVfWFPK3wEY+3n0var/T+PrSdciPHpFEq2AS 2Sj3h+VjoGHNdOduGr64zbzlTR9MffxsqUW2EZOMYptajeU5svlPnWIVCjI1ronLwCC7 FbLvP7iZ6vHuk5+AhyJIuBWqjOfkJkat8bTolWSNOXYda2pkcyAp3IklGaIoa0+HQ+0R 8GmBW1u1oNpPnrHXlOau/5VpbfWjI1rKJhT+YwnT9ddIwzuBSWc1RfTmzRuLAoBT1n4z 78NQ== X-Gm-Message-State: APjAAAVNtTM7Bb9ptM+xL8znoUPvJvgvbgstvSnhbXAQPu0urAuGBcsK Rwc5y3N4sjgKiTea/7yRyqapKBcm1OitSbkvJfQ= X-Google-Smtp-Source: APXvYqy3pJnGFFiPZpSaVj6NyQ+uACbzioEkEoMSk5DLMmTqob6g6Zbdj69w8/4DOKa3t7RcjcDL3Y04gLE7+XWUqwg= X-Received: by 2002:ab0:7816:: with SMTP id x22mr3609892uaq.97.1568838133906; Wed, 18 Sep 2019 13:22:13 -0700 (PDT) MIME-Version: 1.0 References: <20190828160817.6250-1-gregkh@linuxfoundation.org> <20190918195920.25210-1-qkrwngud825@gmail.com> <20190918201318.GB2025570@kroah.com> In-Reply-To: <20190918201318.GB2025570@kroah.com> From: Ju Hyung Park Date: Thu, 19 Sep 2019 05:22:03 +0900 Message-ID: Subject: Re: [PATCH] staging: exfat: rebase to sdFAT v2.2.0 To: Greg KH , Namjae Jeon , sj1557.seo@samsung.com Cc: alexander.levin@microsoft.com, Sergey Senozhatsky , sergey.senozhatsky@gmail.com, Valdis Kletnieks , Dan Carpenter , devel@driverdev.osuosl.org, linkinjeon@gmail.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Greg, On Thu, Sep 19, 2019 at 5:12 AM Greg KH wrote: > That's a lot of rewriting :( > > How about at least keeping the file names the same to make it easier to > see what happened here? > > Then send a follow-on patch that just does the rename? That's still not quite useful tbh, lemme bring the diff stat I wrote in previous email just in case you missed it: Kconfig | 79 +- Makefile | 46 +- api.c | 423 ---- api.h | 310 --- blkdev.c | 409 +--- cache.c | 1142 ++++----- config.h | 49 - core.c | 5583 ++++++++++++++++++++++++-------------------- core.h | 196 -- core_exfat.c | 1553 ------------ exfat.h | 1309 +++++++---- exfat_fs.h | 417 ---- extent.c | 351 --- fatent.c | 182 -- misc.c | 401 ---- nls.c | 490 ++-- super.c | 5103 +++++++++++++++++++++------------------- upcase.c | 740 ++++++ upcase.h | 407 ---- version.h | 29 - xattr.c | 136 -- 21 files changed, 8186 insertions(+), 11169 deletions(-) Kconfig | 79 +- Makefile | 46 +- blkdev.c | 409 +--- cache.c | 1142 +++++----- core.c | 5583 ++++++++++++++++++++++++++---------------------- exfat.h | 1309 ++++++++---- nls.c | 490 ++--- super.c | 5103 ++++++++++++++++++++++--------------------- 8 files changed, 7446 insertions(+), 6715 deletions(-) These diff stats were taken by removing "exfat_" prefix from the current staging drivers. But if that's still what you want, I'll do it. btw, removing "exfat_" prefix from the current one makes more sense imo. If we add "exfat_" prefix to the new one, we get weird file names like "exfat_core_exfat.c". > And by taking something like this, are you agreeing that Samsung will > help out with the development of this code to clean it up and get it > into "real" mergable shape? Well, I think you got me confused with Namjae. (Yeah Korean names are confusing I know :) ) Namjae (or anyone else from Samsung) should answer that, not me. I just prepared a patch as we were getting nowhere like you mentioned :) > Also, I can't take this patch for this simple reason alone: > Don't delete SPDX lines :) Sorry. I'll add that back for v2. On Thu, Sep 19, 2019 at 5:13 AM Greg KH wrote: > > On Thu, Sep 19, 2019 at 04:59:20AM +0900, Park Ju Hyung wrote: > > --- a/drivers/staging/exfat/exfat.h > > +++ b/drivers/staging/exfat/exfat.h > > @@ -1,4 +1,4 @@ > > -/* SPDX-License-Identifier: GPL-2.0 */ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > You just changed the license of this file. Are you SURE about that? The sdFAT code release explicitly states "either version 2 of the License, or (at your option) any later version", so I thought that makes sense: https://github.com/arter97/exfat-linux/commit/d5393c4cbe0e5b50231aacd33d9b5b0ddf46a005 Please correct me if I'm wrong. Thanks.