From: Navid Emamdoost <navid.emamdoost@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-fsdevel@vger.kernel.org, Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
David Sterba <dsterba@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Al Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] fs: affs: fix a memory leak in affs_remount
Date: Tue, 1 Oct 2019 12:34:59 -0500 [thread overview]
Message-ID: <CAEkB2ERMqs=xbt4H-1ro0zAQryoQUH=N5iJop-CKbSOo_mTk3w@mail.gmail.com> (raw)
In-Reply-To: <44ad775e-3b6f-4cbc-ba6f-455ff7191c58@web.de>
Hi Markus, thanks for your suggestions for improving the quality of
the patch. At the moment I prefer first get a confirmation from
contributors about the leak and then work on any possible improvements
for the patch.
Thanks,
Navid.
On Tue, Oct 1, 2019 at 3:31 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > The allocated memory for new_opts is only released if pare_options fail.
>
> Can the following wording be nicer?
>
> The allocated memory for the buffer “new_opts” will be released
> only if a call of the function “parse_options” failed.
>
>
> > The release for new_opts is added.
>
> * How do you think about the change possibility to delete questionable
> source code here?
>
> * Would you like to complete the data processing for corresponding options
> any more?
>
>
> > -- fix a type in title, …
>
> Please avoid typos also in your version comments.
>
>
> > ---
>
> I suggest to replace this second delimiter by a blank line.
>
> Regards,
> Markus
--
Navid.
next prev parent reply other threads:[~2019-10-01 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 3:21 [PATCH] fs: affs: fix a memroy leak in affs_remount Navid Emamdoost
2019-09-30 6:02 ` [PATCH] fs: affs: fix a memory " Markus Elfring
2019-09-30 21:01 ` [PATCH v2] " Navid Emamdoost
2019-10-01 8:30 ` Markus Elfring
2019-10-01 17:34 ` Navid Emamdoost [this message]
2019-10-02 5:09 ` [v2] " Markus Elfring
2019-10-02 5:09 ` Markus Elfring
2019-10-02 9:22 ` [PATCH v2] " David Sterba
2019-10-02 16:59 ` Navid Emamdoost
2019-10-02 21:52 ` [PATCH v3] " Navid Emamdoost
2019-10-30 11:44 ` David Sterba
2019-09-30 21:01 ` [PATCH] " Navid Emamdoost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEkB2ERMqs=xbt4H-1ro0zAQryoQUH=N5iJop-CKbSOo_mTk3w@mail.gmail.com' \
--to=navid.emamdoost@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=deepa.kernel@gmail.com \
--cc=dsterba@suse.com \
--cc=emamd001@umn.edu \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=jlayton@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smccaman@umn.edu \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).