From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD65C48BD5 for ; Tue, 25 Jun 2019 22:41:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2FAC20645 for ; Tue, 25 Jun 2019 22:41:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WD+/u8ZZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726376AbfFYWlq (ORCPT ); Tue, 25 Jun 2019 18:41:46 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:43959 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbfFYWlm (ORCPT ); Tue, 25 Jun 2019 18:41:42 -0400 Received: by mail-pl1-f195.google.com with SMTP id cl9so215804plb.10 for ; Tue, 25 Jun 2019 15:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lZHzVm2a7c7UL6Qa6OAs8GEjMqpVhQyW6fXdYgD38tg=; b=WD+/u8ZZNxnSkIT8uW5k3AjwCTR/8Rul0p24/yrVxO5s2EytGRajAgq/3lh2tgJCoM vOOrZEi6S9bPRtEV0sQ50TTo+svFRl+vB4anHgBOhwDOhj/sKAavGpLkR9ZW/+8ZlccU UdMs6Z8Ga9hdSotzdUPEFVwI6IZ9G3K5novTFltGAZnxEjjToD6xbWblx/HifwrkfVwk hJ5e4XwNevJKRgf4O7t302ViaxWNKj1aXsprvBLH4sig979oKbLTzjrYSQpuQWmWeZ6j dP5tx4S2eAu98MeIeDuog/S9j0E1psO/k6tGCkOvr99nidb5QryIDQhLc5bRofLMt0FA FrzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lZHzVm2a7c7UL6Qa6OAs8GEjMqpVhQyW6fXdYgD38tg=; b=OZRldw1tc/vV57/nlhG4jwEBpv/dhtmQgx/E5h1at7oMJXtyhH+WrVmww3VfdKj0Lu mrWDoVrT6PdUAB7IjIvexFySVAc9dkOFbUV3YTiEEjPI05qAZ4GA5qqSeIwZGtYMJj8G x1biUuz5Igiq1QjLzN+CcUurbrkoBNwejMEzhKpwwuh9+wUMxpOozdPjDtkUn3DKPjyB NfSgZlfCY6hc/FyHI2K/uLiz+FWhmPZYBMoWbbggYfU0r9QZGsxVM8b8UGrZlSoEBVtt BXwZxTXAIIfxYYHx1CElE9EMYW3i7xQ0D9opHrcr0fthvrgedmUK0zM/Bgyhv8YAbi4H G/ag== X-Gm-Message-State: APjAAAW61EElsH121OSsDvjCvm8VCT8Cz5RfrDlYtQAhrY9g3Ju2y5tc +TUUwq6pYwz6M7recvfTDeKZ+UNcVYFTEBZ63QnCPA== X-Google-Smtp-Source: APXvYqy+cT1ZyNb5dbS97li+J3swfp3mEaFo87MllhiLnOnKUdNsGvjik4FBRsZ5dS4sFwdr9UIg/0trivOUWFuNZts= X-Received: by 2002:a17:902:1004:: with SMTP id b4mr1155831pla.325.1561502500720; Tue, 25 Jun 2019 15:41:40 -0700 (PDT) MIME-Version: 1.0 References: <20190617082613.109131-1-brendanhiggins@google.com> <20190617082613.109131-7-brendanhiggins@google.com> <20190625221318.GO19023@42.do-not-panic.com> In-Reply-To: <20190625221318.GO19023@42.do-not-panic.com> From: Brendan Higgins Date: Tue, 25 Jun 2019 15:41:29 -0700 Message-ID: Subject: Re: [PATCH v5 06/18] kbuild: enable building KUnit To: Luis Chamberlain Cc: Frank Rowand , Greg KH , Josh Poimboeuf , Kees Cook , Kieran Bingham , Peter Zijlstra , Rob Herring , Stephen Boyd , shuah , "Theodore Ts'o" , Masahiro Yamada , devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel@vger.kernel.org, linux-kbuild , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jun 25, 2019 at 3:13 PM Luis Chamberlain wrote: > > On Mon, Jun 17, 2019 at 01:26:01AM -0700, Brendan Higgins wrote: > > diff --git a/Kconfig b/Kconfig > > index 48a80beab6853..10428501edb78 100644 > > --- a/Kconfig > > +++ b/Kconfig > > @@ -30,3 +30,5 @@ source "crypto/Kconfig" > > source "lib/Kconfig" > > > > source "lib/Kconfig.debug" > > + > > +source "kunit/Kconfig" > > This patch would break compilation as kunit/Kconfig is not introduced. This > would would also break bisectability on this commit. This change should > either be folded in to the next patch, or just be a separate patch after > the next one. Maybe my brain isn't working right now, but I am pretty darn sure that I introduce kunit/Kconfig in the very first patch of this series. Quoting from the change summary from the first commit: > include/kunit/test.h | 161 +++++++++++++++++++++++++++++++++ > kunit/Kconfig | 17 ++++ > kunit/Makefile | 1 + > kunit/test.c | 210 +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 389 insertions(+) > create mode 100644 include/kunit/test.h > create mode 100644 kunit/Kconfig I am not crazy, right? > create mode 100644 kunit/Makefile > create mode 100644 kunit/test.c