From: Brendan Higgins <brendanhiggins@google.com>
To: Frank Rowand <frowand.list@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Kees Cook <keescook@google.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Rob Herring <robh@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
shuah <shuah@kernel.org>, "Theodore Ts'o" <tytso@mit.edu>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: devicetree <devicetree@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
kunit-dev@googlegroups.com,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
linux-kbuild <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-um@lists.infradead.org,
Sasha Levin <Alexander.Levin@microsoft.com>,
"Bird, Timothy" <Tim.Bird@sony.com>,
Amir Goldstein <amir73il@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Daniel Vetter <daniel@ffwll.ch>, Jeff Dike <jdike@addtoit.com>,
Joel Stanley <joel@jms.id.au>,
Julia Lawall <julia.lawall@lip6.fr>,
Kevin Hilman <khilman@baylibre.com>,
Knut Omang <knut.omang@oracle.com>,
Logan Gunthorpe <logang@deltatee.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Petr Mladek <pmladek@suse.com>,
Randy Dunlap <rdunlap@infradead.org>,
Richard Weinberger <richard@nod.at>,
David Rientjes <rientjes@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
wfg@linux.intel.com, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework
Date: Wed, 14 Aug 2019 03:03:47 -0700 [thread overview]
Message-ID: <CAFd5g45NdQEcP0JQpZc3HYYgNZfsBsHL+ByXRK+OupWObwMuqg@mail.gmail.com> (raw)
In-Reply-To: <20190814055108.214253-1-brendanhiggins@google.com>
On Tue, Aug 13, 2019 at 10:52 PM Brendan Higgins
<brendanhiggins@google.com> wrote:
>
> ## TL;DR
>
> This revision addresses comments from Stephen and Bjorn Helgaas. Most
> changes are pretty minor stuff that doesn't affect the API in anyway.
> One significant change, however, is that I added support for freeing
> kunit_resource managed resources before the test case is finished via
> kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke
> KUnit on certain configurations (like the default one for x86, whoops).
>
> Based on Stephen's feedback on the previous change, I think we are
> pretty close. I am not expecting any significant changes from here on
> out.
Stephen, it looks like you have just replied with "Reviewed-bys" on
all the remaining emails that you looked at. Is there anything else
that we are missing? Or is this ready for Shuah to apply?
[...]
Cheers!
next prev parent reply other threads:[~2019-08-14 10:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 5:50 [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 01/18] kunit: test: add KUnit test runner core Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 02/18] kunit: test: add test resource management API Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 03/18] kunit: test: add string_stream a std::stream like string builder Brendan Higgins
2019-08-14 7:17 ` Stephen Boyd
2019-08-14 5:50 ` [PATCH v13 04/18] kunit: test: add assertion printing library Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 05/18] kunit: test: add the concept of expectations Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 06/18] kbuild: enable building KUnit Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 07/18] kunit: test: add initial tests Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 08/18] objtool: add kunit_try_catch_throw to the noreturn list Brendan Higgins
2019-08-14 5:50 ` [PATCH v13 09/18] kunit: test: add support for test abort Brendan Higgins
2019-08-14 7:16 ` Stephen Boyd
2019-08-14 5:51 ` [PATCH v13 10/18] kunit: test: add tests for kunit " Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 11/18] kunit: test: add the concept of assertions Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 12/18] kunit: test: add tests for KUnit managed resources Brendan Higgins
2019-08-14 7:18 ` Stephen Boyd
2019-08-14 5:51 ` [PATCH v13 13/18] kunit: tool: add Python wrappers for running KUnit tests Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 14/18] kunit: defconfig: add defconfigs for building " Brendan Higgins
2019-08-14 7:18 ` Stephen Boyd
2019-08-14 5:51 ` [PATCH v13 15/18] Documentation: kunit: add documentation for KUnit Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 16/18] MAINTAINERS: add entry for KUnit the unit testing framework Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Brendan Higgins
2019-08-14 5:51 ` [PATCH v13 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section Brendan Higgins
2019-08-14 10:03 ` Brendan Higgins [this message]
2019-08-14 17:23 ` [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Stephen Boyd
2019-08-20 17:24 ` shuah
2019-08-20 18:24 ` Brendan Higgins
2019-08-20 19:08 ` shuah
2019-08-20 21:26 ` Brendan Higgins
2019-08-20 23:23 ` Brendan Higgins
2019-08-21 0:15 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFd5g45NdQEcP0JQpZc3HYYgNZfsBsHL+ByXRK+OupWObwMuqg@mail.gmail.com \
--to=brendanhiggins@google.com \
--cc=Alexander.Levin@microsoft.com \
--cc=Tim.Bird@sony.com \
--cc=amir73il@gmail.com \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=joel@jms.id.au \
--cc=jpoimboe@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@google.com \
--cc=khilman@baylibre.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=knut.omang@oracle.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-um@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=mcgrof@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=rientjes@google.com \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=tytso@mit.edu \
--cc=wfg@linux.intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).