From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F45FC48BC2 for ; Wed, 23 Jun 2021 19:04:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E30761289 for ; Wed, 23 Jun 2021 19:04:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbhFWTGf (ORCPT ); Wed, 23 Jun 2021 15:06:35 -0400 Received: from linux.microsoft.com ([13.77.154.182]:37004 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbhFWTGe (ORCPT ); Wed, 23 Jun 2021 15:06:34 -0400 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by linux.microsoft.com (Postfix) with ESMTPSA id D3E8E20B83F5; Wed, 23 Jun 2021 12:04:16 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D3E8E20B83F5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1624475056; bh=iqMYBX8gNJqygF5F9g1MwbXLNoGunuU4jx9xCfqhSX0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=f70CcZvM/X7fzhoqUcMyo7Roi1vV3/vgWgNEKgWo5+lETiBHk3BERcmLN8jUe2Fps xMnNIdfI2QILIpkVmd2wWBudvWqVfJqhtoyRN2+Bmx0ysTjetGEQhorSEYYxJbz2Pt eznGGnjlr9NrhSpO9MCcHGvA/dHVsuPim7IsWm10= Received: by mail-pl1-f181.google.com with SMTP id v12so1653329plo.10; Wed, 23 Jun 2021 12:04:16 -0700 (PDT) X-Gm-Message-State: AOAM530ySDJmbQ2tUKCfRsBa5kFZIeJYXPbSL1K3wzxx+uwMuGcx3rG5 UutYrVMrqGAhpF60I6XwGgCqstcn/AMzqP6lE1s= X-Google-Smtp-Source: ABdhPJz7IFiXQyTVrVydscmqOnQmgiIcflbsxtRx4Tot0Tc0Fti2nXFcTJ0ZQbo4ObI6ragERNkM1cn9NgR3bmygy2Q= X-Received: by 2002:a17:902:e9d5:b029:124:926:7971 with SMTP id 21-20020a170902e9d5b029012409267971mr816793plk.19.1624475056368; Wed, 23 Jun 2021 12:04:16 -0700 (PDT) MIME-Version: 1.0 References: <20210623105858.6978-1-mcroce@linux.microsoft.com> <20210623105858.6978-4-mcroce@linux.microsoft.com> In-Reply-To: From: Matteo Croce Date: Wed, 23 Jun 2021 21:03:40 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/6] block: refactor sysfs code To: Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Linux Kernel Mailing List , Lennart Poettering , Luca Boccassi , Alexander Viro , Damien Le Moal , Tejun Heo , "Javier Gonz??lez" , Niklas Cassel , Johannes Thumshirn , Hannes Reinecke , Matthew Wilcox , JeffleXu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jun 23, 2021 at 1:53 PM Christoph Hellwig wrote: > > > -static void disk_add_events(struct gendisk *disk) > > +static void disk_add_sysfs(struct gendisk *disk) > > { > > /* FIXME: error handling */ > > - if (sysfs_create_files(&disk_to_dev(disk)->kobj, disk_events_attrs) < 0) > > + if (sysfs_create_files(&disk_to_dev(disk)->kobj, disk_sysfs_attrs) < 0) > > pr_warn("%s: failed to create sysfs files for events\n", > > disk->disk_name); > > +} > > Actually, what we need here is a way how we can setup the ->groups > field of the device to include all attribute groups instead of having > to call sysfs_create_files at all. I don't get this one. You mean in general or in this series? -- per aspera ad upstream