From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:38166 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbeEaEbG (ORCPT ); Thu, 31 May 2018 00:31:06 -0400 Received: by mail-lf0-f68.google.com with SMTP id z142-v6so7633607lff.5 for ; Wed, 30 May 2018 21:31:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20180414195939.GA20132@jordon-HP-15-Notebook-PC> From: Souptick Joarder Date: Thu, 31 May 2018 10:01:04 +0530 Message-ID: Subject: Re: [PATCH] fs: proc: Adding new typedef vm_fault_t To: Al Viro Cc: linux-fsdevel , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, May 14, 2018 at 11:46 PM, Souptick Joarder wrote: > On Sun, Apr 15, 2018 at 1:29 AM, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler. >> >> Signed-off-by: Souptick Joarder >> Reviewed-by: Matthew Wilcox >> --- >> fs/proc/vmcore.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c >> index a45f0af..7243e94 100644 >> --- a/fs/proc/vmcore.c >> +++ b/fs/proc/vmcore.c >> @@ -265,7 +265,7 @@ static ssize_t read_vmcore(struct file *file, char __user *buffer, >> * On s390 the fault handler is used for memory regions that can't be mapped >> * directly with remap_pfn_range(). >> */ >> -static int mmap_vmcore_fault(struct vm_fault *vmf) >> +static vm_fault_t mmap_vmcore_fault(struct vm_fault *vmf) >> { >> #ifdef CONFIG_S390 >> struct address_space *mapping = vmf->vma->vm_file->f_mapping; >> -- >> 1.9.1 >> > > Any comment on this patch ? We would like to get this patch in > queue for 4.18. If no comment, we would like to get this patch in queue for 4.18.