From: Ross Zwisler <zwisler@chromium.org>
To: Raul Rangel <rrangel@google.com>, David Howells <dhowells@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Mattias Nissler <mnissler@chromium.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Benjamin Gordon <bmgordon@google.com>,
Micah Morton <mortonm@google.com>,
Dmitry Torokhov <dtor@google.com>, Jan Kara <jack@suse.cz>,
Aleksa Sarai <cyphar@cyphar.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v5] Add a "nosymfollow" mount option.
Date: Tue, 4 Feb 2020 16:49:48 -0700 [thread overview]
Message-ID: <CAGRrVHyzX4zOpO2nniv42BHOCbyCdPV9U7GE3FVhjzeFonb0bQ@mail.gmail.com> (raw)
In-Reply-To: <CAGRrVHwQimihNNVs434jNGF3BL5_Qov+1eYqBYKPCecQ0yjxpw@mail.gmail.com>
On Tue, Feb 4, 2020 at 3:11 PM Ross Zwisler <zwisler@chromium.org> wrote:
> On Tue, Feb 4, 2020 at 2:53 PM Raul Rangel <rrangel@google.com> wrote:
> > > --- a/include/uapi/linux/mount.h
> > > +++ b/include/uapi/linux/mount.h
> > > @@ -34,6 +34,7 @@
> > > #define MS_I_VERSION (1<<23) /* Update inode I_version field */
> > > #define MS_STRICTATIME (1<<24) /* Always perform atime updates */
> > > #define MS_LAZYTIME (1<<25) /* Update the on-disk [acm]times lazily */
> > > +#define MS_NOSYMFOLLOW (1<<26) /* Do not follow symlinks */
> > Doesn't this conflict with MS_SUBMOUNT below?
> > >
> > > /* These sb flags are internal to the kernel */
> > > #define MS_SUBMOUNT (1<<26)
>
> Yep. Thanks for the catch, v6 on it's way.
It actually looks like most of the flags which are internal to the
kernel are actually unused (MS_SUBMOUNT, MS_NOREMOTELOCK, MS_NOSEC,
MS_BORN and MS_ACTIVE). Several are unused completely, and the rest
are just part of the AA_MS_IGNORE_MASK which masks them off in the
apparmor LSM, but I'm pretty sure they couldn't have been set anyway.
I'll just take over (1<<26) for MS_NOSYMFOLLOW, and remove the rest in
a second patch.
If someone thinks these flags are actually used by something and I'm
just missing it, please let me know.
next prev parent reply other threads:[~2020-02-04 23:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 21:50 [PATCH v5] Add a "nosymfollow" mount option Ross Zwisler
2020-02-04 21:52 ` Raul Rangel
2020-02-04 22:11 ` Ross Zwisler
2020-02-04 23:49 ` Ross Zwisler [this message]
2020-02-05 3:21 ` Matthew Wilcox
2020-02-05 3:45 ` Aleksa Sarai
2020-02-06 19:10 ` Ross Zwisler
2020-02-13 15:46 ` Ross Zwisler
2020-02-21 1:21 ` Aleksa Sarai
2020-02-21 18:21 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGRrVHyzX4zOpO2nniv42BHOCbyCdPV9U7GE3FVhjzeFonb0bQ@mail.gmail.com \
--to=zwisler@chromium.org \
--cc=bmgordon@google.com \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=dtor@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnissler@chromium.org \
--cc=mortonm@google.com \
--cc=rrangel@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).