From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4C0C10F11 for ; Wed, 10 Apr 2019 23:00:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 426DF2083E for ; Wed, 10 Apr 2019 23:00:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fiRbnxmF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726732AbfDJXAL (ORCPT ); Wed, 10 Apr 2019 19:00:11 -0400 Received: from mail-vk1-f193.google.com ([209.85.221.193]:44607 "EHLO mail-vk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726023AbfDJXAK (ORCPT ); Wed, 10 Apr 2019 19:00:10 -0400 Received: by mail-vk1-f193.google.com with SMTP id q189so947638vkq.11 for ; Wed, 10 Apr 2019 16:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V/mnOiistNskyNyWzFJ110XGM52BtYbw7mnMXoOf9ss=; b=fiRbnxmF4EUFn5589zrjF8mmaXq5M7XTmHAYNR8VIlPO5hdvGO4J901KeKS8ehuB9u sSFMnyWDz1LaxmPxuFgwI1ajPAV+oyVGmAtgV4/ByPP8Okd65v1lsbRBlpMEwORppXwt fYH3kBjdxPwDR2nSy4EjhX+IqBMADhWhyBnps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V/mnOiistNskyNyWzFJ110XGM52BtYbw7mnMXoOf9ss=; b=L9uotMwZquKoC9H+Eh+XHa20zG2Z638Ued2B5spNaKVmdd8cSj2Rj7+LceLNd8IgkP WwDC6UMgyNGqN4zxnOG5hKQ+LI44TZ+tsguWkmsJpJG5B2tuK4be3ZS1b0pgGlFeuCYN r32FcRXrMbkdZkzKNsXuEf9oAeJf0EnKKkgm51txO56fUQfL/7MVMS54JNIT+2T9ncEZ UPD/nKns0pdveE0qBR7brGaQpk1CxsQ/lfhLKTrwkaIFzvfgD0BpP2EuVTdFASkxOTdk AF96mEM53pF0ABki45Tt8sAhMUOagSArKBzBfk3Mlpsqfu8fb6bl6DqzWs/nx0tgbWTm p/NQ== X-Gm-Message-State: APjAAAVlbZXuTyoNTDzQJfI7fyk23Bvm9Ut2F/rGQt5qahyqZW+Qbayr G17MBIYePrR2ufw7WHcgNO6UC0g0n1k= X-Google-Smtp-Source: APXvYqyeOD4p5OgYkoQ+iAunvT0L6THYD55HyfMie5YEgp9tsAkXvkocHjBFYz1xonaTzFCBvdhekw== X-Received: by 2002:a1f:4ec7:: with SMTP id c190mr25100129vkb.27.1554937208022; Wed, 10 Apr 2019 16:00:08 -0700 (PDT) Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com. [209.85.217.52]) by smtp.gmail.com with ESMTPSA id c192sm26891710vka.10.2019.04.10.16.00.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Apr 2019 16:00:07 -0700 (PDT) Received: by mail-vs1-f52.google.com with SMTP id n4so2379567vsm.3 for ; Wed, 10 Apr 2019 16:00:06 -0700 (PDT) X-Received: by 2002:a67:76c7:: with SMTP id r190mr26927257vsc.196.1554937206551; Wed, 10 Apr 2019 16:00:06 -0700 (PDT) MIME-Version: 1.0 References: <20190408220925.13077-1-mcroce@redhat.com> <20190408220925.13077-3-mcroce@redhat.com> In-Reply-To: From: Kees Cook Date: Wed, 10 Apr 2019 15:59:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] kernel: use sysctl shared variables for range check To: Matteo Croce Cc: Andrew Morton , LKML , "linux-fsdevel@vger.kernel.org" , Luis Chamberlain , Alexey Dobriyan Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Apr 10, 2019 at 3:54 PM Matteo Croce wrote: > > On Thu, Apr 11, 2019 at 12:34 AM Kees Cook wrote: > > > > On Wed, Apr 10, 2019 at 3:30 PM Matteo Croce wrote: > > > > > > FYI, this are the stats from my local repo, just to let you the size > > > of a series with all the changes in it: > > > > > > $ git --no-pager log --stat --oneline linus/master > > > 2 files changed, 4 insertions(+), 9 deletions(-) > > > 2 files changed, 7 insertions(+), 14 deletions(-) > > > 6 files changed, 15 insertions(+), 30 deletions(-) > > > 1 file changed, 16 insertions(+), 19 deletions(-) > > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > 3 files changed, 15 insertions(+), 20 deletions(-) > > > 12 files changed, 93 insertions(+), 116 deletions(-) > > > 3 files changed, 98 insertions(+), 104 deletions(-) > > > 2 files changed, 9 insertions(+) > > > > Tiny! :) Seriously, though, I think this should be fine to take > > directly to Linus after patch 1 lands, or see if akpm wants to carry > > it directly. > > > > -- > > Kees Cook > > Nice. Still as an 8 patches series, or squashed into a bigger one? I suspect a single patch would be fine, but let's wait to hear from akpm. -- Kees Cook