From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f42.google.com ([209.85.160.42]:46511 "EHLO mail-pl0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965049AbeEJQEi (ORCPT ); Thu, 10 May 2018 12:04:38 -0400 MIME-Version: 1.0 From: Steve French Date: Thu, 10 May 2018 11:04:14 -0500 Message-ID: Subject: [PATCH] cifs/smb3: directory sync should not return an error To: CIFS Cc: linux-fsdevel , samba-technical Content-Type: multipart/mixed; boundary="000000000000247fe8056bdc2da1" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --000000000000247fe8056bdc2da1 Content-Type: text/plain; charset="UTF-8" As with NFS, which ignores sync on directory handles, fsync on a directory handle is a noop for CIFS/SMB3. Do not return an error on it. It breaks some database apps otherwise. -- Thanks, Steve --000000000000247fe8056bdc2da1 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-smb3-directory-sync-should-not-return-an-error.patch" Content-Disposition: attachment; filename="0001-smb3-directory-sync-should-not-return-an-error.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jh0q3hxg0 RnJvbSA2MTEyYTQ5Njc1NzNmOWEzNDdmN2FiYzAyZTgwNDIzODUxYjczNzM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGV2ZSBGcmVuY2ggPHNtZnJlbmNoQGdtYWlsLmNvbT4KRGF0 ZTogVGh1LCAxMCBNYXkgMjAxOCAxMDo1OTozNyAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIHNtYjM6 IGRpcmVjdG9yeSBzeW5jIHNob3VsZCBub3QgcmV0dXJuIGFuIGVycm9yCgpBcyB3aXRoIE5GUywg d2hpY2ggaWdub3JlcyBzeW5jIG9uIGRpcmVjdG9yeSBoYW5kbGVzLApmc3luYyBvbiBhIGRpcmVj dG9yeSBoYW5kbGUgaXMgYSBub29wIGZvciBDSUZTL1NNQjMuCkRvIG5vdCByZXR1cm4gYW4gZXJy b3Igb24gaXQuICBJdCBicmVha3Mgc29tZSBkYXRhYmFzZQphcHBzIG90aGVyd2lzZS4KClNpZ25l ZC1vZmYtYnk6IFN0ZXZlIEZyZW5jaCA8c21mcmVuY2hAZ21haWwuY29tPgpDQzogU3RhYmxlIDxz dGFibGVAdmdlci5rZXJuZWwub3JnPgotLS0KIGZzL2NpZnMvY2lmc2ZzLmMgfCAxMyArKysrKysr KysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2Zz L2NpZnMvY2lmc2ZzLmMgYi9mcy9jaWZzL2NpZnNmcy5jCmluZGV4IGVkOGUxODE5MjdkNi4uOGU0 MTE4NmQ5OTIzIDEwMDY0NAotLS0gYS9mcy9jaWZzL2NpZnNmcy5jCisrKyBiL2ZzL2NpZnMvY2lm c2ZzLmMKQEAgLTEwNDksNiArMTA0OSwxOCBAQCBzc2l6ZV90IGNpZnNfZmlsZV9jb3B5Y2h1bmtf cmFuZ2UodW5zaWduZWQgaW50IHhpZCwKIAlyZXR1cm4gcmM7CiB9CiAKKy8qCisgKiBEaXJlY3Rv cnkgb3BlcmF0aW9ucyB1bmRlciBDSUZTL1NNQjIvU01CMyBhcmUgc3luY2hyb25vdXMsIHNvIGZz eW5jKCkKKyAqIGlzIGEgZHVtbXkgb3BlcmF0aW9uLgorICovCitpbnQgY2lmc19kaXJfZnN5bmMo c3RydWN0IGZpbGUgKmZpbGUsIGxvZmZfdCBzdGFydCwgbG9mZl90IGVuZCwgaW50IGRhdGFzeW5j KQoreworCWNpZnNfZGJnKEZZSSwgIlN5bmMgZGlyZWN0b3J5IC0gbmFtZTogJXBEIGRhdGFzeW5j OiAweCV4XG4iLAorCQkgZmlsZSwgZGF0YXN5bmMpOworCisJcmV0dXJuIDA7Cit9CisKIHN0YXRp YyBzc2l6ZV90IGNpZnNfY29weV9maWxlX3JhbmdlKHN0cnVjdCBmaWxlICpzcmNfZmlsZSwgbG9m Zl90IG9mZiwKIAkJCQlzdHJ1Y3QgZmlsZSAqZHN0X2ZpbGUsIGxvZmZfdCBkZXN0b2ZmLAogCQkJ CXNpemVfdCBsZW4sIHVuc2lnbmVkIGludCBmbGFncykKQEAgLTExODMsNiArMTE5NSw3IEBAIGNv bnN0IHN0cnVjdCBmaWxlX29wZXJhdGlvbnMgY2lmc19kaXJfb3BzID0gewogCS5jb3B5X2ZpbGVf cmFuZ2UgPSBjaWZzX2NvcHlfZmlsZV9yYW5nZSwKIAkuY2xvbmVfZmlsZV9yYW5nZSA9IGNpZnNf Y2xvbmVfZmlsZV9yYW5nZSwKIAkubGxzZWVrID0gZ2VuZXJpY19maWxlX2xsc2VlaywKKwkuZnN5 bmMgPSBjaWZzX2Rpcl9mc3luYywKIH07CiAKIHN0YXRpYyB2b2lkCi0tIAoyLjE3LjAKCg== --000000000000247fe8056bdc2da1--