From: Steve French <smfrench@gmail.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: B1C0D8C0 AACEC2D2D3CDC5CDCACE <alexander198961@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
kernelnewbies@kernelnewbies.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Need advice about do we need this if condition
Date: Wed, 17 Apr 2019 08:32:12 -0500 [thread overview]
Message-ID: <CAH2r5mvON=nCftcqcb4znhdOYR8XHcCKJseorWvzUVhG7oa8CQ@mail.gmail.com> (raw)
In-Reply-To: <19402.1555487793@turing-police>
On Wed, Apr 17, 2019 at 2:59 AM Valdis Klētnieks
<valdis.kletnieks@vt.edu> wrote:
>
> On Wed, 17 Apr 2019 08:25:22 +0300
>
> (Adding Al Viro and the linux-fsdevel lists, as at the very least, the manpage
> for the syscall needs some clarification...)
>
> > hello I am trying to fix https://bugzilla.kernel.org/show_bug.cgi?id=202935
>
> So - convince us that it's in fact a "bug" and not a restriction.
>
> > I found cause
> > https://github.com/torvalds/linux/blob/master/fs/cifs/cifsfs.c#L1076 not
> > sure is it correct to remove such condition ?
>
> Does the CIFS protocol support copying from a file to another location in the
> same file? Was it intended to work on *any* filesystem?
Looks like it should be allowed on the same file as long as the source
and target file ranges do not overlap
See https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/1ee611b7-43f0-468c-8a9d-28f04cdc3376
section 2.3.7.2 and 2.3.8
Server returns STATUS_NOT_SUPPORTED if "The source and target
destination ranges overlap on the same file."
and line 112 and following of smb2_ioctl_filesys.c in Samba code
https://git.samba.org/?p=samba.git;a=blob;f=source3/smbd/smb2_ioctl_filesys.c;h=8a9c8c64ec9ddbca4623251555f4792d76aa6e44;hb=refs/heads/master#l112
> (For that matter, the manpage for the syscall is unclear on whether having both
> file descriptors open on the same file is OK or not - for bonus ambiguity
> points, there's exactly zero discussion of what happens if source and
> destination overlap destructively).
>
--
Thanks,
Steve
prev parent reply other threads:[~2019-04-17 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANtEx+B4_-7Kfq6Gur1xHcXnTYRq8ZN=Qqs2X=h-ZJuFFF7LbQ@mail.gmail.com>
2019-04-17 7:56 ` Need advice about do we need this if condition Valdis Klētnieks
2019-04-17 13:32 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5mvON=nCftcqcb4znhdOYR8XHcCKJseorWvzUVhG7oa8CQ@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=alexander198961@gmail.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).