archive mirror
 help / color / mirror / Atom feed
From: Steve French <>
To: Ronnie Sahlberg <>
Cc: CIFS <>,
	LKML <>,
	samba-technical <>,
	linux-fsdevel <>
Subject: Re: [PATCHv2][SMB3] Add kernel trace support
Date: Fri, 18 May 2018 01:19:30 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, May 17, 2018 at 10:28 PM, Ronnie Sahlberg <> wrote:
> Very nice.
> Acked-by: Ronnie Sahlberg <>
> Possibly change the output from
> pid=6633 tid=0x0 sid=0x0 cmd=0 mid=0
> to
> cmd=0 mid=0 pid=6633 tid=0x0 sid=0x0
> just to make it easier for human-searching. I think the cmd will be useful much more often than pid/tid/sid
> and this would make it easier to look for as all cmd= entries will be aligned to the same column.

My instinct is to preserve the consistency by beginning with the the
fields that will be in 90% of the commands: tree id and session id
(tid and sid), which would cause pid to move after sid or after cmd,
but I would prefer to wait on reordering fields and fixing alignment
till we add another set of tracepoints (e.g. in FreeXid, and in
SMB2_open and in the caller of negprot/sessionsetup) - we should then
have a better idea what formatting would make it slightly more
consistent and readable.

  reply	other threads:[~2018-05-18  6:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  2:36 [PATCHv2][SMB3] Add kernel trace support Steve French
2018-05-18  3:28 ` Ronnie Sahlberg
2018-05-18  6:19   ` Steve French [this message]
2018-05-18  8:00     ` ronnie sahlberg
2018-05-18 18:14       ` Steve French
2018-05-18 18:46 ` Ralph Böhme
2018-05-18 20:43   ` Steve French
2018-05-19 23:22     ` Dave Chinner
2018-05-20  1:56       ` Steve French
2018-05-20 23:17         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).