From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f51.google.com ([209.85.215.51]:33311 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752543AbeCDPBq (ORCPT ); Sun, 4 Mar 2018 10:01:46 -0500 Received: by mail-lf0-f51.google.com with SMTP id o145so19551062lff.0 for ; Sun, 04 Mar 2018 07:01:45 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180303091913.GA13118@mail.hallyn.com> References: <2e5d93ee46feca915a101c2fc3062da674a98223.1519930146.git.rgb@redhat.com> <20180303091913.GA13118@mail.hallyn.com> From: Paul Moore Date: Sun, 4 Mar 2018 10:01:43 -0500 Message-ID: Subject: Re: [RFC PATCH V1 01/12] audit: add container id To: "Serge E. Hallyn" , Richard Guy Briggs Cc: mszeredi@redhat.com, ebiederm@xmission.com, simo@redhat.com, jlayton@redhat.com, carlos@redhat.com, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, LKML , Eric Paris , dhowells@redhat.com, Linux-Audit Mailing List , viro@zeniv.linux.org.uk, luto@kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, trondmy@primarydata.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Mar 3, 2018 at 4:19 AM, Serge E. Hallyn wrote: > On Thu, Mar 01, 2018 at 02:41:04PM -0500, Richard Guy Briggs wrote: > ... >> +static inline bool audit_containerid_set(struct task_struct *tsk) > > Hi Richard, > > the calls to audit_containerid_set() confused me. Could you make it > is_audit_containerid_set() or audit_containerid_isset()? I haven't gone through the entire patchset yet, but I wanted to quickly comment on this ... I really dislike the function-names-as-sentences approach and would would greatly prefer audit_containerid_isset(). >> +{ >> + return audit_get_containerid(tsk) != INVALID_CID; >> +} -- paul moore www.paul-moore.com