From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com ([209.85.167.67]:45661 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729483AbeKTBoD (ORCPT ); Mon, 19 Nov 2018 20:44:03 -0500 Received: by mail-lf1-f67.google.com with SMTP id b20so21560276lfa.12 for ; Mon, 19 Nov 2018 07:20:07 -0800 (PST) MIME-Version: 1.0 References: <20180904160632.21210-1-jack@suse.cz> <20180904160632.21210-13-jack@suse.cz> <20181114121616.GB19383@quack2.suse.cz> In-Reply-To: <20181114121616.GB19383@quack2.suse.cz> From: Paul Moore Date: Mon, 19 Nov 2018 10:19:55 -0500 Message-ID: Subject: Re: [PATCH 12/11 TESTSUITE] audit_testsuite: Add stress test for tree watches To: jack@suse.cz Cc: viro@zeniv.linux.org.uk, linux-audit@redhat.com, linux-fsdevel@vger.kernel.org, rgb@redhat.com, amir73il@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Nov 14, 2018 at 7:16 AM Jan Kara wrote: > On Tue 13-11-18 19:34:18, Paul Moore wrote: > > On Tue, Sep 4, 2018 at 12:06 PM Jan Kara wrote: > > > Add stress test for stressing audit tree watches by adding and deleting > > > rules while events are generated and watched filesystems are mounted and > > > unmounted in parallel. > > > > > > Signed-off-by: Jan Kara > > > --- > > > tests/stress_tree/Makefile | 8 +++ > > > tests/stress_tree/test | 171 +++++++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 179 insertions(+) > > > create mode 100644 tests/stress_tree/Makefile > > > create mode 100755 tests/stress_tree/test > > > > I'd like to get this into the audit-testsuite repo, but I think it > > should live under test_manual/ instead of tests, is that okay with > > you? If so, no need to resubmit, I can move the file during the > > merge. > > Sure, move it wherever you find it best. Great, merged into the tests_manual directory, and fixed up some style nits found via ./tools/check-syntax. Thanks again! > > > diff --git a/tests/stress_tree/Makefile b/tests/stress_tree/Makefile > > > new file mode 100644 > > > index 000000000000..7ade09aad86f > > > --- /dev/null > > > +++ b/tests/stress_tree/Makefile > > > @@ -0,0 +1,8 @@ > > > +TARGETS=$(patsubst %.c,%,$(wildcard *.c)) > > > + > > > +LDLIBS += -lpthread > > > + > > > +all: $(TARGETS) > > > +clean: > > > + rm -f $(TARGETS) > > > + > > > diff --git a/tests/stress_tree/test b/tests/stress_tree/test > > > new file mode 100755 > > > index 000000000000..6215bec810d1 > > > --- /dev/null > > > +++ b/tests/stress_tree/test > > > @@ -0,0 +1,171 @@ > > > +#!/usr/bin/perl > > > + > > > +use strict; > > > + > > > +use Test; > > > +BEGIN { plan tests => 1 } > > > + > > > +use File::Temp qw/ tempdir tempfile /; > > > + > > > +### > > > +# functions > > > + > > > +sub key_gen { > > > + my @chars = ( "A" .. "Z", "a" .. "z" ); > > > + my $key = "testsuite-" . time . "-"; > > > + $key .= $chars[ rand @chars ] for 1 .. 8; > > > + return $key; > > > +} > > > + > > > +# Run stat on random files in subtrees to generate audit events > > > +sub run_stat { > > > + my($dir,$dirs) = @_; > > > + my $path; > > > + > > > + while (1) { > > > + $path = "$dir/mnt/mnt".int(rand($dirs))."/subdir".int(rand($dirs)); > > > + stat($path); > > > + } > > > +} > > > + > > > +# Generate audit rules for subtrees. Do one rule per subtree. Because watch > > > +# recursively iterates child mounts and we mount $dir/leaf$i under various > > > +# subtrees, the inode corresponding to $dir/leaf$i gets tagged by different > > > +# trees. > > > +sub run_mark_audit { > > > + my($dir,$dirs,$key) = @_; > > > + > > > + while (1) { > > > + for (my $i=0; $i < $dirs; $i++) { > > > + system("auditctl -w $dir/mnt/mnt$i -p r -k $key"); > > > + } > > > + system("auditctl -D -k $key >& /dev/null"); > > > + } > > > +} > > > + > > > +sub umount_all { > > > + my($dir,$dirs,$ignore_fail) = @_; > > > + > > > + for (my $i=0; $i < $dirs; $i++) { > > > + while (system("umount $dir/leaf$i >& /dev/null") > 0 && > > > + $ignore_fail == 0) { > > > + # Nothing - loop until umount succeeds > > > + } > > > + } > > > + for (my $i=0; $i < $dirs; $i++) { > > > + for (my $j=0; $j < $dirs; $j++) { > > > + while (system("umount $dir/mnt/mnt$i/subdir$j >& /dev/null") > 0 && > > > + $ignore_fail == 0) { > > > + # Nothing - loop until umount succeeds > > > + } > > > + } > > > + while (system("umount $dir/mnt/mnt$i >& /dev/null") > 0 && > > > + $ignore_fail == 0) { > > > + # Nothing - loop until umount succeeds > > > + } > > > + } > > > +} > > > + > > > +# Mount and unmount filesystems. We pick random leaf mount so that sometimes > > > +# a leaf mount point root inode will gather more tags from different trees > > > +# and sometimes we will be quicker in unmounting all instances of leaf and > > > +# thus excercise inode evistion path > > > +sub run_mount { > > > + my($dir,$dirs) = @_; > > > + > > > + while (1) { > > > + # We use tmpfs here and not just bind mounts of some dir so > > > + # that the root inode gets evicted once all instances are > > > + # unmounted. > > > + for (my $i=0; $i < $dirs; $i++) { > > > + system("mount -t tmpfs none $dir/leaf$i"); > > > + } > > > + for (my $i=0; $i < $dirs; $i++) { > > > + system("mount --bind $dir/dir$i $dir/mnt/mnt$i"); > > > + for (my $j=0; $j < $dirs; $j++) { > > > + my $leaf="$dir/leaf".int(rand($dirs)); > > > + system("mount --bind $leaf $dir/mnt/mnt$i/subdir$j"); > > > + } > > > + } > > > + umount_all($dir, $dirs, 0); > > > + } > > > +} > > > + > > > + > > > +### > > > +# setup > > > + > > > +# reset audit > > > +system("auditctl -D >& /dev/null"); > > > + > > > +# create temp directory > > > +my $dir = tempdir( TEMPLATE => '/tmp/audit-testsuite-XXXX', CLEANUP => 1 ); > > > + > > > +# create stdout/stderr sinks > > > +( my $fh_out, my $stdout ) = tempfile( > > > + TEMPLATE => '/tmp/audit-testsuite-out-XXXX', > > > + UNLINK => 1 > > > +); > > > +( my $fh_err, my $stderr ) = tempfile( > > > + TEMPLATE => '/tmp/audit-testsuite-err-XXXX', > > > + UNLINK => 1 > > > +); > > > + > > > +### > > > +# tests > > > + > > > +my $dirs = 4; > > > + > > > +# setup directory hierarchy > > > +for (my $i=0; $i < $dirs; $i++) { > > > + mkdir $dir."/dir".$i; > > > + for (my $j=0; $j < $dirs; $j++) { > > > + mkdir $dir."/dir".$i."/subdir".$j; > > > + } > > > +} > > > +mkdir "$dir/mnt"; > > > +for (my $i=0; $i < $dirs; $i++) { > > > + mkdir "$dir/mnt/mnt$i"; > > > + mkdir "$dir/leaf$i"; > > > +} > > > + > > > +my $stat_pid = fork(); > > > + > > > +if ($stat_pid == 0) { > > > + run_stat($dir, $dirs); > > > + # Never reached > > > + exit; > > > +} > > > + > > > +my $mount_pid = fork(); > > > + > > > +if ($mount_pid == 0) { > > > + run_mount($dir, $dirs); > > > + # Never reached > > > + exit; > > > +} > > > + > > > +my $key = key_gen(); > > > + > > > +my $audit_pid = fork(); > > > + > > > +if ($audit_pid == 0) { > > > + run_mark_audit($dir, $dirs, $key); > > > + # Never reached > > > + exit; > > > +} > > > + > > > +# Sleep for a minute to let stress test run... > > > +sleep(60); > > > +ok(1); > > > + > > > +### > > > +# cleanup > > > + > > > +kill('KILL', $stat_pid, $mount_pid, $audit_pid); > > > +# Wait for children to terminate > > > +waitpid($stat_pid, 0); > > > +waitpid($mount_pid, 0); > > > +waitpid($audit_pid, 0); > > > +system("auditctl -D >& /dev/null"); > > > +umount_all($dir, $dirs, 1); > > > -- > > > 2.16.4 > > > > > > > > > -- > > paul moore > > www.paul-moore.com > -- > Jan Kara > SUSE Labs, CR -- paul moore www.paul-moore.com