From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B813CC282D7 for ; Thu, 31 Jan 2019 02:21:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 857A720881 for ; Thu, 31 Jan 2019 02:21:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="pbs0nwWZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726445AbfAaCU4 (ORCPT ); Wed, 30 Jan 2019 21:20:56 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:43153 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725771AbfAaCU4 (ORCPT ); Wed, 30 Jan 2019 21:20:56 -0500 Received: by mail-lj1-f195.google.com with SMTP id q2-v6so1265374lji.10 for ; Wed, 30 Jan 2019 18:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uh74GacBX+DFBcLdPevPo476fnugJ6CFBseLirFZjsU=; b=pbs0nwWZNvqqXwvsoeG3K8xT0oDD3xAUd5ChGiWqHuUHR6uXwhWqRNojMnVrcYRonV s4U1onizGhCWRYQPV6I6e1G5Ef92kxwqnF6+fUdq2ugTTdmSzpuvWmrYEhGYOyF4Jgqi mYGsoWHCo4jGCODSzwHEXKmDEBkTweoArlBce837nEhm40zVt0aQb4cCLbLr6RKrb9Iw oOOpz/HchwCOU3vPkXQ9NfmEb+dVQIXaJWAF/PcukSe+NL5O2xLeJfmETHDi3SCIKV0N B5XfqsQYGOaFEQBUrr/bv6LlYQPAuaBAFdYmWi86SG6KdK7wOmiOMmGPNUQjwf9PXjUv TrIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uh74GacBX+DFBcLdPevPo476fnugJ6CFBseLirFZjsU=; b=AW4LkINUOAceHecv4ga105ULE+d+9uRbZDTL6KLK2QVwF2vHzqotgR3FezW90Apd6Q d5ar3LOryRqYXq1uwXAo16TkQnE0sr6E1OXbD9Nlu9qxOQu9KKUUu/2ti6MCns5bZVK1 YL+w1CxHI3wELJX1H/Lai/S2FHF3Vn4stvLJqreVEWCsepiuhn2/mted0HZJ0saHBTAZ Bj/daMbRfFideEwqUFrzYOCF6HKwI7bdbLxKf8jJgrh+xnl7lbSiCb9U+ZBpPf8Jcb13 Uqd5mHPeTefwOhcrLdVTTdjpqBM4sVEFK0jQEeF+hd9NB6Srk6bPj0eGZZb+8T2HKCNQ K5UA== X-Gm-Message-State: AJcUukffqwqZAi3wQYXRAh1lWq1sgU5OBKgd/s/hYpyTeWd1xLnr/Xip BUrrv2DVHWxuB4nOFG9nMbadc6TBVOYLN+94c4HP X-Google-Smtp-Source: ALg8bN539yNCzpfobtIE+JjCNNP5A84m1KWfQn3X/b6cSnuobZ4wnYh4e6z+5dVaQ0RYK4k6bxzzoxDcEADUSTNmUg8= X-Received: by 2002:a2e:4299:: with SMTP id h25-v6mr26746677ljf.5.1548901253946; Wed, 30 Jan 2019 18:20:53 -0800 (PST) MIME-Version: 1.0 References: <397a8b086e6aa9eb797f1538901e95462822ecb0.1548196083.git.rgb@redhat.com> <20190125222717.x7lyzjn2qfzdzp4k@madcap2.tricolour.ca> In-Reply-To: From: Paul Moore Date: Wed, 30 Jan 2019 21:20:42 -0500 Message-ID: Subject: Re: [PATCH ghak100 V2 2/2] audit: ignore fcaps on umount To: Richard Guy Briggs , linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk Cc: LKML , Linux-Audit Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 28, 2019 at 6:25 PM Paul Moore wrote: > On Fri, Jan 25, 2019 at 5:27 PM Richard Guy Briggs wrote: > > On 2019-01-25 16:45, Paul Moore wrote: > > > On Wed, Jan 23, 2019 at 1:35 PM Richard Guy Briggs wrote: > > > > Don't fetch fcaps when umount2 is called to avoid a process hang while > > > > it waits for the missing resource to (possibly never) re-appear. > > > > > > > > Note the comment above user_path_mountpoint_at(): > > > > * A umount is a special case for path walking. We're not actually interested > > > > * in the inode in this situation, and ESTALE errors can be a problem. We > > > > * simply want track down the dentry and vfsmount attached at the mountpoint > > > > * and avoid revalidating the last component. > > > > > > > > This can happen on ceph, cifs, 9p, lustre, fuse (gluster) or NFS. > > > > > > > > Please see the github issue tracker > > > > https://github.com/linux-audit/audit-kernel/issues/100 > > > > > > > > Signed-off-by: Richard Guy Briggs > > > > --- > > > > fs/namei.c | 2 +- > > > > fs/namespace.c | 2 ++ > > > > include/linux/audit.h | 15 ++++++++++----- > > > > include/linux/namei.h | 3 +++ > > > > kernel/audit.c | 10 +++++++++- > > > > kernel/audit.h | 2 +- > > > > kernel/auditsc.c | 6 +++--- > > > > 7 files changed, 29 insertions(+), 11 deletions(-) ... > You posted this patch on the 23rd (last Wednesday), let's give the FS > folks another day or two to comment since it does touch their code. > If we don't see any objections by later this week I'll merge it into > audit/next. I'm not seeing any objections from the fs folks, so I'm merging this into audit/next. -- paul moore www.paul-moore.com