From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C6C5C4360F for ; Mon, 1 Apr 2019 18:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E038A206DD for ; Mon, 1 Apr 2019 18:57:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="VmoLYqOd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729137AbfDAS5x (ORCPT ); Mon, 1 Apr 2019 14:57:53 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:39987 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728830AbfDAS5w (ORCPT ); Mon, 1 Apr 2019 14:57:52 -0400 Received: by mail-lj1-f196.google.com with SMTP id q66so9211545ljq.7 for ; Mon, 01 Apr 2019 11:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OG3K/weV3XtavI0+FRqMauSdv1yTiVdKp7cI8yqJMVI=; b=VmoLYqOd9sBOa4qVc2Cv+v3SS9L2pZl7L12WgBXrhIoQb1aTyxkfrpGy+r8R01SHxs u+g7rMqwp6TxxoKZ6XtBADWzBw9O7IMCTeSuFnvhHOcPkM4pWJg8kbJVssXLPx1zgP8p Zxks+WxnpFjUiJgsLTYoU2/e2ZtgaMxYc65XLh4rq+7zRkfMC7xYa6mLIInd6NKA90VK vGr98dRfked97bwGv4K+HF/bupiA6ZKklTfx6mpoiwEHAH1uAMBpcCBjt15ty/BjqeJT M1ehNf+gSoo7PIr0N5uLwEmwyi3KkkFSr0Y8JllO41ZMahAnJv0hmOqd19lqtw5s60Qr Cu2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OG3K/weV3XtavI0+FRqMauSdv1yTiVdKp7cI8yqJMVI=; b=tcx+lnIjaKexkLR6EnuNPaWoml7lhajml1W/t7lqhuN6mp+MdVcNhezNxJYUB5ify4 apsjD79SuXAaKqMho0ACiV10xuMaw9FHHmPo9+8P2nbDJttAj5tTE9vq4agGI9/YKJ4q KAAPB3j746oh5JTzhxLsWeIPmrFLv062lD8+3R1K3rQAZlmfFocigvFpu4nj37AsMFQZ g4RiH70ExRFA7brNWCdV5MWg9Wev+gTDC4/mph0axvYJqeWmZKDzc2sZEuI5BIrN6lDO M6SFtO7Sknc5fE9aNIj5Pe4PVJ0/WZ3vZoPaM/RFcPbdFRw/D07YvJ/+bD9kySSHlA0T Uw6Q== X-Gm-Message-State: APjAAAXg3xClTLX/rNqFirubVwg1D+mEyNqY/fUmPSMqljjITpE5CSwg MXH70UgbnjW8b+bzZMK3C3koHnYitk6JWqdxsWgE X-Google-Smtp-Source: APXvYqzZTCmYYMmiZzBrxg5Ye2yEkEkTVeBsjiuhi46ic7qvkKj57eiftzomk3wmRubyS/f37cBTe/S79dQ8UA9Nlag= X-Received: by 2002:a2e:7114:: with SMTP id m20mr4729758ljc.120.1554145070271; Mon, 01 Apr 2019 11:57:50 -0700 (PDT) MIME-Version: 1.0 References: <700e4313571f86cc0cdcb7310fbe060f02c7c2db.1552665316.git.rgb@redhat.com> <20190401174432.fjnvotpvdrfujoy7@madcap2.tricolour.ca> In-Reply-To: <20190401174432.fjnvotpvdrfujoy7@madcap2.tricolour.ca> From: Paul Moore Date: Mon, 1 Apr 2019 14:57:39 -0400 Message-ID: Subject: Re: [PATCH ghak90 V5 06/10] audit: add support for non-syscall auxiliary records To: Richard Guy Briggs Cc: containers@lists.linux-foundation.org, linux-api@vger.kernel.org, Linux-Audit Mailing List , linux-fsdevel@vger.kernel.org, LKML , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, sgrubb@redhat.com, omosnace@redhat.com, dhowells@redhat.com, simo@redhat.com, Eric Paris , Serge Hallyn , ebiederm@xmission.com, nhorman@tuxdriver.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Apr 1, 2019 at 1:44 PM Richard Guy Briggs wrote: > On 2019-04-01 10:49, Paul Moore wrote: > > On Fri, Mar 15, 2019 at 2:34 PM Richard Guy Briggs wrote: > > > Standalone audit records have the timestamp and serial number generated > > > on the fly and as such are unique, making them standalone. This new > > > function audit_alloc_local() generates a local audit context that will > > > be used only for a standalone record and its auxiliary record(s). The > > > context is discarded immediately after the local associated records are > > > produced. > > > > > > Signed-off-by: Richard Guy Briggs > > > Acked-by: Serge Hallyn > > > --- > > > include/linux/audit.h | 8 ++++++++ > > > kernel/audit.h | 1 + > > > kernel/auditsc.c | 35 ++++++++++++++++++++++++++++++----- > > > 3 files changed, 39 insertions(+), 5 deletions(-) > > > > ... > > > > > diff --git a/include/linux/audit.h b/include/linux/audit.h > > > index ebd6625ca80e..6db5aba7cc01 100644 > > > --- a/include/linux/audit.h > > > +++ b/include/linux/audit.h > > > @@ -285,6 +285,8 @@ static inline void audit_log_contid(struct audit_context *context, u64 contid) > > > > > > /* These are defined in auditsc.c */ > > > /* Public API */ > > > +extern struct audit_context *audit_alloc_local(gfp_t gfpflags); > > > +extern void audit_free_context(struct audit_context *context); > > > extern void __audit_syscall_entry(int major, unsigned long a0, unsigned long a1, > > > unsigned long a2, unsigned long a3); > > > extern void __audit_syscall_exit(int ret_success, long ret_value); > > > @@ -512,6 +514,12 @@ static inline void audit_fanotify(unsigned int response) > > > extern int audit_n_rules; > > > extern int audit_signals; > > > #else /* CONFIG_AUDITSYSCALL */ > > > +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags) > > > +{ > > > + return NULL; > > > +} > > > +static inline void audit_free_context(struct audit_context *context) > > > +{ } > > > static inline void audit_syscall_entry(int major, unsigned long a0, > > > unsigned long a1, unsigned long a2, > > > unsigned long a3) > > > diff --git a/kernel/audit.h b/kernel/audit.h > > > index c5ac6436317e..2a1a8b8a8019 100644 > > > --- a/kernel/audit.h > > > +++ b/kernel/audit.h > > > @@ -111,6 +111,7 @@ struct audit_proctitle { > > > struct audit_context { > > > int dummy; /* must be the first element */ > > > int in_syscall; /* 1 if task is in a syscall */ > > > + bool local; /* local context needed */ > > > > It's very possible I've missed it, but "local" never gets used in any > > meaningful way in this patchset does it? > > It is used in audit_alloc_local() to signal to audit_get_stamp() that in > absence of a syscall flag, check for a local flag to continue rather > than return. I'm guessing you meant auditsc_get_stamp()? If so, okay. -- paul moore www.paul-moore.com