From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com ([209.85.208.195]:37498 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932296AbeF2SB4 (ORCPT ); Fri, 29 Jun 2018 14:01:56 -0400 Received: by mail-lj1-f195.google.com with SMTP id c11-v6so7959116lja.4 for ; Fri, 29 Jun 2018 11:01:56 -0700 (PDT) MIME-Version: 1.0 References: <20180628164014.4925-1-jack@suse.cz> In-Reply-To: From: Paul Moore Date: Fri, 29 Jun 2018 14:01:44 -0400 Message-ID: Subject: Re: [PATCH 0/6] audit: Fix various races when tagging and untagging mounts To: amir73il@gmail.com Cc: jack@suse.cz, linux-audit@redhat.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, rgb@redhat.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jun 29, 2018 at 7:44 AM Amir Goldstein wrote: > On Thu, Jun 28, 2018 at 7:40 PM, Jan Kara wrote: > > Hello, > > > > this series addresses the problems I have identified when trying to understand > > how exactly is kernel/audit_tree.c using generic fsnotify framework. I hope > > I have understood all the interactions right but careful review is certainly > > welcome (CCing Al as he was the one implementing this code originally). > > > > The patches have been tested by a stress test I have written which mounts & > > unmounts filesystems in the directory tree while adding and removing audit > > rules for this tree in parallel and accessing the tree to generate events. > > Still some real-world testing would be welcome. > > > > This sort of stress test sound really useful to fanotify/inotify as well. > Do plan to upstream that stress test? Agreed. I would be interested in having something like this in the audit-testsuite so that we can include it in our regular regression testing. * https://github.com/linux-audit/audit-testsuite -- paul moore www.paul-moore.com