From mboxrd@z Thu Jan  1 00:00:00 1970
From: Trond Myklebust <trond.myklebust@primarydata.com>
Subject: Re: [RFC v3 37/45] nfs/sunrpc: No more encode and decode function
 pointer casting
Date: Thu, 28 May 2015 19:11:14 -0400
Message-ID: <CAHQdGtSUjeV_5UNFdgMQXXbRq2Fs+JTc6t-Dy2y1-hS4c49GOA@mail.gmail.com>
References: <cover.1429868795.git.agruenba@redhat.com>
	<9fee05c37be52b8f8fcd5df05f391af9e3d820e8.1429868795.git.agruenba@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
To: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-vn0-f49.google.com ([209.85.216.49]:34542 "EHLO
	mail-vn0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932415AbbE1XLQ (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 28 May 2015 19:11:16 -0400
Received: by vnbf129 with SMTP id f129so6544713vnb.1
        for <linux-fsdevel@vger.kernel.org>; Thu, 28 May 2015 16:11:14 -0700 (PDT)
In-Reply-To: <9fee05c37be52b8f8fcd5df05f391af9e3d820e8.1429868795.git.agruenba@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Apr 24, 2015 at 7:04 AM, Andreas Gruenbacher
<andreas.gruenbacher@gmail.com> wrote:
> Instead of casting the encode and decode functions to the required type when
> assigning them to the p_encode and p_decode members of struct rpc_procinfo,
> define the functions with their proper type and cast the additional obj
> argument to the appropriate type inside those functions. This allows slightly
> better type checking by the compiler at the cost of slightly more verbose code.

How is this even remotely relevant to ACL functionality, and why does
it deserve to bypass the NFS tree?

Trond