From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A274C433E0 for ; Wed, 10 Feb 2021 00:00:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 242A164E40 for ; Wed, 10 Feb 2021 00:00:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234386AbhBIX7h (ORCPT ); Tue, 9 Feb 2021 18:59:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234250AbhBIXcK (ORCPT ); Tue, 9 Feb 2021 18:32:10 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F099C061574; Tue, 9 Feb 2021 15:31:30 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id y18so408671edw.13; Tue, 09 Feb 2021 15:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SppdSCl2Hme6/0W5XbF7DtR4/Tbyteffik5eXOy3CDs=; b=Bdvt2hK50arKPZ3PpbfPSBqtvsuBzb51S/mVQNIYON95z3t/S/VkR1pX/UlUpHEGyq g1eTuwz9c1M9a4SJpBYF1oTxtqcrlrr+AbB8IIDxzCytack2IkYHnHrKQ6GV83TZbgrP ClT5iA7dcKZ0oCJCIZ86DRGQSGoPwVZ67zE0Wk8ZauiKusgVTFXnO9MBuBYGWofH8P0U PYZEyk9Otk6GeJ/3NbpQl3P7gehFMIbNq4Iti7wyDRCMElJapLPwIAPNE9d8jit3plgY g0KTxXj9CxlzS6EJA8ROKNANPKYNdE6l50bpDlNnFWdsm1tZc0WEOU0Ex6Hqlb9HK17k +jBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SppdSCl2Hme6/0W5XbF7DtR4/Tbyteffik5eXOy3CDs=; b=glvznDXlV4Y7XgpY/9Dadb7jqXMSjK44XML/eeYDJZBTgxTKyJduISBooXEbWqcxQu Afl0Qn9HrQJa4gnyY2tccsJatT/xawN6Rp90gDCAqBL6UWfElIiXPDIS5SnFJzMSpOLM V2fNK03IYrZJhHByRhh6+nU5WvobkKV3VlKG8c9ENHcoBVoVvQe5K7kOxjEfdG36T1G0 uWvtpr+ytxNXZST0/wnR5TZRS6lbq6ZQ1fjfFdYzOlSbghZmVvq5ndQWD9zHKWiZIrAe Qjy+Qnk1W990dmxFzmWP2M7rHSbs2/LOerGV+x9k470NDpwf83Bf1NmPFvh6NXfYzT4o eMeg== X-Gm-Message-State: AOAM530wG0V/CAqNJDt482lr+G/ElDUSsNnmd04pb/4hdjmeYctXswkZ fMequnmu6ssb7cxE7ywaehV4g00pdLS7oNRAnlY= X-Google-Smtp-Source: ABdhPJwD5iBUaoZ2DF9YLO6QB40HK0Y7wa32nRRFzuU242PC6dr8mLNS8Eh8gngI+Dc2H0Y9e8RnuUaskB3yeM3xGyQ= X-Received: by 2002:a05:6402:3069:: with SMTP id bs9mr532983edb.151.1612913488857; Tue, 09 Feb 2021 15:31:28 -0800 (PST) MIME-Version: 1.0 References: <20210209174646.1310591-1-shy828301@gmail.com> <20210209174646.1310591-5-shy828301@gmail.com> <20210209204314.GG524633@carbon.DHCP.thefacebook.com> In-Reply-To: <20210209204314.GG524633@carbon.DHCP.thefacebook.com> From: Yang Shi Date: Tue, 9 Feb 2021 15:31:17 -0800 Message-ID: Subject: Re: [v7 PATCH 04/12] mm: vmscan: remove memcg_shrinker_map_size To: Roman Gushchin Cc: Kirill Tkhai , Vlastimil Babka , Shakeel Butt , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Feb 9, 2021 at 12:43 PM Roman Gushchin wrote: > > On Tue, Feb 09, 2021 at 09:46:38AM -0800, Yang Shi wrote: > > Both memcg_shrinker_map_size and shrinker_nr_max is maintained, but actually the > > map size can be calculated via shrinker_nr_max, so it seems unnecessary to keep both. > > Remove memcg_shrinker_map_size since shrinker_nr_max is also used by iterating the > > bit map. > > > > Acked-by: Kirill Tkhai > > Signed-off-by: Yang Shi > > --- > > mm/vmscan.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index e4ddaaaeffe2..641077b09e5d 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -185,8 +185,10 @@ static LIST_HEAD(shrinker_list); > > static DECLARE_RWSEM(shrinker_rwsem); > > > > #ifdef CONFIG_MEMCG > > +static int shrinker_nr_max; > > > > -static int memcg_shrinker_map_size; > > +#define NR_MAX_TO_SHR_MAP_SIZE(nr_max) \ > > + (DIV_ROUND_UP(nr_max, BITS_PER_LONG) * sizeof(unsigned long)) > > How about something like this? > > static inline int shrinker_map_size(int nr_items) > { > return DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long); > } > > I think it look less cryptic. OK, I don't have a strong opinion for either one (inline function or macro). If no one objects this I could do it in the new version. > > The rest of the patch looks good to me. > > Thanks!