From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71B56C0650E for ; Wed, 3 Jul 2019 22:35:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 540B621871 for ; Wed, 3 Jul 2019 22:35:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727168AbfGCWfx (ORCPT ); Wed, 3 Jul 2019 18:35:53 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:42394 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbfGCWfw (ORCPT ); Wed, 3 Jul 2019 18:35:52 -0400 Received: by mail-ot1-f67.google.com with SMTP id l15so4053872otn.9 for ; Wed, 03 Jul 2019 15:35:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uF998D8BR4hjaWYM/cm2nCswL6OUaWgofBX0cNua7mY=; b=Oh85pGaoRfsoaqsDmyLA35uUD3i2iLVLsG2rXzSpjf+skjPaQhYaFQJBnp6R9jgBqn fsn5kYADp/VM4oJmLp1IgmAQl/R5cSMbWeV3Ug2v9S6pmrxPLr+2ucXtqIVFsFB/o4mp UUwu8nnPHjPIJZjQFNZqyx1DPSEG+cqGCnvTMG+p757Dgo9yH2uJPEvhYSRpEd7+Df4A IVqybH5jcN3fse8TVw9feDm7EUpTRc2DA5nvuN+EOEV2r/58TFUNEWKzRRODvLN26Ean 02+Wub7Elmy2GeDgwagYBNY5mSp2Hg5e3dNYWsopohFMyAE7BldEa0BTt31YgqXImrrp 5MXA== X-Gm-Message-State: APjAAAW0JA6XJkb8JMdYrK6Xo/u+7pSeIAhiToK8yhpmilx2sdttME7D 8H5QPZcqlIntvMay+UaRH8hcECYVnaE/VIB351YJjA== X-Google-Smtp-Source: APXvYqyb3lCMpWvP5vv5fGbRMbkszNsSf4Dh8Q3SscBMZpgOEptvKSRqy1VjJc/2nmujeUFQiYMDumOh8kn0s1bWND8= X-Received: by 2002:a9d:5cc1:: with SMTP id r1mr28332622oti.341.1562193352267; Wed, 03 Jul 2019 15:35:52 -0700 (PDT) MIME-Version: 1.0 References: <20190701215439.19162-1-hch@lst.de> In-Reply-To: <20190701215439.19162-1-hch@lst.de> From: Andreas Gruenbacher Date: Thu, 4 Jul 2019 00:35:41 +0200 Message-ID: Subject: Re: RFC: use the iomap writepage path in gfs2 To: Christoph Hellwig Cc: "Darrick J . Wong" , linux-xfs@vger.kernel.org, linux-fsdevel , cluster-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Christoph, On Mon, 1 Jul 2019 at 23:54, Christoph Hellwig wrote: > Hi all, > > in this straight from the jetplane edition I present the series to > convert gfs2 to full iomap usage for the ordered and writeback mode, > that is we use iomap_page everywhere and entirely get rid of > buffer_heads in the data path. thank you very much, this is looking very good. I've done some testing with your cleanups applied so that those can go in in this merge window. The result can be found here: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/log/?h=for-next.cleanups Patch "gfs2: implement gfs2_block_zero_range using iomap_zero_range" isn't quite ready: the gfs2 iomap operations don't handle IOMAP_ZERO correctly so far, and that needs to be fixed first. The actual buffer head removal will obviously have to wait a little longer because of the required infrastructure changes, but also because that still needs a lot more review and testing work. > This has only seen basic testing which ensured neither 4k or 1k blocksize > in ordered mode regressed vs the xfstests baseline, although that baseline > tends to look pretty bleak. Some of the tests assume that the filesystem supports unwritten extents, trusted xattrs, the usrquota / grpquota / prjquota mount options. There shouldn't be a huge number of failing tests beyond that, but I know things aren't perfect. > The series is to be applied on top of my "lift the xfs writepage code > into iomap v2" series. Again, thanks a lot for the patches! Andreas