linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: cluster-devel <cluster-devel@redhat.com>,
	linux-ext4 <linux-ext4@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/1] iomap: Direct I/O for inline data
Date: Fri, 29 Jun 2018 13:01:48 +0200	[thread overview]
Message-ID: <CAHc6FU5yrGCZ+aVxeo9tBxmmQRKs02r2MwE_JMQxQpaZ61PU-w@mail.gmail.com> (raw)
In-Reply-To: <20180629084313.GA16042@lst.de>

On 29 June 2018 at 10:43, Christoph Hellwig <hch@lst.de> wrote:
>> A possible fix is to change the alignment check in iomap_dio_actor as follows:
>>
>> -       if ((pos | length | align) & ((1 << blkbits) - 1))
>> +       if ((pos | align) & ((1 << blkbits) - 1))
>> +               return -EINVAL;
>> +       if (length & ((1 << blkbits) - 1) &&
>> +           pos + length != iomap->offset + iomap->length)
>>                 return -EINVAL;
>>
>> Moving the alignment check from iomap_dio_actor to iomap_dio_rw isn't
>> that easy because iomap->bdev isn't known there.
>
> Just make the check conditional on iomap->type != IOMAP_INLINE
> as alignment checks on inline data don't make much sense.

Yeah, probably.

Thanks,
Andreas

      reply	other threads:[~2018-06-29 11:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  0:39 [PATCH 0/1] iomap: Direct I/O for inline data Andreas Gruenbacher
2018-06-27  0:39 ` [PATCH 1/1] " Andreas Gruenbacher
2018-06-27  1:44   ` kbuild test robot
2018-06-29  8:56   ` Christoph Hellwig
2018-06-29 14:40     ` Andreas Gruenbacher
2018-06-29 16:01       ` Christoph Hellwig
2018-06-29 17:02         ` Andreas Gruenbacher
2018-07-01  6:13           ` Christoph Hellwig
2018-07-01  6:29       ` Christoph Hellwig
2018-07-01 21:44         ` Andreas Gruenbacher
2018-06-27 11:14 ` [PATCH 0/1] " Andreas Gruenbacher
2018-06-29  8:43   ` Christoph Hellwig
2018-06-29 11:01     ` Andreas Gruenbacher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHc6FU5yrGCZ+aVxeo9tBxmmQRKs02r2MwE_JMQxQpaZ61PU-w@mail.gmail.com \
    --to=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).