From: Andreas Gruenbacher <agruenba@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Jan Kara <jack@suse.cz>, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fs/posix_acl.c: fix kernel-doc warnings, formatting, and typo
Date: Tue, 4 Sep 2018 00:30:02 +0200 [thread overview]
Message-ID: <CAHc6FU6jzP5OwXPv18KJYt8jNCz_CJ_BPfTn8J5PqFFQjmh2Tw@mail.gmail.com> (raw)
In-Reply-To: <c7a6541c-53e9-f6bd-7589-11f089b57080@infradead.org>
On 3 September 2018 at 22:52, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warnings in fs/posic_acl.c.
> Also fix one typo (setgit -> setgid).
>
> ../fs/posix_acl.c:646: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode'
> ../fs/posix_acl.c:646: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode'
> ../fs/posix_acl.c:646: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode'
>
> Fixes: 073931017b49d ("posix_acl: Clear SGID bit when setting file permissions")
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andreas Gruenbacher <agruenba@redhat.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: linux-fsdevel@vger.kernel.org
> ---
> fs/posix_acl.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> --- lnx-419-rc2.orig/fs/posix_acl.c
> +++ lnx-419-rc2/fs/posix_acl.c
> @@ -630,12 +630,15 @@ EXPORT_SYMBOL_GPL(posix_acl_create);
>
> /**
> * posix_acl_update_mode - update mode in set_acl
> + * @inode: target inode
> + * @mode_p: mode (pointer) for update
> + * @acl: acl pointer
> *
> * Update the file mode when setting an ACL: compute the new file permission
> * bits based on the ACL. In addition, if the ACL is equivalent to the new
> - * file mode, set *acl to NULL to indicate that no ACL should be set.
> + * file mode, set ``*acl`` to NULL to indicate that no ACL should be set.
Should be turned into *@acl instead.
> *
> - * As with chmod, clear the setgit bit if the caller is not in the owning group
> + * As with chmod, clear the setgid bit if the caller is not in the owning group
> * or capable of CAP_FSETID (see inode_change_ok).
> *
> * Called from set_acl inode operations.
Otherwise,
Acked-by: Andreas Gruenbacher <agruenba@redhat.com>
Thanks,
Andreas
prev parent reply other threads:[~2018-09-04 2:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 20:52 [PATCH] fs/posix_acl.c: fix kernel-doc warnings, formatting, and typo Randy Dunlap
2018-09-03 22:30 ` Andreas Gruenbacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHc6FU6jzP5OwXPv18KJYt8jNCz_CJ_BPfTn8J5PqFFQjmh2Tw@mail.gmail.com \
--to=agruenba@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).