From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D39A6C43381 for ; Mon, 25 Feb 2019 19:54:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C22420C01 for ; Mon, 25 Feb 2019 19:54:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="F2Z1siwE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726833AbfBYTyN (ORCPT ); Mon, 25 Feb 2019 14:54:13 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:40286 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726692AbfBYTyM (ORCPT ); Mon, 25 Feb 2019 14:54:12 -0500 Received: by mail-lf1-f66.google.com with SMTP id a8so2037050lfi.7 for ; Mon, 25 Feb 2019 11:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NMjSLSh3kp6WB7h5Y9AuNjxZZ/9KcGlk9e4LZplkaBE=; b=F2Z1siwEJ5qc+oOUttqdscrbgsALxm3T8O/vOxq1if/vkdiJLNLY86YME4c917bI82 VuttugCNtmEi6CzrZCyPzZLzA/YktR8+oMz8EO3tK0dR1oz/n0g5BVMz298PkeUDRdxt hV4MfN7wOXi0TdMHZ+OTZiDno30IadTVuUOOI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NMjSLSh3kp6WB7h5Y9AuNjxZZ/9KcGlk9e4LZplkaBE=; b=dGbh4viZ1c6+3zgugNV+DnIMcfJXoA/C/Kr7K63YYXpDYdXbAHwMvTJIXAy2HLghBi 0/JO5pCdTsY/TxE3BS94YjF2JI64o49SthjML2t31FRFFOTCr4/QKd9lcFu3Pmr+I1rd ArFdAX4MU1K33DKueR8bgWLDF5oS6oOIqF0SfvtuPOF4Hz/VwXGW5m+UzudYpNk+fBb2 3YqN+ccQY8c7bnLICRGFCqHoP4rnp8QnoBhv2uw+K8TkesBtZBj5ISiA6eT2RNCrtVzE Xk9IwCBoRoGwHl7Iazd+FhHtvrIkgdF4r69hButWAOIs69ESOb2xb2E68R7okS17aTmD Xw1g== X-Gm-Message-State: AHQUAuZAh9PvQegYeF11O1k8IkDlacUm5HNXkKUzghWHpiGF9gUqk6l1 1VRxQwTlJx4xiW3zCyY7XAL0OBT+pfY= X-Google-Smtp-Source: AHgI3Ibx7jANNFCoQRUD0tK9afaHDT/LZzyMTaC0MQqBwbOX9q3Af9/hp63st5jvwXQI4Y2xFRj9KA== X-Received: by 2002:ac2:4317:: with SMTP id l23mr9726117lfh.98.1551124450244; Mon, 25 Feb 2019 11:54:10 -0800 (PST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id o12sm2459050ljc.37.2019.02.25.11.54.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:54:09 -0800 (PST) Received: by mail-lf1-f54.google.com with SMTP id m73so2267212lfa.2 for ; Mon, 25 Feb 2019 11:54:09 -0800 (PST) X-Received: by 2002:ac2:415a:: with SMTP id c26mr11947222lfi.62.1551124448787; Mon, 25 Feb 2019 11:54:08 -0800 (PST) MIME-Version: 1.0 References: <20190221222123.GC6474@magnolia> In-Reply-To: From: Linus Torvalds Date: Mon, 25 Feb 2019 11:53:52 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] tmpfs: fix uninitialized return value in shmem_link To: Hugh Dickins Cc: "Darrick J. Wong" , Andrew Morton , Matej Kupljen , Al Viro , Dan Carpenter , Linux List Kernel Mailing , linux-fsdevel , Linux-MM Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Feb 22, 2019 at 10:35 PM Hugh Dickins wrote: > > When we made the shmem_reserve_inode call in shmem_link conditional, we > forgot to update the declaration for ret so that it always has a known > value. Dan Carpenter pointed out this deficiency in the original patch. Applied. Side note: how come gcc didn't warn about this? Yes, we disable that warning for some cases because of lots of false positives, but I thought the *default* setup still had it. Is it just that the goto ends up confusing gcc enough that it never notices? Linus