From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kyle Evans <self@kyle-evans.net>,
Victor Stinner <victor.stinner@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Florian Weimer <fweimer@redhat.com>, Jann Horn <jannh@google.com>,
Oleg Nesterov <oleg@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Shuah Khan <shuah@kernel.org>,
David Howells <dhowells@redhat.com>,
"Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH v5 0/3] close_range()
Date: Wed, 3 Jun 2020 17:13:36 -0700 [thread overview]
Message-ID: <CAHk-=wgTpLOeMjpLOc8hY7KC6Qv+jR-hBacyBSajJ6iUKasmKA@mail.gmail.com> (raw)
In-Reply-To: <20200603232410.i3opsbmepv5ktsjq@wittgenstein>
On Wed, Jun 3, 2020 at 4:24 PM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
>
> Ok, here's what I have. Does the below look somewhat sane?
Probably. Needs lots of testing. But this one looks wrong:
> +int __close_range(unsigned fd, unsigned max_fd, unsigned int flags)
> {
> + if ((max_fd + 1) >= cur_max)
> + max_unshare_fds = fd;
A normal value for "close everything starting at X" would have a
max_fd value of ~0.
So "max_fd+1" would overflow to 0, and then this would never trigger.
Other than that it looks what what I imagine my feverdreams were about.
Linus
next prev parent reply other threads:[~2020-06-04 0:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 20:42 [PATCH v5 0/3] close_range() Christian Brauner
2020-06-02 20:42 ` [PATCH v5 1/3] open: add close_range() Christian Brauner
2020-06-02 23:30 ` Florian Weimer
2020-06-02 23:37 ` Christian Brauner
2020-06-03 10:24 ` Michael Kerrisk (man-pages)
2020-09-17 7:52 ` Michael Kerrisk (man-pages)
2020-06-05 14:55 ` Szabolcs Nagy
2020-06-06 2:54 ` Kyle Evans
2020-06-06 3:11 ` Kyle Evans
2020-06-06 11:55 ` Szabolcs Nagy
2020-06-06 14:43 ` Kyle Evans
2020-06-07 13:22 ` David Laight
2020-06-02 20:42 ` [PATCH v5 2/3] arch: wire-up close_range() Christian Brauner
2020-06-02 20:42 ` [PATCH v5 3/3] tests: add close_range() tests Christian Brauner
2020-06-02 21:03 ` [PATCH v5 0/3] close_range() Linus Torvalds
2020-06-02 23:33 ` Christian Brauner
2020-06-03 0:08 ` Linus Torvalds
2020-06-03 23:24 ` Christian Brauner
2020-06-04 0:13 ` Linus Torvalds [this message]
2020-06-04 1:15 ` Christian Brauner
2020-06-07 12:31 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgTpLOeMjpLOc8hY7KC6Qv+jR-hBacyBSajJ6iUKasmKA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian.brauner@ubuntu.com \
--cc=dhowells@redhat.com \
--cc=fweimer@redhat.com \
--cc=jannh@google.com \
--cc=ldv@altlinux.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=self@kyle-evans.net \
--cc=shuah@kernel.org \
--cc=victor.stinner@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).