From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Dave Chinner <david@fromorbit.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eric Sandeen <sandeen@sandeen.net>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [GIT PULL] xfs: new code for 5.8 (now with fixed To line)
Date: Tue, 2 Jun 2020 19:40:35 -0700 [thread overview]
Message-ID: <CAHk-=wgeiqB0TH_V2uTd2CX2hks+3TW344j73ftJFjqUteTxXA@mail.gmail.com> (raw)
In-Reply-To: <20200602162644.GE8204@magnolia>
On Tue, Jun 2, 2020 at 9:26 AM Darrick J. Wong <djwong@kernel.org> wrote:
>
> fs/xfs/xfs_log_recover.c | 2561 ++------------------
> 102 files changed, 4244 insertions(+), 4817 deletions(-)
Interestingly, the changes to that xfs_log_recover.c file really seem
to break the default git diff algorithm (the linear-space Myers'
algorithm)
The default settings give me
fs/xfs/xfs_log_recover.c | 2801 ++------------------
102 files changed, 4366 insertions(+), 4939 deletions(-)
which is not very close to yours. With the extra effort "--minimal" I get
fs/xfs/xfs_log_recover.c | 2561 ++------------------
102 files changed, 4246 insertions(+), 4819 deletions(-)
but based on your output, I suspect you used "--patience", which gives that
fs/xfs/xfs_log_recover.c | 2561 ++------------------
102 files changed, 4244 insertions(+), 4817 deletions(-)
output (the difference there wrt minimal came from
fs/xfs/libxfs/xfs_symlink_remote.c).
I'm used to seeing small differences in the line counts due to
different diff heuristics, but that 250 line difference for
"--patience" is more than you usually get.
None of this matters, and I'm not at all suggesting you change any of
your workflow.
I'm just commenting because I was going "why am I not getting a
matching diffstat", and while I'm used to seeing small differences
from diff algorithms, that 240 line-count change was really a lot more
than I normally encounter.
Linus
next prev parent reply other threads:[~2020-06-03 2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 16:26 [GIT PULL] xfs: new code for 5.8 (now with fixed To line) Darrick J. Wong
2020-06-03 2:40 ` Linus Torvalds [this message]
2020-06-13 5:35 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgeiqB0TH_V2uTd2CX2hks+3TW344j73ftJFjqUteTxXA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).