From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FADEC10F06 for ; Sat, 6 Apr 2019 17:07:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35D3821019 for ; Sat, 6 Apr 2019 17:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554570457; bh=ZlaaVv3mAmT2GvTkvz2F4Ex23rbjd1bqzns4MD2dloY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=TR9S4pPz7Fnkz2jAmj2h7JN7QI+di3Bipub7M0TprbApAYxZTi8DtFTqSvfV6bF5i sK23BBwxwz36oHvMyRA4i/hJ3jrv49OKul3opUQiTi71e+IOOSXmz5QKAiEMuvuQk8 74YHiG15g2cvOarwM0rfDDqspnWsRFW/kP9hcxr4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbfDFRHg (ORCPT ); Sat, 6 Apr 2019 13:07:36 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:33245 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbfDFRHg (ORCPT ); Sat, 6 Apr 2019 13:07:36 -0400 Received: by mail-lj1-f195.google.com with SMTP id f23so7833774ljc.0 for ; Sat, 06 Apr 2019 10:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5s2Te7Pue6wztZT4iXY+yWw3ozf3l4odun3S28KUUmw=; b=BuIcAAH6H0T2DUi2m/wYpUrIm8JGsbAfl0GdG/jhPsfZEB/fpHIM+DS6Rz/ajd6Aby sCf62QOQp0sofmZLhpWiNV6vTJzeNQX3y97t/o6j4oXpTh0fRPfRKPP5LP7sHonbnP/r tJrWGnouWfjOy7cSJU1DQ3ux1l/wyhJo1jy2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5s2Te7Pue6wztZT4iXY+yWw3ozf3l4odun3S28KUUmw=; b=M5a1uBnf2KRovA9XvHSiz3loO/Jrt+sLkH6Uzy0j6dwb6Bf0/k+nseKbCu5GqZAcNn 1W2Kkn2oR6rk1cmNWVzKwmQVwxmqyq/P/m5yjXjE5sEo0deVWcaRfWUascO7D86YHf+F +CooOnqqvD8QQDeHiC438M1L4gPSrzS8rN/MbT6/X8M4EaC/zjNtFfOegaIZ9jWc3bph 8n8/ap610jxVA9qoIggrcSvkqcEBCRvBP5qH1pSLrrxJ9Hsjj1X55q8JSo5aIDK/2XKg OZdAzdjxP+tkCQnu4cle2v0bHLYjlpUxAsKfEFYpvs76I0jtWL7sPPRvk9WKAaHKI9JU SsFQ== X-Gm-Message-State: APjAAAWLPREZhmXeA4lbYVt1Mk0nC5o4jAnXAX33MAY7PFZNeXE4r8LO C60S9y+bBo6V04GBPl8DIdJHU2vyFis= X-Google-Smtp-Source: APXvYqwUuIRNmPZx0tENoYi5CQkEhPIjn/GNRXOl/83oSjcTOhWqcQ9/po8MQBA7HawGNvUv4kmEvQ== X-Received: by 2002:a2e:8582:: with SMTP id b2mr10542642lji.24.1554570452682; Sat, 06 Apr 2019 10:07:32 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id 13sm5102541lfy.2.2019.04.06.10.07.30 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Apr 2019 10:07:31 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id v13so7783608ljk.4 for ; Sat, 06 Apr 2019 10:07:30 -0700 (PDT) X-Received: by 2002:a2e:90c9:: with SMTP id o9mr11147407ljg.102.1554570450612; Sat, 06 Apr 2019 10:07:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Sat, 6 Apr 2019 07:07:14 -1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock To: Kirill Smelkov Cc: Al Viro , linux-fsdevel , Linux List Kernel Mailing , Michael Kerrisk , Yongzhi Pan , Jonathan Corbet , David Vrabel , Juergen Gross , Miklos Szeredi , Tejun Heo , Kirill Tkhai , Arnd Bergmann , Christoph Hellwig , Greg Kroah-Hartman , Julia Lawall , Nikolaus Rath , Han-Wen Nienhuys Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Mar 26, 2019 at 12:20 PM Kirill Smelkov wrote: > > Commit 9c225f2655 (vfs: atomic f_pos accesses as per POSIX) added locking for > file.f_pos access and in particular made concurrent read and write not possible > [...] Ok, I have applied this patch - but this patch only - as a well-researched preparatory patch. The actual conversion patch looks fine to me too, and I see a few acks, but I think I'd like to see it during a merge window just because it's large and does significant changes, while this one is purely preparatory. Al, comments? One small note: please don't use lkml.org references since they tend to be slow and flaky - use lore.kernel.org instead. Also, fix your git config to use 12-character git hashes (best done by just removing the explicit hash size entirely, and letting modern git shorten hashes appropriately automatically). Linus