From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E30CC433DB for ; Mon, 15 Feb 2021 01:13:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EF5A64E52 for ; Mon, 15 Feb 2021 01:13:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229993AbhBOBIt (ORCPT ); Sun, 14 Feb 2021 20:08:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229818AbhBOBIr (ORCPT ); Sun, 14 Feb 2021 20:08:47 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCA39C061574 for ; Sun, 14 Feb 2021 17:08:06 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id f14so8604953ejc.8 for ; Sun, 14 Feb 2021 17:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8oLEqXUvdqy1QH/cRggvF58640ngzAUjBT8Tfk3Wjwg=; b=eb+VDAyVwB6RZ6vXNDSIXjjY5/KGJonBZpcw4InpSNpoqcKC9wCYBknhMsgf9sPklg GzCvnbIRKgTg7gtA7teRfKAGGFk9BR9qw3HHsG7GJ3+trFjsmHXqEUXRQMhyaGXIHFPG +BYG0bBsO6r2Y7DOTssLQQLnPqsDN5e1ysQAo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8oLEqXUvdqy1QH/cRggvF58640ngzAUjBT8Tfk3Wjwg=; b=CjiKd77rJQsvVgQP+Xz8oYr02TDvrllwSllev/H4qccKxMz08DzdaaNLYdfe3M8fpr K/NoBKGPZswPExURFlt9xZT6YuPZ3vniOM+mL8it3Cl2tW+YYjzBLr7aE7xklX9TqECI MtyT5mj6bvHGru77vNjbgeg/EvAwJS3s6oeQrxSZZFzOZ6DXRKu+mfQFzB3wPtaBMN80 Edyob9yur2dPyXigtD5Gds6t2B69hOZSUvuSUkITgHHWXVslypOn9prTrOdbHyRYQBz0 ZX9CJew+VYALUXGciwb3zbWVD0iiqSSTZJn+fQPztkkHEPDRQ1hbxYLPYX1hZ7TkxSSX i1BA== X-Gm-Message-State: AOAM533QNPz+w9GdYX3YffQZSwBOQYxh50B5xj2eI+upUTGGCDvGkQEo GG7Hj+j1Ilbi2HwfnXcR9U1fbWUpKBNUHQ== X-Google-Smtp-Source: ABdhPJyEZmBQX1tSUDTlNo9OV43s5jhWeqIfV6gUnrhcUf8UMsou8vh13mO1escMABFjrBUIbvcbXg== X-Received: by 2002:a17:906:c0c9:: with SMTP id bn9mr13530002ejb.318.1613351285218; Sun, 14 Feb 2021 17:08:05 -0800 (PST) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com. [209.85.208.46]) by smtp.gmail.com with ESMTPSA id v20sm9131429edt.3.2021.02.14.17.08.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Feb 2021 17:08:05 -0800 (PST) Received: by mail-ed1-f46.google.com with SMTP id h10so1554528edl.6 for ; Sun, 14 Feb 2021 17:08:04 -0800 (PST) X-Received: by 2002:a05:651c:112:: with SMTP id a18mr8181174ljb.465.1613350911576; Sun, 14 Feb 2021 17:01:51 -0800 (PST) MIME-Version: 1.0 References: <591237.1612886997@warthog.procyon.org.uk> <1330473.1612974547@warthog.procyon.org.uk> <1330751.1612974783@warthog.procyon.org.uk> <27816.1613085646@warthog.procyon.org.uk> <860729.1613348577@warthog.procyon.org.uk> In-Reply-To: <860729.1613348577@warthog.procyon.org.uk> From: Linus Torvalds Date: Sun, 14 Feb 2021 17:01:35 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] fscache: I/O API modernisation and netfs helper library To: David Howells Cc: Matthew Wilcox , Jeff Layton , David Wysochanski , Anna Schumaker , Trond Myklebust , Steve French , Dominique Martinet , Alexander Viro , ceph-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cachefs@redhat.com, CIFS , linux-fsdevel , "open list:NFS, SUNRPC, AND..." , v9fs-developer@lists.sourceforge.net, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, Feb 14, 2021 at 4:23 PM David Howells wrote: > > Anyway, I have posted my fscache modernisation patches multiple times for > public review, I have tried to involve the wider community in aspects of the > development on public mailing lists and I have been including the maintainers > in to/cc. So then add those links and the cc's to the commit logs, so that I can *see* them. I'm done with this discussion. If I see a pull request from you, I DO NOT WANT TO HAVE TO HAVE A WEEK-LONG EMAIL THREAD ABOUT HOW I CANNOT SEE THAT IT HAS EVER SEEN ANY REVIEW. So if all I see is "Signed-off-by:" from you, I will promptly throw that pull request into the garbage, because it's just not worth my time to try to have to get you kicking and screaming to show that others have been involved. Can you not understand that? When I get that pull request, I need to see that yes, this has been reviewed, people have been involved, and yes, it's been in linux-next. I want to see "reviewed-by" and "tested-by", I want to see "cc", and I want to see links to submission threads with discussion showing that others actually were involved. I do *not* want to see just a single signed-off-by line from you, and then have to ask for "has anybody else actually seen this and reviewed it". Look, here's an entirely unrelated example from a single fairly recent trivial one-liner memory leak fix: Fixes: 87c715dcde63 ("scsi: scsi_debug: Add per_host_store option") Link: https://lore.kernel.org/r/20210208111734.34034-1-mlombard@redhat.com Acked-by: Douglas Gilbert Signed-off-by: Maurizio Lombardi Signed-off-by: Martin K. Petersen that's from a quite a trivial commit. Yes, it's trivial, but it could still be wrong, of course. And if somebody ever reports that it causes problems despite how simple it was, look at what I have: I have three people to contact, and I have a pointer to the actual original submission of the patch. Do we have that for all our commits? No. But it's also not at all unusual any more, and in fact many commits have even more, with testing etc. And yes, sometimes the test results and acks come back later after you've already pushed the changes out etc, and no, it's generally not worth rebasing for that - maybe others have now started to rely on whatever public branch you have. Which is why the "Link:" is useful, so that if things come in later, the discussion can still be found. But quite often, you shouldn't have pushed out some final branch before you've gotten at least *some* positive response from people, so I do kind of expect some "Acked-by" etc in the commit itself. THAT is what you need to aim for. And yes, I'm picking on you. Because we've had this problem before. I've complained when you've sent me pull requests that don't even build, that you in fact had been told by linux-next didn't build, and you still sent them to me. And as a result, I've asked for more involvement from other people before. So now I'm clarifying that requirement - I absolutely need to see that it has actually seen testing, that it has seen other people being involved, and that it isn't just you throwing spaghetti at the wall to see what sticks. And I'm not going to do that for every pull request. I want to see that data *in* the pull request itself. Linus