From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8A5C10DCE for ; Sat, 14 Mar 2020 00:28:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3202B2074C for ; Sat, 14 Mar 2020 00:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584145713; bh=aEyIah5anxqxw7dr2IcrDi3LMEkx1zYZ239mnRvw7qU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=rWTmIgRaHenK8hEyge6o3N4s9p9fomcyLFfjWgTrj8opMHD6fkD4ErWB8QNvJOsdX 3HUkHgd1vjQGSRG6pKz+BzQLAzU2w+wyP0Drr+tE2BWeFyn7FioWkmLH4nzzlHeYE9 bafFEjGvYnE7n9QiM9ym2LxqBKk3eT74kOQoTbhk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727743AbgCNA2c (ORCPT ); Fri, 13 Mar 2020 20:28:32 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:44505 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727629AbgCNA2c (ORCPT ); Fri, 13 Mar 2020 20:28:32 -0400 Received: by mail-lf1-f65.google.com with SMTP id b186so9223819lfg.11 for ; Fri, 13 Mar 2020 17:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pRmNolcxLqc+tNnnflJ/n3joETbYpRnOE13OAQ+0j2c=; b=cRJcS5iL6D7pulFWso9kzk1dWyABFXOyNGG88VjNsF84X0gt+v0c11QVPFVDYWRXf8 CSOkNeWYjeGmaUh0kvfgC6E3MPHJd255SwAfMJz6MgK/ZxktMeYvYYYvDiu8QvNb7sTV +GznvZmF4/9MkIGyzdbamSO0U+8fhQMTk7x0I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pRmNolcxLqc+tNnnflJ/n3joETbYpRnOE13OAQ+0j2c=; b=GGj9aiXyimAezzpcYCoWMioz1rkXbGVK3wyacyI25yeBn2WFjelxfaTWzWvfVW5TKM b/EXLsQWHBlbm4nVT52dNn7kIaSXlAL9Fm5c7FEqj8cQv66X8HUcYO0qql9jHbuok5x1 JbeaXwrUQXtZC4A+iZHhpOlVQkhTPhB+3r2pOCjlt6+D/+aioznzE1AMapuvkMBbGmHo uoiBSfLvzH0jV+7FcphX8IWmF7bymkTvHTR+Y2+zDQnS1gVcmXNLz/GMrV29Vc1VvNmN 4w3UwgAEf/QJZvNafIvF6FAvPI6eXHIY8pz1Gx/JEW/v3OEOqzya+AVCePxvJJL31OMw Tcug== X-Gm-Message-State: ANhLgQ0sny+bT8qocjE4NRl3YThsR05Q+lZYC6Wix28iIOPJyKgw188i 5kq5uR9FZr0Q7iB/V3rErwO+lgRZqvY= X-Google-Smtp-Source: ADFU+vvpqWRCx8eMLUFLzKNbTHcTqcoUzoEhh49aXi9KD/0WVH9MVsjri8mLXAqJKxkddprN+xhJMw== X-Received: by 2002:a05:6512:2018:: with SMTP id a24mr5297133lfb.175.1584145709184; Fri, 13 Mar 2020 17:28:29 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id w14sm28054357ljo.80.2020.03.13.17.28.28 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2020 17:28:28 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id r9so3815586lff.13 for ; Fri, 13 Mar 2020 17:28:28 -0700 (PDT) X-Received: by 2002:a05:6512:3044:: with SMTP id b4mr1855996lfb.10.1584145708028; Fri, 13 Mar 2020 17:28:28 -0700 (PDT) MIME-Version: 1.0 References: <20200313235303.GP23230@ZenIV.linux.org.uk> <20200313235357.2646756-1-viro@ZenIV.linux.org.uk> <20200313235357.2646756-12-viro@ZenIV.linux.org.uk> In-Reply-To: <20200313235357.2646756-12-viro@ZenIV.linux.org.uk> From: Linus Torvalds Date: Fri, 13 Mar 2020 17:28:12 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC][PATCH v4 12/69] teach handle_mounts() to handle RCU mode To: Al Viro Cc: linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Oh, and here you accidentally fix the problem I pointed out about patch 11, as you move the code: On Fri, Mar 13, 2020 at 4:54 PM Al Viro wrote: > > + if (unlikely(!*inode)) > + return -ENOENT; Correct test added. > - if (unlikely(!inode)) > - return -ENOENT; Incorrect test removed. And again, maybe I'm misreading the patch. But it does look like it's wrong in the middle of the series, which would make bisection if there's some related bug "interesting". Linus