From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8096CC43331 for ; Tue, 12 Nov 2019 17:37:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 531FA21872 for ; Tue, 12 Nov 2019 17:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573580222; bh=2yd10KHYTLI5s6gMxqmI4NvWYQwboiddj2FXrknzmy8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=g5qhSQbSaF25LpmkZS36wCWmnOJozCQIeYizcASim/8lauEQWZHDC9cDouWXB2TyA fEWWPqr3PSBPDiR9QTarNCrfdNRCOFXCfCJWQsXfYXQ0Q6r7MzSm6sCtnkkJ0Fjojh Wc0wGtT0fF+PePCveECbYnpgcoI9CTmYedTOAcrM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfKLRhB (ORCPT ); Tue, 12 Nov 2019 12:37:01 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:41361 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726912AbfKLRhB (ORCPT ); Tue, 12 Nov 2019 12:37:01 -0500 Received: by mail-lj1-f193.google.com with SMTP id d22so7236471lji.8 for ; Tue, 12 Nov 2019 09:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IBqefimeVs+AYlMba+nG3Ifymts3na+gdpNY2rCXiUk=; b=diHQe+yBS1ptQml1pfafp+kWY2eFlTIw5aehrJHkBhZ8198TLnziuPuv+aWPbMESa4 ZLgW0hXjhFPDrgdFG9RXdXxqYD1Ejn46fc1vZ1auR9hlb58u47fldPax7D6iEk6grtjo EpEWHP7zBGk+CKduo6ZBne9+0TPwuTpetW/Ec= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IBqefimeVs+AYlMba+nG3Ifymts3na+gdpNY2rCXiUk=; b=tCYBCj7moi1n9Ge4ZHN0obe2TwDj4SGDBJpLtAt6APRUFWOhUn2QwWkV6SxiZ0b0Fk 5dDu1VdWRDyTAXe6in8nGVpzl/rffp2ALpaECIUbn/J/rOMekvjUmEpgBwl5OXHJyx/z b7g2qy1cCnk+a2mNzcaIihJcWj1ki2ZPHjEQlKbJoeYMga0s4BvAqnKnn6OyW6fiRGtd jhOY3lSJ0wDix+Zkvz+3RaqsZvxYA4o62gPljBVVkKC2kJoEeA2v2xfarK7U6k6/q+sz mMnqdIVomcKvm7DU3c4/pMi00wSml/+NxLgEzLGYGgp0mxcxSUFVTlGBDfRcRNRNaEX4 jLmg== X-Gm-Message-State: APjAAAW6ZOR87R9Svd7EqyByfGuIZGvgdSNZswDVVMDUKaBnerA5jWUf mgdWnGeo7veoAUI8xyzeIsLk9m5jdMY= X-Google-Smtp-Source: APXvYqwn85KBG6AK5mOvAl8R7KBlfznTqvR6V9kism2avQXy92rsX/SdySpppXfSwpkDLnChoQ6IDg== X-Received: by 2002:a2e:88c9:: with SMTP id a9mr19008054ljk.30.1573580219063; Tue, 12 Nov 2019 09:36:59 -0800 (PST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id v6sm10294529ljd.15.2019.11.12.09.36.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2019 09:36:57 -0800 (PST) Received: by mail-lf1-f52.google.com with SMTP id q5so7520092lfo.10 for ; Tue, 12 Nov 2019 09:36:57 -0800 (PST) X-Received: by 2002:ac2:4c86:: with SMTP id d6mr20463115lfl.106.1573580217235; Tue, 12 Nov 2019 09:36:57 -0800 (PST) MIME-Version: 1.0 References: <20191112165033.GA7905@deco.navytux.spb.ru> In-Reply-To: From: Linus Torvalds Date: Tue, 12 Nov 2019 09:36:41 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: KCSAN: data-race in __alloc_file / __alloc_file To: Kirill Smelkov Cc: Eric Dumazet , Al Viro , Alan Stern , Marco Elver , Eric Dumazet , syzbot , linux-fsdevel , Linux Kernel Mailing List , syzkaller-bugs , Andrea Parri , "Paul E. McKenney" , LKMM Maintainers -- Akira Yokosawa Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Nov 12, 2019 at 9:23 AM Linus Torvalds wrote: > > Hmm. I thought we already then applied all the patches that marked > things that didn't use f_pos as FMODE_STREAM. Including pipes and > sockets etc. > > But if we didn't - and no, I didn't double-check now either - then > obviously that part of the patch can't be applied now. Ok, looking at it now. Yeah, commit c5bf68fe0c86 ("*: convert stream-like files from nonseekable_open -> stream_open") did the scripted thing, but it only did it for nonseekable_open, not for the more complicated cases. So yup, you're right - we'd need to at least do the pipe/socket case too. What happens if the actual conversion part (nonseekable_open -> stream_open) is removed from the cocci script, and it's used to only find "read/write doesn't use f_pos" cases? Or maybe trigger on '.llseek = no_llseek'? Linus