From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-afs@lists.infradead.org,
Marc Dionne <marc.dionne@auristor.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] afs: Re-enable freezing once a page fault is interrupted
Date: Fri, 18 Jun 2021 13:52:42 -0700 [thread overview]
Message-ID: <CAHk-=whRiXMUEtyeHVCT7hp0ZZV-VLAG00Osw6qbUEyi7sWpuw@mail.gmail.com> (raw)
In-Reply-To: <162387854886.1035841.15139736369962171742.stgit@warthog.procyon.org.uk>
On Wed, Jun 16, 2021 at 2:22 PM David Howells <dhowells@redhat.com> wrote:
>
> If a task is killed during a page fault, it does not currently call
> sb_end_pagefault(), which means that the filesystem cannot be frozen
> at any time thereafter. This may be reported by lockdep like this:
I've applied this patch.
Everything in my screams "the sb_start/end_pagefault() code is
completely broken", but in the meantime this patch fixes the immediate
bug.
I suspect that the whole sb_start/end_pagefault thing should just go
away entirely, and the freezer should be re-examined. Alternatively,
it should just be done by generic code, not by the filesystem.
But it is what it is.
Linus
next prev parent reply other threads:[~2021-06-18 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 21:22 [PATCH] afs: Re-enable freezing once a page fault is interrupted David Howells
2021-06-18 20:52 ` Linus Torvalds [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-06-16 15:49 Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whRiXMUEtyeHVCT7hp0ZZV-VLAG00Osw6qbUEyi7sWpuw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).