archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <>
To: David Howells <>
Cc: "Matthew Wilcox (Oracle)" <>,,
	Marc Dionne <>,
	linux-fsdevel <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH] afs: Re-enable freezing once a page fault is interrupted
Date: Fri, 18 Jun 2021 13:52:42 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Jun 16, 2021 at 2:22 PM David Howells <> wrote:
> If a task is killed during a page fault, it does not currently call
> sb_end_pagefault(), which means that the filesystem cannot be frozen
> at any time thereafter.  This may be reported by lockdep like this:

I've applied this patch.

Everything in my screams "the sb_start/end_pagefault() code is
completely broken", but in the meantime this patch fixes the immediate

I suspect that the whole sb_start/end_pagefault thing should just go
away entirely, and the freezer should be re-examined. Alternatively,
it should just be done by generic code, not by the filesystem.

But it is what it is.


  reply	other threads:[~2021-06-18 20:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 21:22 [PATCH] afs: Re-enable freezing once a page fault is interrupted David Howells
2021-06-18 20:52 ` Linus Torvalds [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-06-16 15:49 Matthew Wilcox (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).