From: Linus Torvalds <torvalds@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: Colin Ian King <colin.king@canonical.com>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Johannes Berg <johannes@sipsolutions.net>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: splice() from /dev/zero to a pipe does not work (5.9+)
Date: Fri, 7 May 2021 12:06:31 -0700 [thread overview]
Message-ID: <CAHk-=whVMtMPRMMX9W_B7JhVTyRzVoH71Xw8TbtYjThaoCzJ=A@mail.gmail.com> (raw)
In-Reply-To: <202105071116.638258236E@keescook>
On Fri, May 7, 2021 at 11:21 AM Kees Cook <keescook@chromium.org> wrote:
>
> So the question is likely, "do we want this for /dev/zero?"
Well, /dev/zero should at least be safe, and I guess it's actually
interesting from a performance testing standpoint (ie useful for some
kind of "what is the overhead of the splice code with no data copy").
So I'll happily take a sane patch for /dev/zero, although I think it
probably only makes sense if it's made to use the zero page explicitly
(ie exactly for that "no data copy testing" case).
So very much *not* using generic_file_splice_read(), even if that
might be the one-liner.
/dev/zero should probably also use the (already existing)
splice_write_null() function for the .splice_write case.
Anybody willing to look into this? My gu feel is that it *should* be easy to do.
That said - looking at the current 'pipe_zero()', it uses
'push_pipe()' to actually allocation regular pages, and then clear
them.
Which is basically what a generic_file_splice_read() would do, and it
feels incredibly pointless and stupid to me.
I *think* we should be able to just do something like
len = size;
while (len > 0) {
struct pipe_buffer *buf;
unsigned int tail = pipe->tail;
unsigned int head = pipe->head;
unsigned int mask = pipe->ring_size - 1;
if (pipe_full(head, tail, pipe->max_usage))
break;
buf = &pipe->bufs[iter_head & p_mask];
buf->ops = &zero_pipe_buf_ops;
buf->page = ZERO_PAGE(0);
buf->offset = 0;
buf->len = min_t(ssize_t, len, PAGE_SIZE);
len -= buf->len;
pipe->head = head+1;
}
return size - len;
but honestly, I haven't thought a lot about it.
Al? This is another of those "right up your alley" things.
Maybe it's not worth it, and just using generic_file_splice_read() is
the way to go, but I do get the feeling that if we are splicing
/dev/null, the whole _point_ of it is about benchmarking, not "make it
work".
Linus
next prev parent reply other threads:[~2021-05-07 19:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 18:05 splice() from /dev/zero to a pipe does not work (5.9+) Colin Ian King
2021-05-07 18:21 ` Kees Cook
2021-05-07 19:06 ` Linus Torvalds [this message]
2021-05-07 19:17 ` Al Viro
2021-05-07 19:29 ` Linus Torvalds
2021-05-07 20:31 ` Al Viro
2021-05-12 15:13 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=whVMtMPRMMX9W_B7JhVTyRzVoH71Xw8TbtYjThaoCzJ=A@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=hch@lst.de \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).