From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD94CC43331 for ; Sat, 7 Sep 2019 17:46:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A59CB2173B for ; Sat, 7 Sep 2019 17:46:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567878360; bh=msHmPyEJDzQFsZmLPdWi5gjJmS+VqKjbTg7O/MhE5Lo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=vtUCBK9PLMk0LIaGdTA+wGWnKdFKT9M0DYocFv3QWLVWzxvlSdYVnL/MWmj/if9HQ UKBKq+TiyaYQMfGAXhkfpnrdktApXBqq+kohFjDqffNLNaVLBHPNalMGHJYdEMLjIV EN+71rkKKElT5KaIPp8iqqhELLBpOwmFjsBuxx5o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392280AbfIGRp4 (ORCPT ); Sat, 7 Sep 2019 13:45:56 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:33538 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbfIGRp4 (ORCPT ); Sat, 7 Sep 2019 13:45:56 -0400 Received: by mail-lf1-f66.google.com with SMTP id d10so7504153lfi.0 for ; Sat, 07 Sep 2019 10:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JJRFoANDdA7LVjR/dXOt13NCYJCwAkkvMBjFRYL2CJk=; b=O0k0d7lqzfAmPEYFzDlOGgQsR12LVtrvxo5oTKj/qTWwdx05EQgXW+UipRXAFcHY7l NJSN5sB8Bd0GzZnsutsLrlnHa03N+sVzppgC400AeuuF3leAik8ua94YYTL1N/jeDSEY p0NLqzIjW/MddvLJPDdxPws4zfzc5nCUgJ+sc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JJRFoANDdA7LVjR/dXOt13NCYJCwAkkvMBjFRYL2CJk=; b=ZL26QJJA1NgQfGTRe4mPGcK3Y7doeqH7L/jcdaN+sgZukGoU4XgfX3Y5dLwux7n71h KWRLfMkDfYT/4gl0NyQoa7L4SaT2H5EubQZVza9e3h2iBNT8SiRz+5XUlN/LvU8lHQX0 wtaAvw5FCEl0L80Fnh+8LkoXw9YviA5mFl5OGXpYoyzupdJUc5boQ+FlykFXnd0vTgFk I0EBik3RWA/6+v42Cv/UsUKw4XpjTuNp77XzybKklfljyQiLIaCiq9dkdI1dJXSDp3Nc CoG08+WBhO0ROWyldBDB3MVd4R8JM+3QkRECvhzfzMM3oBOQ1n44fIIZ59qYPF5U8R7D kYfQ== X-Gm-Message-State: APjAAAWaIwnbHNDgT01vpaeO6gFEPPuq2tXAEnX9vVrFZfsrBM4WkLLl AJlvo55OIdm3qYbRHeJjkSoeWV7Pd8A= X-Google-Smtp-Source: APXvYqzgUB4ZjNVZeRU0i97FXkp835LqIpzr7Aoph5D2FpDV5blhsrfV+XbhmhNG6gpp+JiwbEEokA== X-Received: by 2002:a19:9145:: with SMTP id y5mr10681608lfj.88.1567878353605; Sat, 07 Sep 2019 10:45:53 -0700 (PDT) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com. [209.85.208.172]) by smtp.gmail.com with ESMTPSA id k25sm500936ljk.42.2019.09.07.10.45.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Sep 2019 10:45:52 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id u14so8874831ljj.11 for ; Sat, 07 Sep 2019 10:45:51 -0700 (PDT) X-Received: by 2002:a2e:8645:: with SMTP id i5mr9691835ljj.165.1567878349245; Sat, 07 Sep 2019 10:45:49 -0700 (PDT) MIME-Version: 1.0 References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-12-cyphar@cyphar.com> <7236f382d72130f2afbbe8940e72cc67e5c6dce0.camel@kernel.org> In-Reply-To: From: Linus Torvalds Date: Sat, 7 Sep 2019 10:45:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 11/12] open: openat2(2) syscall To: Andy Lutomirski Cc: Jeff Layton , Aleksa Sarai , Al Viro , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan , Ingo Molnar , Peter Zijlstra , Christian Brauner , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Kees Cook , Jann Horn , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Rasmus Villemoes , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Aleksa Sarai , Linux Containers , alpha , Linux API , linux-arch , Linux ARM , linux-fsdevel , linux-ia64@vger.kernel.org, Linux List Kernel Mailing , "open list:KERNEL SELFTEST FRAMEWORK" , linux-m68k , linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390 , Linux-sh list , linux-xtensa@linux-xtensa.org, sparclinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Sep 7, 2019 at 10:42 AM Andy Lutomirski wrote: > > Linus, you rejected resolveat() because you wanted a *nice* API No. I rejected resoveat() because it was a completely broken garbage API that couldn't do even basic stuff right (like O_CREAT). We have a ton of flag space in the new openat2() model, we might as well leave the old flags alone that people are (a) used to and (b) we have code to support _anyway_. Making up a new flag namespace is only going to cause us - and users - more work, and more confusion. For no actual advantage. It's not going to be "cleaner". It's just going to be worse. Linus