From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E156AC3A5A9 for ; Wed, 4 Sep 2019 20:54:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5BA721883 for ; Wed, 4 Sep 2019 20:54:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567630463; bh=VjRAUyhPNYqPG6iYr3ZZTt5fRZBunJt5oojJZz4GH54=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QRRGbQgp4H98UxM1VLS+ECogWEfXOzWDxzBKe2NgiG6BYH6v1epL+7dYHMExChhZo EwYSLjMBz0X+V3RWf4594UnKYFckPsYd9XnDobg7ZbA+Ydsc6vIqh/A0xVn8iJwr/0 e6cIlgrVbZ8bgJ372Jhy14A4d7WzleE9A84Ga0p8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727900AbfIDUyX (ORCPT ); Wed, 4 Sep 2019 16:54:23 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:46763 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726495AbfIDUyX (ORCPT ); Wed, 4 Sep 2019 16:54:23 -0400 Received: by mail-lf1-f67.google.com with SMTP id t8so89424lfc.13 for ; Wed, 04 Sep 2019 13:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YRdCAVRAhTdLrO2mQDquZKKD1XyXDQFQecwZBQrW2l0=; b=Ze7jrxDdyMP3SGOIesp7e7J/31BijZsyDh1sIQ7zUiaQzSssRLwu0Ke8i7Ma6J1ANp +Y5ZM0aEii6+0RhihFBDvVJHDKpgy6odNUVXcrGCLgyyDaE911gL75i/CI9XscaVSNbQ F9aqFQyEV98rhO6Nc66q5tz/D9khPZIijk1p4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YRdCAVRAhTdLrO2mQDquZKKD1XyXDQFQecwZBQrW2l0=; b=pogXRTWl4HjgXPodeBjsyaeCniXpdxTkBBaW8oNX3/kzGO16FQ9LI3wtkHGhkq75hL ZgyHRa+Kkn35TtuPgYC2q+QR5lmoi5bOaeaALxB0f7hCXspOgyT0pFhwd4Arr6YnKYnk 9zisWoVUgBWfeKoDf/2o1CyjSxsBKs0N34+6z3nYCjxn6RsPT3Gd2mbJScYH5vikXM0b sznJ0NkP2kvsmpVEtzBjLRTlmuOYd3ZrtnGvcCn32u0bATJP70r7ffwZkGQTH0ip4t6Q niYLDDekk8yeAbsvgamASBiGkCALj3K7o+cp+6DQlGW7GnoOffHEAjTQbB5x4FWwy1Zs K8ew== X-Gm-Message-State: APjAAAW20rt5xXsKqXLWJNXzqd71u9qbyweaA0hjOQ/FYO6CZzHCQ8iW PlRq/IbVMBjoJX9PeXW/ZKnS465AvtE= X-Google-Smtp-Source: APXvYqzSHpf3T7meF7s3venTSAGHttC6aWiGVPKOplvna11Aanlw3WxhbVCuuc4mOvnLi8GMAn+osw== X-Received: by 2002:a19:6d02:: with SMTP id i2mr42352lfc.191.1567630460400; Wed, 04 Sep 2019 13:54:20 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id o2sm2173800lfl.20.2019.09.04.13.54.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2019 13:54:20 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id j4so111377lfh.8 for ; Wed, 04 Sep 2019 13:54:20 -0700 (PDT) X-Received: by 2002:a19:f204:: with SMTP id q4mr52203lfh.29.1567630138756; Wed, 04 Sep 2019 13:48:58 -0700 (PDT) MIME-Version: 1.0 References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-2-cyphar@cyphar.com> In-Reply-To: <20190904201933.10736-2-cyphar@cyphar.com> From: Linus Torvalds Date: Wed, 4 Sep 2019 13:48:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v12 01/12] lib: introduce copy_struct_{to,from}_user helpers To: Aleksa Sarai Cc: Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan , Ingo Molnar , Peter Zijlstra , Christian Brauner , Rasmus Villemoes , Eric Biederman , Andy Lutomirski , Andrew Morton , Alexei Starovoitov , Kees Cook , Jann Horn , Tycho Andersen , David Drysdale , Chanho Min , Oleg Nesterov , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Aleksa Sarai , Linux Containers , alpha , Linux API , linux-arch , Linux ARM , linux-fsdevel , linux-ia64@vger.kernel.org, Linux List Kernel Mailing , "open list:KERNEL SELFTEST FRAMEWORK" , linux-m68k , linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390 , Linux-sh list , linux-xtensa@linux-xtensa.org, sparclinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Sep 4, 2019 at 1:20 PM Aleksa Sarai wrote: > > A common pattern for syscall extensions is increasing the size of a > struct passed from userspace, such that the zero-value of the new fields > result in the old kernel behaviour (allowing for a mix of userspace and > kernel vintages to operate on one another in most cases). Ack, this makes the whole series (and a few unrelated system calls) cleaner. Linus