From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A452BC63699 for ; Thu, 12 Nov 2020 01:51:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48E03205ED for ; Thu, 12 Nov 2020 01:51:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="IRSGHIcC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728324AbgKLBcO (ORCPT ); Wed, 11 Nov 2020 20:32:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727136AbgKKWqp (ORCPT ); Wed, 11 Nov 2020 17:46:45 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09B0BC0617A6 for ; Wed, 11 Nov 2020 14:27:21 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id l10so3862906lji.4 for ; Wed, 11 Nov 2020 14:27:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wLOabNKoNSfJ8YlJALUX/HSF7x5smlTVZLW77pgDXxE=; b=IRSGHIcCR371rgKVLVF0IWNeekp7RPE0tq0jXgz/fCbjpYkabNrYN8yq8L6uP1wNLm iQV9DdRexGpEEOJh3X5FNLU9tmqj7DBi9Jq9H9z+BIkxguhTupVA5zY3gmTZBfYvUSdr RBkqVcAV8M5WnEewVOMQWCUC58Swu7KJUcmrU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wLOabNKoNSfJ8YlJALUX/HSF7x5smlTVZLW77pgDXxE=; b=UQrX3aGg6U4qzdYKgZKhMcTLbBFszeja3sCnf298RJGqwSm9eHqeuzDJuE64StCQsJ EXKBgdgNBQItyPCle3abdfThnhUem04c3Lt8g/mIbtCDxr4gzGHg28I0LEgF84vZsknG YlAnKziETxhxgpjoytxWu5ZplI1L5EH30FqK67sfGzvRLZG5Egm7ItDLRFmOrXb4k/ys +swp8wkwwJrZIsUS0lcKGErK83z3uGBStyFzn9U89p/GuuJC+ZZXOHKSDhBgUHnbxU0X oCPcgQ67rFsHzhh3z1nGRCSzlEerPhft7n/KDi7bsY3Uz/oAUtSqM3wHdRlFSylY9Q/L oxjQ== X-Gm-Message-State: AOAM531F8hDhRwAYc5GkbpJdLbUe51v1ssh5mZPYNuv+ej17FWy8chiB IoHzQle3p6a3qTD/MhOKX8gaP02jrEpBPg== X-Google-Smtp-Source: ABdhPJxyqc6CBOnSgzDjLRngGcWWnvl4jW32MKEORmxgSG+6YFf6kvRDEWsreKkjQrIupaDDliuDpg== X-Received: by 2002:a2e:a17c:: with SMTP id u28mr9127994ljl.453.1605133640065; Wed, 11 Nov 2020 14:27:20 -0800 (PST) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id m22sm348894lfb.27.2020.11.11.14.27.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 14:27:19 -0800 (PST) Received: by mail-lj1-f181.google.com with SMTP id s9so3834358ljo.11 for ; Wed, 11 Nov 2020 14:27:18 -0800 (PST) X-Received: by 2002:a05:651c:110:: with SMTP id a16mr12194059ljb.285.1605133638694; Wed, 11 Nov 2020 14:27:18 -0800 (PST) MIME-Version: 1.0 References: <20201104082738.1054792-1-hch@lst.de> <20201104082738.1054792-2-hch@lst.de> <20201110213253.GV3576660@ZenIV.linux.org.uk> <20201110213511.GW3576660@ZenIV.linux.org.uk> <20201110232028.GX3576660@ZenIV.linux.org.uk> <20201111215220.GA3576660@ZenIV.linux.org.uk> <20201111222116.GA919131@ZenIV.linux.org.uk> In-Reply-To: <20201111222116.GA919131@ZenIV.linux.org.uk> From: Linus Torvalds Date: Wed, 11 Nov 2020 14:27:02 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/6] seq_file: add seq_read_iter To: Al Viro Cc: Christoph Hellwig , Greg KH , Alexey Dobriyan , linux-fsdevel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Nov 11, 2020 at 2:21 PM Al Viro wrote: > > Something like below (build-tested only): Apart from my usual "oh, Gods, the iter model really does confuse me" this looks more like what I expected, yes. Considering the original bug, I'm clearly not the only one confused by the iov_iter helper functions and the rules.. Linus