From: Linus Torvalds <torvalds@linux-foundation.org>
To: Anton Altaparmakov <anton@tuxera.com>
Cc: "christian.brauner@ubuntu.com" <christian.brauner@ubuntu.com>,
"James.Bottomley@hansenpartnership.com"
<James.Bottomley@hansenpartnership.com>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"alban@kinvolk.io" <alban@kinvolk.io>,
"arnd@arndb.de" <arnd@arndb.de>,
"casey@schaufler-ca.com" <casey@schaufler-ca.com>,
"containers@lists.linux-foundation.org"
<containers@lists.linux-foundation.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"cyphar@cyphar.com" <cyphar@cyphar.com>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"dmitry.kasatkin@gmail.com" <dmitry.kasatkin@gmail.com>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"geofft@ldpreload.com" <geofft@ldpreload.com>,
"hch@lst.de" <hch@lst.de>,
"hirofumi@mail.parknet.co.jp" <hirofumi@mail.parknet.co.jp>,
"john.johansen@canonical.com" <john.johansen@canonical.com>,
"josh@joshtriplett.org" <josh@joshtriplett.org>,
"keescook@chromium.org" <keescook@chromium.org>,
"lennart@poettering.net" <lennart@poettering.net>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"luto@kernel.org" <luto@kernel.org>,
"mpatel@redhat.com" <mpatel@redhat.com>,
"paul@paul-moore.com" <paul@paul-moore.com>,
"selinux@vger.kernel.org" <selinux@vger.kernel.org>,
"seth.forshee@canonical.com" <seth.forshee@canonical.com>,
"smbarber@chromium.org" <smbarber@chromium.org>,
"stephen.smalley.work@gmail.com" <stephen.smalley.work@gmail.com>,
"tkjos@google.com" <tkjos@google.com>,
"tycho@tycho.ws" <tycho@tycho.ws>,
"tytso@mit.edu" <tytso@mit.edu>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"zohar@linux.ibm.com" <zohar@linux.ibm.com>
Subject: Re: [PATCH v6 24/40] fs: make helpers idmap mount aware
Date: Mon, 12 Apr 2021 09:23:38 -0700 [thread overview]
Message-ID: <CAHk-=wiXqbSgqzv53C98sbaHVqpc+c8NZTpXC7bBMQT3OznE4g@mail.gmail.com> (raw)
In-Reply-To: <E901E25F-41FA-444D-B3C7-A7A786DDD5D5@tuxera.com>
On Mon, Apr 12, 2021 at 5:05 AM Anton Altaparmakov <anton@tuxera.com> wrote:
>
> Shouldn't that be using mnt_userns instead of &init_user_ns both for the setattr_prepare() and setattr_copy() calls?
It doesn't matter for a filesystem that hasn't marked itself as
supporting idmaps.
If the filesystem doesn't set FS_ALLOW_IDMAP, then mnt_userns is
always going to be &init_user_ns.
That said, I don't think you are wrong - it would probably be a good
idea to pass down the 'mnt_userns' argument just to avoid confusion.
But if you look at the history, you'll see that adding the mount
namespace argument to the helper functions (like setattr_copy())
happened before the actual "switch the filesystem setattr() function
over to get the namespace argument".
So the current situation is partly an artifact of how the incremental
filesystem changes were done.
Linus
next prev parent reply other threads:[~2021-04-12 16:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 12:04 [PATCH v6 24/40] fs: make helpers idmap mount aware Anton Altaparmakov
2021-04-12 16:23 ` Linus Torvalds [this message]
2021-04-13 8:26 ` Christian Brauner
-- strict thread matches above, loose matches on Subject: below --
2021-01-21 13:19 [PATCH v6 00/40] idmapped mounts Christian Brauner
2021-01-21 13:19 ` [PATCH v6 24/40] fs: make helpers idmap mount aware Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiXqbSgqzv53C98sbaHVqpc+c8NZTpXC7bBMQT3OznE4g@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=adilger.kernel@dilger.ca \
--cc=alban@kinvolk.io \
--cc=anton@tuxera.com \
--cc=arnd@arndb.de \
--cc=casey@schaufler-ca.com \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=corbet@lwn.net \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=ebiederm@xmission.com \
--cc=geofft@ldpreload.com \
--cc=hch@lst.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=john.johansen@canonical.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=lennart@poettering.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mpatel@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=seth.forshee@canonical.com \
--cc=smbarber@chromium.org \
--cc=stephen.smalley.work@gmail.com \
--cc=tkjos@google.com \
--cc=tycho@tycho.ws \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).