From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14EA7C433DF for ; Tue, 30 Jun 2020 16:59:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7AAA20768 for ; Tue, 30 Jun 2020 16:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593536349; bh=oPlSxGwJv6Q9Jn6Pj3Ukuky8J2wsMIsNMguDoCPNm8U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=WZHjP9VtElNj7OPe1S4VJVFA4C02+JAzkgdqGdNoHILfa8DnQEMiNoopE83ro8PhJ wV2epTEPq2YjUDB/mdgEuUJeuwqquZtof2gYX3LZUs56WqTFnnKASLUPgcuTeRs9Pe /IyxoCaWO8/kFAAz2zk7crISGrRKmTZHdE9JrcJ4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389927AbgF3Q7J (ORCPT ); Tue, 30 Jun 2020 12:59:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389893AbgF3Q7I (ORCPT ); Tue, 30 Jun 2020 12:59:08 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7580EC061755 for ; Tue, 30 Jun 2020 09:59:08 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id s1so23448685ljo.0 for ; Tue, 30 Jun 2020 09:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ep4v7Sgk0x30ZAXgHmmvI+chKVNBUjoHn6j3LyL4OVk=; b=bDLuMC1J3ipv5oxg6WsuGLNLBbaQ55mOuGN9gmYd6tux50ZveMInMrUVjkMhagmtQ5 qLh1w/kcYRGFnMfNjLBP+bjgbKz0yTX5dUcCzabJRir+X9IwGpmmbEP2RWkxzYIDhJt9 UTsF2pc9EMEECfBDdQEKoYZ3atlchjta3NnSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ep4v7Sgk0x30ZAXgHmmvI+chKVNBUjoHn6j3LyL4OVk=; b=A9Ai9YGGPj8e+8X0hzXAdp3XVx8O1MnR4L6lFZ5yCBNmwJnwoghojyemzaK91uV+l6 SnR9ZNsHEjTznvCEFA4A99uN6D8MvCpdusX048abplMJI/dFU5f4HUh+Iw8G0wNTVjjP pwZlzrUWkn6UN4HcZVvlsc72gBABMbkMVGPNyxNaZMrG62eUPr+z3FvKytVpyktCKFS7 FhA+R6aJco58fyKABKyX1UmjMKdZlLwPKn3i5k5YCUTUos9qItVu5woyxmRaqWJml5Fk pWlTHeANYCMer2JFbTT26Z85dNqSEuqlm9bCPHLUWK2w8kd2XQTOyjGMPYSvW8TD1I4E QTXA== X-Gm-Message-State: AOAM530d4n3yb3mWzVkJtw8Afhbt85Sn8EUXmwtxsB33OoetPxdpNAdR U0khqRapUX1OTF1eAtKmlpjTxtJ0gcg= X-Google-Smtp-Source: ABdhPJzuUGX3vkUWDbkepLYF2wlMAOUesdjKRi408s8vqHWHvkhEtjRzw2YNFPXQ9TILUnBFu0s1OQ== X-Received: by 2002:a2e:80cc:: with SMTP id r12mr3410919ljg.344.1593536346086; Tue, 30 Jun 2020 09:59:06 -0700 (PDT) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com. [209.85.208.169]) by smtp.gmail.com with ESMTPSA id j17sm997553lfk.31.2020.06.30.09.59.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2020 09:59:04 -0700 (PDT) Received: by mail-lj1-f169.google.com with SMTP id d17so8739890ljl.3 for ; Tue, 30 Jun 2020 09:59:04 -0700 (PDT) X-Received: by 2002:a2e:999a:: with SMTP id w26mr5624686lji.371.1593536343609; Tue, 30 Jun 2020 09:59:03 -0700 (PDT) MIME-Version: 1.0 References: <20200625095725.GA3303921@kroah.com> <778297d2-512a-8361-cf05-42d9379e6977@i-love.sakura.ne.jp> <20200625120725.GA3493334@kroah.com> <20200625.123437.2219826613137938086.davem@davemloft.net> <87pn9mgfc2.fsf_-_@x220.int.ebiederm.org> <87y2oac50p.fsf@x220.int.ebiederm.org> <87bll17ili.fsf_-_@x220.int.ebiederm.org> <87imf963s6.fsf_-_@x220.int.ebiederm.org> In-Reply-To: <87imf963s6.fsf_-_@x220.int.ebiederm.org> From: Linus Torvalds Date: Tue, 30 Jun 2020 09:58:47 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 05/15] umh: Separate the user mode driver and the user mode helper support To: "Eric W. Biederman" Cc: Linux Kernel Mailing List , David Miller , Greg Kroah-Hartman , Tetsuo Handa , Alexei Starovoitov , Kees Cook , Andrew Morton , Alexei Starovoitov , Al Viro , bpf , linux-fsdevel , Daniel Borkmann , Jakub Kicinski , Masahiro Yamada , Gary Lin , Bruno Meneguele , LSM List , Casey Schaufler , Luis Chamberlain Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jun 29, 2020 at 1:05 PM Eric W. Biederman wrote: > > This makes it clear which code is part of the core user mode > helper support and which code is needed to implement user mode > drivers. > > kernel/umd.c | 146 +++++++++++++++++++++++++++++++++++++++ > kernel/umh.c | 139 ------------------------------------- I certainly don't object to the split, but I hate the name. We have uml, umd and umh for user mode {linux, drivers, helper} respectively.And honestly, I don't see the point in using an obscure and unreadable TLA for something like this. I really don't think it would hurt to write out even the full name with "usermode_driver.c" or something like that, would it? Then "umd" could be continued to be used as a prefix for the helper functions, by all means, but if we startv renaming files, can we do it properly? Linus