From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712C0C43457 for ; Thu, 15 Oct 2020 01:40:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 228BD22257 for ; Thu, 15 Oct 2020 01:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602726002; bh=z5LFzu3Z4CLTsNHYb5penoQej7Cy+VrhxZOPTYZVzWg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=QMZCQYpUOGyPS9q3OcDXvkyVuJNo0m/Yahgd335Fa75dYJM80kDxbayllDj8A42CN DBCXX/fxxKuPbz8Z3lwkYdPAzF/Ky69fpDu65k0pLeLzsIhsUKxPrGSQA+BRL5jyc2 V+TEd1C/GtljuinsTGDFNnzZ8QM03ms3X1BgZeIA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389287AbgJOBj7 (ORCPT ); Wed, 14 Oct 2020 21:39:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389157AbgJOBji (ORCPT ); Wed, 14 Oct 2020 21:39:38 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB23DC05113E for ; Wed, 14 Oct 2020 16:12:26 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id a7so1315760lfk.9 for ; Wed, 14 Oct 2020 16:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pAvZc2gfIDjGucI+VwMq6whQr0/X879Oidvupvz4o8Y=; b=A8ynlJkvJwu91bo1EWLWkCdSoSsQOYY27iLOzHN9LrJCn/9FttdpwSl7LCaiHFBWPU d2qwxL/Z2dBelY1gPIpdNoJbzejfSDUiWJ1po2uf2uumX/elh707ayGNBojGD8rKYC8W vfXI/Sd9WF7LGiFge0wniSqlTuIXeGGij18nY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pAvZc2gfIDjGucI+VwMq6whQr0/X879Oidvupvz4o8Y=; b=kJyZQKMmAUV5c0BtYFbGbpyz/4fKI5Tde7coq6k1LZBAtHMc1A0gQ1MBHf29k1ADJ8 XjEGONjtkEorOw5iYGFGZw+bOxTXJPOfpQOIQ0YLZnNLcraOq7ej0pv5UQ+R33HLy9TV fq84zY/0upZLtjhJDQHay+y0GCY4Y8ef5p8tm72NYA0yyglKwoLq3wwWLgXN+wIGqPdu jtj3Og6A4QDNwFrXyCkfOZVy9DA2VWWGyjROKGmbgDHcO51l3r9YvOM5pMtfHMkSwh6b HPkRzl4ZUIRCi2bBch66j4OyatiZIbzV+Kyw8E+sJaiZAyRx8lp43bGJs4G9HNETdBae OFxg== X-Gm-Message-State: AOAM531txz88Ksxb3P4u2sLXWnWTK6E6qCVK5Oiiswx/xsOKlZrj52zR ++wViAsU+S5F99jbxBtdUDU/wZxS93eWSg== X-Google-Smtp-Source: ABdhPJxa/nK6LtYU+xZx7m9JK4d5K3V0KSWIH5kQEPwG/CG7H78Q+QpEzi9y9DPzPLeeVTaIOnihMg== X-Received: by 2002:a19:f71a:: with SMTP id z26mr107331lfe.90.1602717145017; Wed, 14 Oct 2020 16:12:25 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id i11sm445815ljn.119.2020.10.14.16.12.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Oct 2020 16:12:23 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id v6so1286714lfa.13 for ; Wed, 14 Oct 2020 16:12:23 -0700 (PDT) X-Received: by 2002:ac2:5f48:: with SMTP id 8mr122638lfz.344.1602717143436; Wed, 14 Oct 2020 16:12:23 -0700 (PDT) MIME-Version: 1.0 References: <20201014204529.934574-1-andrii@kernel.org> <20201014230858.GL3576660@ZenIV.linux.org.uk> In-Reply-To: <20201014230858.GL3576660@ZenIV.linux.org.uk> From: Linus Torvalds Date: Wed, 14 Oct 2020 16:12:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] fs: fix NULL dereference due to data race in prepend_path() To: Al Viro Cc: Andrii Nakryiko , linux-fsdevel , kernel-team@fb.com, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Oct 14, 2020 at 4:09 PM Al Viro wrote: > > If you've already grabbed it, I'll just push a followup cleanup. Already grabbed (along with the ppc32 csum fix). Your suggested helper function cleanup sounds good. Linus