From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B6E1C43381 for ; Tue, 5 Mar 2019 00:04:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 580B32070B for ; Tue, 5 Mar 2019 00:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551744272; bh=eakGeNICj4jEUX4n8UM/wdXRJq9TWHaCTjj5SRWOFpo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=HhhnF0oQbchiogw0w/nwuoXzJ+46Y5LcelmNqmhcZM3rq+IU+O35hUuk7k9GfwNaE wbgCzILHxIv2E6eB9KC+mmch9/NBLUEIYJ0jJnEdruSboObY9C5yCfv3NBla4RhkTl 2KhzBjh0DsEhHDJ5hmq3SIkS7n1q/uU0Mfr6IqkM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726106AbfCEAEb (ORCPT ); Mon, 4 Mar 2019 19:04:31 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:43906 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbfCEAEb (ORCPT ); Mon, 4 Mar 2019 19:04:31 -0500 Received: by mail-lf1-f67.google.com with SMTP id p73so4227954lfe.10 for ; Mon, 04 Mar 2019 16:04:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6+or+R9ZXBalBggrOHVcu1Z47tiNZfL9C2jfjaW2L08=; b=M0UMb6JdBnBIp6SCfuvGBMn4scTD1lzprnlBLpuzDtuEWi6Eb9z3fRGl44/4vWrs2O nUFfCqCxj0e+QLkaBeVO/WND8wnulNTTeKFyDzxEMCYBF6OvPQvnsFVWsuyAdywYtO6H 4LiHh4PS0sQGMQetphZxWjGTOHZbJKAL881SM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6+or+R9ZXBalBggrOHVcu1Z47tiNZfL9C2jfjaW2L08=; b=PXT81ykhQZIpxR0we8PyW8Z4i6lC2ifulUZnViEcG8J2tlq4hpgacRfFdtEAlaGmRS +ls57iJ6S34ZBf3q/uaxJUDL9EwQrtDNFWqtNavQ0U5kkG1jbDPXZVzNNIKBCmlYU/lD 3W4CFe8ZNe2L0o/eNe9PETtkssAnt0AUS1Hzy38L4lTTIrnMksbbyN+rXlxtMIrizIG7 /+9VhNjtK7TXJWOPEFIlhIVJLX6p+NTYqGh+2MYzPU6s5Khz3lM509e9Rbv6LZYZ3Z3P EBsMiMfO4ylJ0hSZEEdK8ijaLp1yAKsFNi+OARwPN3NGlqPiAJ+f02LV50uB7rxmnRCy erog== X-Gm-Message-State: APjAAAUjVHNQBUAB5K8ziQo34yNqurVxgF3uXEfsft2aoN4ho7yaUic7 DecicKt3BoNZbdUikEG35y4MmSNi2dk= X-Google-Smtp-Source: APXvYqxVABc+5HHnrJNyqGVoWhO49vrUTh6LMv0pZO7QQ7f85Q3XcX0/otXJ5UI3y8cb8gLVmS1sNA== X-Received: by 2002:a19:a404:: with SMTP id q4mr12408888lfc.80.1551744268852; Mon, 04 Mar 2019 16:04:28 -0800 (PST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id b141sm1889451lfb.72.2019.03.04.16.04.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Mar 2019 16:04:28 -0800 (PST) Received: by mail-lf1-f50.google.com with SMTP id u9so715799lfe.11 for ; Mon, 04 Mar 2019 16:04:27 -0800 (PST) X-Received: by 2002:a19:40c2:: with SMTP id n185mr11458417lfa.67.1551744267351; Mon, 04 Mar 2019 16:04:27 -0800 (PST) MIME-Version: 1.0 References: <20190207154519.8635-1-kaslevs@vmware.com> <20190213094445.1774f959@gandalf.local.home> <20190219121212.6c46b979@gandalf.local.home> <20190304105836.33f80dc3@gandalf.local.home> In-Reply-To: <20190304105836.33f80dc3@gandalf.local.home> From: Linus Torvalds Date: Mon, 4 Mar 2019 16:04:11 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes To: Steven Rostedt Cc: Alexander Viro , Jens Axboe , Slavomir Kaslev , linux-fsdevel , Linux List Kernel Mailing , Andrew Morton Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Mar 4, 2019 at 7:58 AM Steven Rostedt wrote: > > I'm still just hearing crickets about this? Should I just send this > directly to Linus or Andrew? I'll take it. It looks sane. Of course, if it turns out that this breaks something that assumes that splice blocks purely based on the SPLICE_F_NONBLOCK flag, we'll have to revert it. Looking at the history of splice, it does look like it has always ignored O_NONBLOCK. Linus