From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DFF3C48BD1 for ; Thu, 10 Jun 2021 21:04:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6A1161404 for ; Thu, 10 Jun 2021 21:04:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230322AbhFJVGW (ORCPT ); Thu, 10 Jun 2021 17:06:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbhFJVGW (ORCPT ); Thu, 10 Jun 2021 17:06:22 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40C57C061574 for ; Thu, 10 Jun 2021 14:04:25 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id p7so5334775lfg.4 for ; Thu, 10 Jun 2021 14:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hvL3lGwbeiN7MBxmsi5XUSzTl5bywBkq1SiXoFH9p/Y=; b=h5msG03u/H4hnhe+y6dZRvJGZM7Z1bjF9rSXqXZFXISpshwR35XOKKkNfFcU03dOQZ UOuf4TEMF1JPT/M4VVo37xPOjNyCt/8oZXgGCHZDs4SCE2xITO/oY8+2Ss+oKPbfETpd Q1u/byu5sVQ5jFQU3+ukI40pjUCqgaobqASIg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hvL3lGwbeiN7MBxmsi5XUSzTl5bywBkq1SiXoFH9p/Y=; b=p9OFtdZVf0iDYdol4g7OhtES8tZtHArKqVpoN4eTXnsjNIMFxywLQLhQTl0i2OvGx8 maF4hZNaS2JbhSz1y4Gz6vHyulrsDX+o0plJnEpvaVAxYzdRe3cIgsOeTChuJvlBKZfp TSWDBsCoVYYnUMWvdGNP9eSjj/5X7k/3mUGlGxaL7kBlt0DZVnmaiU67nmsVneZiQ8A6 tb0pkzUhU0N4QEChwL0oxVsLmHMONKBZCOP0FFwlfGl7jrXt6VgjK7tnIe31JTtvtYQ7 PvNcCwJGv4mu2pJD38cMVr4mVeE/b5u1szikjqToWkdd4H86uuvW8oW3SG/C5KCF0YH4 HnJg== X-Gm-Message-State: AOAM530O+KfTw0CMUI19lqYBj7X6bEMPvd/H4taHGSN4FdMzCTVEmk2n H7mkknBeqEOPxrMVkMe5MX9VNg2W+EC6DtlcAVA= X-Google-Smtp-Source: ABdhPJypBOxuY9E2Ea9g78Ulxp8N4Qsy1RNt2HakMPXo/dln7F3iUBTY+eeLl3eUmdyWfEMYRzVz9A== X-Received: by 2002:a19:cd8:: with SMTP id 207mr451506lfm.322.1623359062181; Thu, 10 Jun 2021 14:04:22 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id t27sm468220ljo.130.2021.06.10.14.04.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 14:04:20 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id n12so5304564lft.10 for ; Thu, 10 Jun 2021 14:04:20 -0700 (PDT) X-Received: by 2002:a05:6512:3d13:: with SMTP id d19mr433821lfv.41.1623359060330; Thu, 10 Jun 2021 14:04:20 -0700 (PDT) MIME-Version: 1.0 References: <192c9697e379bf084636a8213108be6c3b948d0b.camel@trillion01.com> <9692dbb420eef43a9775f425cb8f6f33c9ba2db9.camel@trillion01.com> <87h7i694ij.fsf_-_@disp2133> <198e912402486f66214146d4eabad8cb3f010a8e.camel@trillion01.com> <87eeda7nqe.fsf@disp2133> <87pmwt6biw.fsf@disp2133> <87czst5yxh.fsf_-_@disp2133> <87y2bh4jg5.fsf@disp2133> <87sg1p4h0g.fsf_-_@disp2133> In-Reply-To: <87sg1p4h0g.fsf_-_@disp2133> From: Linus Torvalds Date: Thu, 10 Jun 2021 14:04:04 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] coredump: Limit what can interrupt coredumps To: "Eric W. Biederman" Cc: Olivier Langlois , Linux Kernel Mailing List , linux-fsdevel , io-uring , Alexander Viro , Jens Axboe , "Pavel Begunkov>" , Oleg Nesterov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jun 10, 2021 at 1:11 PM Eric W. Biederman wrote: > > Make the coredump code more robust by explicitly testing for all of > the wakeup conditions the coredump code supports. This prevents > new wakeup conditions from breaking the coredump code, as well > as fixing the current issue. Thanks, applied. And lots of thanks to Olivier who kept debugging the odd coredump behavior he saw. Linus